fix: #2370 send truncate events independent of response state #2385
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b906c24cf6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d56b511778
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if audio_limits is not None: | ||
| _, max_audio_ms = audio_limits | ||
| truncated_ms = max(int(round(effective_elapsed_ms)), 0) | ||
| if max_audio_ms is not None: |
| if audio_limits is not None: | ||
| _, max_audio_ms = audio_limits | ||
| truncated_ms = max(int(elapsed_ms), 0) | ||
| if max_audio_ms is not None: |
There was a problem hiding this comment.
I would suggest this:
- if max_audio_ms is not None:
- truncated_ms = min(truncated_ms, max_audio_ms)
- converted = _ConversionHelper.convert_interrupt(
- current_item_id,
- current_item_content_index,
- truncated_ms,
- )
- await self._send_raw_message(converted)
+ if self._ongoing_response or max_audio_ms is None or truncated_ms < max_audio_ms:
+ converted = _ConversionHelper.convert_interrupt(
+ current_item_id,
+ current_item_content_index,
+ truncated_ms,
+ )
+ await self._send_raw_message(converted)
This pull request resolves #2370 by fixing a bug in #2374
context: #2370 (comment)