Support enable/disable skill via config/api. #9328

xl-openai · 2026-01-15T22:27:13Z

In config.toml:

[[skills.config]]
path = "/Users/xl/.codex/skills/my_skill/SKILL.md"
enabled = false

API:
skills/list, skills/config/write

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4495f2c05

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/edit.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d97e5a3ebc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-16T20:20:00Z

codex-rs/app-server/src/codex_message_processor.rs

+                self.thread_manager.skills_manager().clear_cache();
+                self.outgoing
+                    .send_response(
+                        request_id,
+                        SkillsConfigWriteResponse {


Refresh user instructions after skill toggle

On success, skills_config_write only clears the skills cache. Existing threads keep the user_instructions that were computed at session spawn from the then‑enabled skills, so toggling a skill while a thread is active leaves the old skill list in the system prompt. In that scenario the model can still be guided by the stale list until the session restarts. Consider reloading thread configs or regenerating user_instructions for active sessions after a successful write.

Useful? React with 👍 / 👎.

That's true but we don't want to modify the history. We will think of a better solution later.

codex-rs/core/src/skills/model.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 840a9012b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/edit.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e129b3d52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/config/edit.rs

xl-openai · 2026-01-17T00:32:49Z

@codex review again

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e129b3d52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-17T00:42:33Z

codex-rs/core/src/skills/loader.rs

+    let mut seen: HashSet<PathBuf> = HashSet::new();
    outcome
        .skills
-        .retain(|skill| seen.insert(skill.name.clone()));
+        .retain(|skill| seen.insert(skill.path.clone()));


Preserve name-level dedupe or update clients to disambiguate

By deduping only on skill.path here, the loader now allows multiple skills with the same name (e.g., repo and user copies) to coexist. Existing clients still resolve $SkillName mentions by name only (see codex-rs/tui/src/chatwidget.rs find_skill_mentions which skips duplicates by skill.name), so the first entry in the list always wins and the other same‑name skill becomes unreachable. This is a regression from the prior name-based dedupe and can cause the wrong skill’s instructions to be injected when a user intends the other copy. Consider keeping name-level dedupe for user-visible lists or updating clients to disambiguate by path.

Useful? React with 👍 / 👎.

xl-openai force-pushed the xl/skill-enable branch 4 times, most recently from bbb9839 to 1bbf53c Compare January 16, 2026 01:08

Support enable/disable skill via config/api.

a4495f2

xl-openai force-pushed the xl/skill-enable branch from 1bbf53c to a4495f2 Compare January 16, 2026 01:19

xl-openai marked this pull request as ready for review January 16, 2026 01:35

xl-openai requested review from bolinfest and gverma-openai January 16, 2026 01:38

chatgpt-codex-connector bot reviewed Jan 16, 2026

View reviewed changes

codex-rs/core/src/config/edit.rs Show resolved Hide resolved

Remove skills_cmd for now.

d97e5a3

chatgpt-codex-connector bot reviewed Jan 16, 2026

View reviewed changes

xl-openai force-pushed the xl/skill-enable branch from 81eb1a8 to 840a901 Compare January 16, 2026 23:25

chatgpt-codex-connector bot reviewed Jan 16, 2026

View reviewed changes

codex-rs/core/src/config/edit.rs Show resolved Hide resolved

Dedupe using path instead.

6e129b3

xl-openai force-pushed the xl/skill-enable branch from 840a901 to 6e129b3 Compare January 17, 2026 00:15

chatgpt-codex-connector bot reviewed Jan 17, 2026

View reviewed changes

codex-rs/core/src/config/edit.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Jan 17, 2026

View reviewed changes

gverma-openai approved these changes Jan 17, 2026

View reviewed changes

xl-openai merged commit ad8bf59 into main Jan 17, 2026
74 of 80 checks passed

xl-openai deleted the xl/skill-enable branch January 17, 2026 04:22

github-actions bot locked and limited conversation to collaborators Jan 17, 2026

Support enable/disable skill via config/api. #9328

Support enable/disable skill via config/api. #9328

Uh oh!

Conversation

xl-openai commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

xl-openai Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

xl-openai commented Jan 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

xl-openai Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xl-openai commented Jan 15, 2026 •

edited

Loading