chore(app-server) Use UserTurn for app-server turn start#15429
Closed
dylan-hurd-oai wants to merge 2 commits intomainfrom
Closed
chore(app-server) Use UserTurn for app-server turn start#15429dylan-hurd-oai wants to merge 2 commits intomainfrom
dylan-hurd-oai wants to merge 2 commits intomainfrom
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Base automatically changed from
dh--app-server--turn-approvals-reviewer
to
main
March 23, 2026 22:19
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates turn/start in app-server to use Op::UserTurn.
Risk / Open Question: we are now populating Op::UserTurn fields from
thread.config_snapshot(), which would overwrite newer session settings such as cwd, model, approval_policy, sandbox_policy, or approvals_reviewer. I think it would be ideal for us to start simplifying the interface here - I'm curious for @owenlin0 or @celia-oai's take on the right way to handle this.Testing