Pybind11 contiguous check: Accept only C-contiguous, not Fortran contiguous#1886
Merged
Merged
Conversation
franzpoeschel
changed the title
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for
'A'means success if the buffer is contiguous in either C or Fortran. The Python bindings are not the right place to accept Fortran-style arrays; in any case it would be the job of eventual Fortran bindings to find a solution for storing those correctly. At this point, we can accept only C-style arrays.Unintended consequence: Our bindings currently do not catch the noncontiguous buffer view created by transposing an array:
Close #1882