Skip to content

Reactivate iteration closed check #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 3 commits into from
Jan 23, 2026
Merged

Reactivate iteration closed check #1829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492ef59
Reactivate Iteration::closed() check
franzpoeschel Jan 12, 2026
c207667
Fix test
franzpoeschel Jan 13, 2026
a963d73
Add a test if the RecordComponent is contained by any Iteration
franzpoeschel Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/RecordComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,20 @@ namespace internal
Attributable a;
a.setData(std::shared_ptr<AttributableData>{this, [](auto const &) {}});
// this check can be too costly in some setups
#if 0
if (a.containingIteration().closed())
#if openPMD_USE_INVASIVE_TESTS

auto maybe_an_iteration = a.containingIteration().first;
if (!maybe_an_iteration.has_value())
{
throw error::WrongAPIUsage(
throw std::runtime_error(
"Trying to write to/read from a RecordComponent that is not "
"contained by any Iteration.");
}
auto &iterationData = *maybe_an_iteration.value();
auto iteration = iterationData.asInternalCopyOf<Iteration>();
if (iteration.closed() && !iterationData.allow_reopening_implicitly)
{
throw std::runtime_error(
"Cannot write/read chunks to/from closed Iterations.");
}
#endif
Expand Down
Loading