[Do not merge yet] Fix: Read ParticlePatches Attr#1612
Closed
ax3l wants to merge 1 commit intoopenPMD:devfrom
Closed
[Do not merge yet] Fix: Read ParticlePatches Attr#1612ax3l wants to merge 1 commit intoopenPMD:devfrom
ParticlePatches Attr#1612ax3l wants to merge 1 commit intoopenPMD:devfrom
Conversation
`ParticlePatches` are no openPMD records but a special group. It does not need required record components such as `unitDimension`.
s-sajid-ali
approved these changes
Apr 17, 2024
ParticlePatches AttrParticlePatches Attr
Member
Author
|
Fix coming via openPMD/openPMD-validator#75 and openPMD/openPMD-example-datasets#23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParticlePatchesare no openPMD records but a special group. It does not need required record components such asunitDimension.Ref.: https://github.com/openPMD/openPMD-standard/blob/1.1.0/STANDARD.md#sub-group-for-each-particle-species
Fix #1609
Update: oh, but we write
Action Items
I will probably to the latter.