WEB-814 Make easier to upload client Identifiers

[Varun789-mx]

Description

When adding a client identifier, the dialog required users to manually type the file name into a separate "File Name" field after already selecting a file via the Browse button. This was redundant and error-prone. The fix automatically populates the File Name field with the selected file's name when a file is chosen, improving the user experience and reducing unnecessary manual input.

Related issues and discussion

#WEB-814 Make easier to upload client Identifiers

Before

MIFOS-WEB-814-BEFORE.mp4

After

MIFOS-WEB-814-AFTER.mp4

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • Fixed document upload dialog to preserve existing file name values when selecting a new document file.
• Documentation
  • Clarified upload dialog behavior: selecting a file sets the file input and only populates the file name if none was previously provided.

[coderabbitai]

Warning

Rate limit exceeded

@Varun789-mx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5bcd8243-7064-45c5-a1b4-1147c8b70250

📥 Commits

Reviewing files that changed from the base of the PR and between f81f28c and fbbfa7a.

📒 Files selected for processing (1)

• src/app/clients/clients-view/custom-dialogs/upload-document-dialog/upload-document-dialog.component.ts

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Updated JSDoc and comments in a single component file to clarify that onFileSelect sets the file form control and conditionally sets fileName only when the current fileName is empty; the runtime behavior of the method was not changed.

Changes

Cohort / File(s)	Summary
Upload Document Dialog src/app/clients/clients-view/custom-dialogs/upload-document-dialog/upload-document-dialog.component.ts	Adjusted JSDoc for onFileSelect to accurately document that it sets the file form control and conditionally sets the fileName form control only if it is currently empty. No functional changes to method logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• WEB-815 automatically the Filename #3259: Updates the same onFileSelect JSDoc/behavior description to reflect conditional auto-fill of fileName.

Suggested reviewers

• IOhacker
• alberto-art3ch

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title references WEB-814 and mentions 'Make easier to upload client Identifiers', which aligns with the actual change that auto-populates the file name field to simplify the upload workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/app/clients/clients-view/custom-dialogs/upload-document-dialog/upload-document-dialog.component.ts`:
- Around line 112-117: The onFileSelect handler currently only sets the fileName
control and leaves the file control as its initial empty string, causing uploads
to fail and .name access to throw in the consumer
(entity-documents-tab.component.ts). Update onFileSelect to also set the file
form control to the selected File object (use
uploadDocumentForm.get('file').setValue(file)) so dialogResponse.file is the
File, and optionally mark the control as touched/dirty or run validation after
setting; keep the existing fileName setValue behavior intact.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e28d4ead-37cf-45ce-813b-585eb7ac220f

📥 Commits

Reviewing files that changed from the base of the PR and between 0437580 and 711208a.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json and included by **/*

📒 Files selected for processing (2)

• src/app/clients/clients-view/custom-dialogs/upload-document-dialog/upload-document-dialog.component.ts
• src/environments/.env.ts

[IOhacker]

Please review proposed fix, exclude from commit the json and the env files

[IOhacker]

Exclude this file from commit

[Varun789-mx]

Made the requested changes and also didn't commited the env file this sorry for the silly mistake i made earlier

[IOhacker]

@Varun789-mx there is a conflict. Please squash and commit

[Varun789-mx]

made the change and also squashed them into one commit , Please review @IOhacker