Possible resolution to web-100.#2645
Conversation
steinwinde
left a comment
steinwinde
left a comment
There was a problem hiding this comment.
Looking at the diff of your commit, it appears that you based your PR on an obsolete state of the dev branch. Please merge the latest changes of the dev branch into your feature branch, before you provide a PR.
mjpugh811
force-pushed
the
web-100-v4
branch
from
ce38085 to
38af216
Compare
|
Warning Rate limit exceeded@mjpugh811 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 11 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (15)
WalkthroughAdds empty-state conditional markup to the client General tab template, a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mjpugh811
force-pushed
the
web-100-v4
branch
from
53ea192 to
b1d0ee8
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/lt-LT.json (1)
1063-1074: Incorrect translation language detected.The translation at line 1074 for "No shares accounts" appears to be in Latvian ("Nav atrasts neviens koplietošanas konts") rather than Lithuanian. This is inconsistent with the locale file (lt-LT) and other translations.
The correct Lithuanian translation should be something like:
- "No shares accounts": "Nav atrasts neviens koplietošanas konts." + "No shares accounts": "Akcijų sąskaitų nerasta."Please verify all new translations are in the correct language (Lithuanian) for this locale file.
🧹 Nitpick comments (5)
src/assets/translations/fr-FR.json (1)
3062-3074: Align “deposit” terminology with existing glossaryPour cohérence avec le reste du fichier (p. ex. lignes 930 : “Comptes de dépôt fixe”, 932 : “Produits de dépôt fixe”), il vaudrait mieux traduire
"No deposit accounts"par “Aucun compte de dépôt fixe n'a été trouvé.” Placer ici “dépôt à terme” introduit une terminologie différente pour le même produit et risque de brouiller les utilisateurs francophones.src/assets/translations/it-IT.json (2)
2493-2493: Include “transazione” in the refund label.The English key is “Skip Interest Refund Transaction Posting”, but the Italian string omits “transazione”. Without it, the wording loses the idea that it’s the transaction posting being skipped. Please align the translation.
A possible fix:
-"Skip Interest Refund Transaction Posting": "Salta la registrazione del rimborso degli interessi" +"Skip Interest Refund Transaction Posting": "Salta la registrazione della transazione di rimborso degli interessi"
3064-3075: Keep the empty-state message generic.“Conti deposito a termine” narrows the meaning to fixed-term deposits, while the UI label just says “deposit accounts”. Please use a generic form so the Italian copy matches the product grouping.
Suggested change:
-"No deposit accounts": "Non sono stati trovati conti deposito a termine." +"No deposit accounts": "Non sono stati trovati conti deposito."src/assets/translations/cs-CS.json (1)
3064-3075: Align empty-state punctuationMost existing “No …” messages in this locale omit trailing punctuation (e.g., “Nenalezena žádná data”). Consider dropping the periods here to stay consistent with the rest of the Czech empty-state strings.
src/assets/translations/en-US.json (1)
3174-3190: LGTM! Well-structured empty-state messages.The five new translation entries for "No account" messages are clear, grammatically correct, and follow the existing naming conventions in the file. They align well with the PR objective to display appropriate language messages when no accounts of a given type are available.
Minor suggestions for consistency:
- Line 3186: "No recurring accounts" → Consider using "No recurring deposit accounts" for full clarity and consistency with the message text
- Lines 3174-3190: All messages end with "found." which is grammatically correct, though you could consider a more concise format like "There are no {Account Type} available." for better UX
If you prefer more concise messages, consider this alternative format:
- "No deposit accounts": "There are no Fixed Deposit Accounts found.", - "No loan accounts": "There are no Loan Accounts found.", - "No recurring accounts": "There are no Recurring Deposit accounts found.", - "No saving accounts": "There are no Saving Accounts found.", - "No shares accounts": "There are no Shares Accounts found.", + "No deposit accounts": "No Fixed Deposit Accounts available.", + "No loan accounts": "No Loan Accounts available.", + "No recurring accounts": "No Recurring Deposit Accounts available.", + "No saving accounts": "No Saving Accounts available.", + "No shares accounts": "No Shares Accounts available.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(5 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(5 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🔇 Additional comments (20)
src/assets/translations/ko-KO.json (3)
3063-3074: LGTM! Empty-state message translations added correctly.The new "No ... accounts" translation keys align perfectly with the PR objective (web-100) to display appropriate language messages when no accounts of a given type are available. The keys follow a consistent naming pattern and are properly structured as JSON entries.
Note: I cannot verify the accuracy of the Korean translations themselves, but the structure and placement are correct.
2494-2494: Interest refund configuration translation added.This new translation key supports the interest refund transaction posting configuration feature. The key is properly formatted and placed within the appropriate section of the translations file.
3527-3527: Interest refund tooltip translation added.This tooltip translation provides user guidance for the interest refund feature. The key placement in the tooltips section is appropriate and follows the existing pattern.
src/assets/translations/es-CL.json (3)
1168-1168: Translation for "Principal Amount" looks correct.The translation "Monto principal" for "Principal Amount" is accurate and consistent with financial terminology in Spanish.
2493-2493: Verify consistency of interest refund translation.The same translation appears twice in the file:
- Line 2493: Under
inputssection- Line 3527: Under
tooltipssectionThe translation "Omitir el registro de la devolución de intereses" (Skip interest refund transaction posting) and "Transacciones de reembolso en las que el reembolso de intereses se calculará automáticamente" (Refund transactions where interest refund will automatically be calculated) appear to be for different contexts.
Ensure these are mapped to the correct UI elements and that the distinction between "Skip" vs "automatic calculation" is intentional.
Also applies to: 3527-3527
3063-3074: Verify and standardize empty-state translations
- Confirmed matching en-US.json entries and template usage for the five account types; Spanish translations accurately reflect “No se encontraron cuentas de …” for depósito fijo, préstamos, depósito recurrente, ahorro y acciones.
- Loan-specific messages (“No loan locked available”, “No pending loan available for disbursal”) use “No hay…” rather than “No se encontraron…”. To maintain consistency across empty-state keys, consider rephrasing them as “No se encontraron cuentas de crédito bloqueado” and “No se encontraron cuentas de crédito pendientes para desembolso”.
- Non-account keys (notifications, report data, reembolsos/dis¬bos¬los) remain contextually appropriate.
No code changes required until pattern updates are applied.src/assets/translations/lt-LT.json (2)
1169-1169: LGTM!The translation for "Principal Amount" is correctly added in Lithuanian and is consistent with other translations in the file.
2493-2493: LGTM!The translation for "Skip Interest Refund Transaction Posting" is correctly added in Lithuanian and fits well within the inputs section.
src/assets/translations/es-MX.json (6)
924-924: Translation consistency confirmed“Family Members” → “Miembros de la familia” keeps the existing style and reads naturally for MX Spanish. No issues here.
1168-1168: Translation matches existing terminology“Principal Amount” → “Monto principal” aligns with how other entries in this locale file express “principal.” Looks good.
1608-1608: Uppercase label stays faithful“FAMILY MEMBERS” → “MIEMBROS DE LA FAMILIA” mirrors the casing and meaning. No changes needed.
3064-3075: Empty-state messages read wellThe new “No … accounts” strings (“No se encontraron cuentas …”) are clear and idiomatic for MX Spanish. Nice work.
3310-3310: Good fidelity on Maker‑Checker explanationThe longer descriptive sentence preserves intent and tone in Spanish. No adjustments needed.
3527-3527: Interest refund note remains accurate“Transacciones de reembolso…” cleanly conveys the meaning and matches our preferred terminology. Solid translation.
src/assets/translations/ne-NE.json (2)
3063-3075: LGTM! Empty-state messages added as per PR objective.The addition of "No X accounts" messages aligns with the PR objective (web-100) to display appropriate language messages when no accounts of a given type are available. The five new keys cover:
- No deposit accounts (line 3063)
- No loan accounts (line 3064)
- No recurring accounts (line 3070)
- No saving accounts (line 3073)
- No shares accounts (line 3074)
Note on translation accuracy: While the additions are structurally correct, verification of the Nepali translations' accuracy and cultural appropriateness should be performed by a native Nepali speaker or professional translator to ensure the messages are clear and user-friendly.
3169-3169: Heading entry appears correct.The "Principal Amount" entry at line 3169 appears to be a standard heading/label translation and is consistent with the JSON structure.
src/assets/translations/de-DE.json (4)
3062-3073: LGTM! New empty-state translations added.The new "No ... accounts" translations have been added correctly to support localized empty-state messaging in the General tab. The German translations are grammatically correct and contextually appropriate:
- "No deposit accounts": "Es wurden keine Festgeldkonten gefunden."
- "No loan accounts": "Es wurden keine Darlehenskonten gefunden."
- "No recurring accounts": "Es wurden keine Dauereinzahlungskonten gefunden."
- "No saving accounts": "Es wurden keine Sparkonten gefunden."
- "No shares accounts": "Es wurden keine Aktienkonten gefunden."
These translations align with the PR objective of displaying empty-state messages in the appropriate language.
1169-1169: Translation added for "Principal Amount".The translation "Hauptbetrag" for "Principal Amount" has been added. This is a standard financial term and the German translation is correct.
2493-2493: Interest refund translation added.The translation "Buchung der Zinsrückerstattung überspringen" for "Skip Interest Refund Transaction Posting" has been added. This translation is grammatically correct and contextually appropriate for the interest refund functionality.
3526-3526: Tooltip translation for interest refund added.The tooltip translation "Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird" has been added for "Refund transactions where interest refund will automatically be calculated". This is a clear and accurate German translation.
|
Sorry to say, but I've just asked Google translate for two of the suggested translations that coderabbitai critisized as being in the wrong language. And according to Google translate, the new translations are indeed in the wrong language. Please go through the AI criticism of your PR and correct what is to be corrected. |
steinwinde
left a comment
steinwinde
left a comment
There was a problem hiding this comment.
Coderabbit seems to have a point with its criticism, at least regarding translations being provided that don't match the required language.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/assets/translations/lt-LT.json(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (2)
src/assets/translations/es-MX.json (1)
2493-2493: Address previous reviewer feedback on "Skip Interest Refund Transaction Posting" translation.A prior review comment (line 2485-2493) suggested translating this as "Omitir el registro de la transacción de reembolso de intereses" to include the missing noun "transacción" and maintain consistency with prior terminology. However, the current translation is "Omitir el registro de la devolución de intereses", which uses "devolución" instead of "reembolso" and omits "transacción".
Please clarify whether this deviation from the suggested translation was intentional, or apply the reviewer's suggested wording to align with established terminology across the file.
src/assets/translations/lt-LT.json (1)
3074-3074: Critical: Incorrect translation language – Latvian text still present in Lithuanian locale after previous correction attempt.Line 3074 contains text that appears to be in Latvian ("Nav atrasto neviens koplietošanas konts.") rather than Lithuanian. This was previously flagged in review but remains uncorrected. The PR objectives explicitly state that 'No account' messages should be displayed in the appropriate language, and a previous commenter confirmed that incorrect translations were identified.
This entry must be corrected to proper Lithuanian to match the established pattern in this file and meet the PR's core objective.
- "No shares accounts": "Nav atrasto neviens koplietošanas konts." + "No shares accounts": "Akcijų sąskaitų nerasta."This correction aligns with the Lithuanian pattern established in surrounding lines (e.g., "Paskolų sąskaitų nerasta." at line 3064) and maintains consistency with the empty-state messaging convention used throughout the file.
🧹 Nitpick comments (2)
src/assets/translations/fr-FR.json (1)
3062-3073: Consider UX-appropriate phrasing for empty-state messages.The current translations use complete sentences ("Aucun compte de prêt n'a été trouvé" = "No loan account was found"), whereas empty-state UI patterns often favor shorter, fragment-style phrases. Compare with similar entries in this file (e.g., line 3056–3074 region) to ensure consistency with the application's established localization style for empty states.
If the UI expects fragments (e.g., "Aucun compte de prêt") rather than full sentences, consider whether these translations should be simplified.
src/assets/translations/it-IT.json (1)
3063-3074: Refactor to use more natural Italian for UI context.The translations are in Italian but use a verbose "Non sono stati trovati" (passive past participle) construction. More natural UI-style Italian prefers "Nessun/a ... trovato" (singular) or adjusted nouns:
- "Non sono stati trovati conti deposito a termine" → Nessun conto deposito a termine trovato (or simply: Nessun conto deposito a termine)
- "Non sono stati trovati conti di prestito" → Nessun conto prestito trovato (or: Nessun prestito trovato)
- "Non sono stati trovati conti di deposito ricorrenti" → Nessun conto deposito ricorrente trovato
- "Non sono stati trovati conti di risparmio" → Nessun conto risparmio trovato (or: Nessun conto di risparmio trovato)
- "Non sono stati trovati conti azionari" → Nessun conto azionario trovato
These alternatives are more concise and consistent with typical UI messaging patterns in Italian locales.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(5 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(5 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/assets/translations/es-CL.json
- src/assets/translations/lv-LV.json
- src/assets/translations/en-US.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
🔇 Additional comments (15)
src/assets/translations/sw-SW.json (1)
3063-3074:⚠️ Verify translations flagged in previous review for language accuracyThe PR comment notes that CodeRabbit flagged two translations as being in the wrong language. The new translations added include:
- Line 3063: "No deposit accounts" → "Hakuna Akaunti za Amana zisizobadilika zilizopatikana."
- Line 3064: "No loan accounts" → "Hakuna Akaunti za Mikopo zilizopatikana."
- Line 3070: "No recurring accounts" → "Hakuna akaunti za Amana Zinazojirudia zilizopatikana."
- Line 3073: "No saving accounts" → "Hakuna Akaunti za Kuhifadhi zilizopatikana."
- Line 3527: "Refund transactions where interest refund will automatically be calculated" → "Shughuli za kurejesha pesa ambapo urejeshaji wa riba utahesabiwa kiotomatiki"
Please verify which specific translations were flagged and correct any that are not in Swahili or are inaccurate. Ensure all new translations follow the existing translation patterns and terminology conventions used elsewhere in this file.
Also applies to: 3527-3527
src/assets/translations/ne-NE.json (2)
3063-3074: Verify translation accuracy for new "No X accounts" messages.Per the previous reviewer's feedback, some translations flagged by CodeRabbit were checked via Google Translate and appeared incorrect. The following new entries require verification:
- Line 3063: "No deposit accounts" → "कुनै पनि फिक्स्ड डिपोजिट खाताहरू भेटिएनन्।"
- Line 3064: "No loan accounts" → "कुनै पनि ऋण खाता फेला परेन।"
- Line 3070: "No recurring accounts" → "कुनै पनि आवर्ती निक्षेप खाताहरू फेला परेनन्।"
- Line 3073: "No saving accounts" → "कुनै पनि बचत खाताहरू फेला परेनन्।"
- Line 3074: "No shares accounts" → "कुनै पनि शेयर खाताहरू फेला परेनन्।"
Please confirm these are:
- Correct Nepali language (not a different language or machine-generated error)
- Semantically accurate and appropriate for UI display
- Consistent with Nepali language conventions for user-facing messages
1169-1169: Verify additional new translation entries.The following entries were also added in this PR and should be verified for accuracy:
- Line 1169: "Principal Amount" → "मूल रकम"
- Line 2493: "Skip Interest Refund Transaction Posting" → "ब्याज फिर्ता पोस्टिङ्ग छोड्नुहोस्"
- Line 3527: "Refund transactions where interest refund will automatically be calculated" → "फिर्ता लेनदेन जहाँ ब्याज फिर्ता स्वतः गणना हुनेछ"
Confirm these translations are accurate, semantically sound, and use proper Nepali language conventions.
Also applies to: 2493-2493, 3527-3527
src/assets/translations/fr-FR.json (1)
3062-3073: Verify French translations for "No X accounts" empty-state messages per PR feedback.The commenter noted that two suggested translations appeared to be in the wrong language when verified via Google Translate. The current visible translations at these lines are in French and grammatically sound (e.g., "Aucun compte de prêt n'a été trouvé"), but without access to the specific coderabbit feedback, I cannot definitively confirm whether these are the flagged entries or whether corrections were already applied.
Recommendation: Please confirm that all five "No X accounts" translations at lines 3062–3073 have been reviewed and corrected per the commenter's (steinwinde) findings and are indeed in French (not accidentally in another language).
src/assets/translations/es-MX.json (1)
3063-3074: Verify language and completeness of empty-state "No X accounts" messages.The PR objectives mention that translations were flagged as potentially being in the wrong language. Please verify that the following new empty-state translations are correct Spanish (es-MX) and not accidentally in another language:
- Line 3063: "No deposit accounts" → "No se encontraron cuentas de depósito fijo."
- Line 3064: "No loan accounts" → "No se encontraron cuentas de préstamos."
- Line 3070: "No recurring accounts" → "No se encontraron cuentas de depósito recurrente."
- Line 3073: "No saving accounts" → "No se encontraron cuentas de ahorro."
- Line 3074: "No shares accounts" → "No se encontraron cuentas de acciones."
These translations appear grammatically correct in Spanish, but given the PR comment about translations being flagged as in the wrong language, please confirm these are the intended translations and have been verified by a native Spanish speaker or against Google Translate/professional resources.
src/assets/translations/cs-CS.json (1)
3063-3074: Verify Czech translations for "No accounts" messages—language accuracy flagged in PR comments.The PR commenter reported that certain AI-flagged translations appeared to be in the wrong language when verified with Google Translate. The following newly added "No X accounts" messages should be verified for correctness:
- Line 3063:
"No deposit accounts": "Nebyly nalezeny žádné termínované vkladové účty."- Line 3064:
"No loan accounts": "Nebyly nalezeny žádné úvěrové účty."- Line 3070:
"No recurring accounts": "Nebyly nalezeny žádné účty s opakovanými vklady."- Line 3073:
"No saving accounts": "Nebyly nalezeny žádné spořicí účty."- Line 3074:
"No shares accounts": "Nebyly nalezeny žádné akciové účty."While these entries appear grammatically consistent with Czech language patterns in the file, the PR comments indicate translation accuracy concerns. Please clarify which specific translations were flagged as incorrect and provide corrected versions if needed.
src/assets/translations/de-DE.json (4)
3062-3073: Verify newly added empty-state message translations for language and accuracy.The PR comment from
steinwindeindicates that some of these new "No X accounts" translations were flagged as being in the wrong language when checked via Google Translate. Please verify these translations are:
- Correctly in German (de-DE)
- Use appropriate and consistent phrasing for "no accounts" empty states
- Match the existing translation style in the file
Specifically, verify these lines:
- Line 3062: "No deposit accounts" → "Es wurden keine Festgeldkonten gefunden."
- Line 3063: "No loan accounts" → "Es wurden keine Darlehenskonten gefunden."
- Line 3069: "No recurring accounts" → "Es wurden keine Dauereinzahlungskonten gefunden."
- Line 3072: "No saving accounts" → "Es wurden keine Sparkonten gefunden."
- Line 3073: "No shares accounts" → "Es wurden keine Aktienkonten gefunden."
Please use a translation tool (e.g., Google Translate, DeepL) to verify these German translations are accurate and in the correct language. If any are found to be incorrect, please provide corrected versions before merge.
1169-1169: Verify "Principal Amount" translation.This translation at line 1169 should be reviewed to ensure it accurately represents the English term in German accounting/financial context:
- Line 1169: "Principal Amount" → "Hauptbetrag"
While "Hauptbetrag" is a valid German translation, verify it's consistent with how this term is used elsewhere in the file and aligns with financial terminology conventions.
2493-2493: Verify "Skip Interest Refund Transaction Posting" translation.Please verify this translation is correctly in German and uses appropriate financial terminology:
- Line 2493: "Skip Interest Refund Transaction Posting" → "Buchung der Zinsrückerstattung überspringen"
3526-3526: Verify "Refund transactions where interest refund will automatically be calculated" translation.This long translation should be reviewed for accuracy and clarity:
- Line 3526: "Refund transactions where interest refund will automatically be calculated" → "Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird"
src/assets/translations/lt-LT.json (2)
3063-3073: Verify Lithuanian translations for "No X accounts" empty-state messages.The newly added empty-state translations at lines 3063–3073 appear to follow proper Lithuanian grammar and conventions. However, given that line 3074 was found to contain incorrect text, please verify that all of these translations are correct Lithuanian:
- Line 3063: "Terminuotų indėlių sąskaitų nerasta."
- Line 3064: "Paskolų sąskaitų nerasta."
- Line 3070: "Nerasta jokių pasikartojančių indėlių sąskaitų."
- Line 3073: "Taupomųjų sąskaitų nerasta."
If possible, cross-reference these with native Lithuanian speakers or established Lithuanian UI translation conventions to confirm they align with the PR objective of displaying messages "in the appropriate language."
3527-3527: Approve: Refund transaction translation corrected to Lithuanian.The translation at line 3527 has been corrected from Latvian to proper Lithuanian: "Grąžinimo operacijos, kai palūkanų grąžinimas bus automatiškai apskaičiuotas". This change aligns with the PR objectives and previous review feedback.
src/app/clients/clients-view/general-tab/general-tab.component.scss (1)
1-1: LGTM on the SCSS changes.The new
.no-account-messageclass is straightforward and the version annotation is helpful for tracking. The styling choice is appropriate for an informational message.Also applies to: 54-57
src/assets/translations/it-IT.json (1)
3527-3527: Verify refund transaction translation.Line 3527 adds a new translation key. Please confirm this Italian translation is semantically correct and grammatically sound:
"Refund transactions where interest refund will automatically be calculated" → "Transazioni di rimborso in cui il rimborso degli interessi verrà calcolato automaticamente"src/assets/translations/pt-PT.json (1)
1169-1169: No issues found. Both translations are well-formed and consistent with existing terminology.The verification confirms:
- "Principal Amount": "Valor principal" is properly formatted and consistent with corresponding entries across other language files (Czech, German, English)
- "Ignorar o lançamento do reembolso de juros" uses standard Portuguese financial terminology, with "reembolso de juros" appearing consistently in existing entries at lines 728, 2471, 2472, and 2473
- The terminology pattern for "refund" translations is consistent across the file (e.g., "Reembolso de cobrança", "Reembolso de pagamento", "Reembolso emitido pelo comerciante")
- "Skip Interest Refund Transaction Posting" is present and properly translated in other language files (Czech, German, Spanish), validating these are legitimate entries
steinwinde
left a comment
steinwinde
left a comment
There was a problem hiding this comment.
I'm afraid Coderabbit made some good points. Could you rectify all Coderabbit complaints?
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
src/assets/translations/lv-LV.json (2)
3074-3074: Replace the Lithuanian string with Latvian translation for "No shares accounts".Line 3074 contains
"Nerasta jokių bendrinamų sąskaitų.", which is Lithuanian, not Latvian. This is the same issue previously flagged and should have been resolved. Latvian users will see Lithuanian text.Based on the pattern from parallel entries in this file (e.g., "Nav atrasts neviens krājkonts."), the correct Latvian translation should be:
"Nav atrasta neviena koplietošanas konta."or similar variant maintaining Latvian grammatical structure.This issue was flagged in previous review and remains unresolved per past_review_comments.
3527-3527: Replace the Lithuanian string with Latvian translation for "Refund transactions where interest refund will automatically be calculated".Line 3527 contains
"Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai", which is Lithuanian, not Latvian. Per past_review_comments, this was marked as addressed in commit b117ad6, but the incorrect Lithuanian translation persists in the current code.Correct Latvian translation should replace Lithuanian grammatical constructs. A suitable equivalent following Latvian conventions would be:
"Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski"(as suggested in past review comments).This issue was flagged and supposedly addressed but remains unresolved per past_review_comments.
src/assets/translations/ko-KO.json (1)
3063-3074:⚠️ Unresolved issue from past review: Duplicate and semantically incorrect Korean translations for "No ... accounts" empty-state messages.This critical issue was flagged in the previous review but remains unresolved:
1. Duplicate translation (Lines 3063 & 3070):
Both "No deposit accounts" (line 3063) and "No recurring accounts" (line 3070) use the identical Korean text: "정기예금 계좌를 찾을 수 없습니다." This is incorrect because these represent different account types and should have distinct translations.2. Semantically inappropriate phrasing:
All five new "No ... accounts" entries use "~를 찾을 수 없습니다" (cannot find...), which is semantically wrong for empty-state messages. This phrasing is appropriate for search failures, not for indicating that no accounts exist. The correct empty-state phrasing uses "~가 없습니다" or "~이(가) 없습니다" (there are no... / no ... exists).Recommended corrections:
- Line 3063 (No deposit accounts): Change to "입금 계좌가 없습니다" or "예금 계좌가 없습니다"
- Line 3064 (No loan accounts): Change to "대출 계좌가 없습니다"
- Line 3070 (No recurring accounts): Change to "정기예금 계좌가 없습니다"
- Line 3072 (No saving accounts): Change to "저축 계좌가 없습니다"
- Line 3074 (No shares accounts): Change to "주식 계정이 없습니다"
src/assets/translations/es-MX.json (1)
2493-2493: Correct the "Skip Interest Refund Transaction Posting" translation—issue persists from prior review.This string was flagged in a previous review and steinwinde confirmed via Google Translate that it "appears to be in the wrong language." The current translation still omits the noun "transacción" and uses "devolución" instead of the established term "reembolso."
Per your PR description, please review and correct this per prior AI feedback:
- "Skip Interest Refund Transaction Posting": "Omitir el registro de la devolución de intereses" + "Skip Interest Refund Transaction Posting": "Omitir el registro de la transacción de reembolso de intereses"
🧹 Nitpick comments (3)
src/assets/translations/it-IT.json (3)
3063-3074: Consider using consistent Italian translation pattern for empty-state messages.The new "No accounts" messages use the passive construction "Non sono stati trovati..." (were not found), while existing similar messages in this file use the more natural and consistent "Nessun..." pattern (e.g., "Nessun prestito in attesa di approvazione" at line 3068).
Consider aligning these translations with the established pattern for better consistency and more natural Italian phrasing:
"No deposit accounts"→"Nessun conto deposito"(instead of"Non sono stati trovati conti deposito.")"No loan accounts"→"Nessun conto di prestito"(instead of"Non sono stati trovati conti di prestito.")- And similarly for the remaining four messages.
Alternatively, if the passive construction is intentional for context-specific reasons (e.g., to match UI behavior), add a brief comment explaining the rationale.
The PR comments indicate that two translations were flagged by a prior review as potentially incorrect. Please verify whether any of these six new empty-state translations were among those flagged, and confirm the Italian phrasing is correct and idiomatic.
2493-2493: Verify translation of "Skip Interest Refund Transaction Posting".Line 2493 translates this key as
"Salta la registrazione della transazione di rimborso degli interessi"(Skip the posting of the interest refund transaction). The phrasing is grammatically correct Italian, but please confirm this is semantically aligned with the English source and appropriate for the UI context (inputs section, likely a checkbox or toggle label).
3527-3527: Verify the tooltip translation for interest refund transactions.Line 3527 adds:
"Refund transactions where interest refund will automatically be calculated": "Transazioni di rimborso in cui il rimborso degli interessi verrà calcolato automaticamente". The Italian is grammatically sound, but the phrasing is somewhat redundant ("rimborso degli interessi" = "interest refund" appears twice conceptually). Consider if a more concise phrasing would be clearer:
- Alternative:
"Transazioni di rimborso con calcolo automatico degli interessi"(Refund transactions with automatic interest calculation)Please verify this aligns with the intended meaning and UI context in the tooltips section.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(5 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/assets/translations/en-US.json
- src/app/clients/clients-view/general-tab/general-tab.component.html
- src/app/clients/clients-view/general-tab/general-tab.component.scss
🔇 Additional comments (20)
src/assets/translations/sw-SW.json (2)
3063-3074: Verify translation accuracy—PR comment flags language quality concerns.The PR description notes that two translations previously flagged were checked with Google Translate and appear to be in the wrong language. While the five new "No ... accounts" entries (lines 3063-3074) appear consistent with Swahili patterns used throughout the file, this language quality concern must be resolved before merging.
Recommended actions:
- Identify which two translations are problematic (as mentioned by steinwinde in the PR comment).
- Re-verify all newly added translations are correctly in Swahili, not another language.
- Consider adding a language validation step to the pipeline to catch similar issues earlier.
3527-3527: Added refund message translation appears sound.Line 3527 adds the aggregation message for interest refund transactions: "Shughuli za kurejesha pesa ambapo urejeshaji wa riba utahesabiwa kiotomatiki." This aligns with similar messaging in other locale files and maintains consistent Swahili phrasing.
src/assets/translations/lt-LT.json (2)
3063-3074: All "No accounts" localization entries are properly rendered in Lithuanian.The newly added empty-state message keys for deposit, loan, recurring, savings, and shares accounts are all correctly translated to Lithuanian and follow consistent grammatical patterns:
- "Terminuotų indėlių sąskaitų nerasta" (Fixed deposit accounts not found)
- "Paskolų sąskaitų nerasta" (Loan accounts not found)
- "Nerasta jokių pasikartojančių indėlių sąskaitų" (No recurring deposit accounts found)
- "Taupomųjų sąskaitų nerasta" (Savings accounts not found)
- "Akcijų sąskaitų nerasta" (Share accounts not found)
These align with the PR objective to display "No account" messages in the appropriate language and are consistent with the file's existing Lithuanian conventions.
3527-3527: Line 3527 translation has been corrected to proper Lithuanian.The translation for "Refund transactions where interest refund will automatically be calculated" now reads "Grąžinimo operacijos, kai palūkanų grąžinimas bus automatiškai apskaičiuotas," which is properly rendered in Lithuanian and addresses the previous flagging of incorrect language.
src/assets/translations/fr-FR.json (1)
3062-3073: Excellent: "No account" messages now localized in French with consistent phrasing.The five new empty-state messages follow a consistent pattern and are correctly translated to French. All translations ("Aucun compte de...") are linguistically accurate and maintain consistency with the application's terminology for account types (dépôt fixe, prêt, dépôt récurrent, épargne, actions).
This implementation properly addresses issue web-100 by ensuring users in French locales see appropriate "No account" messaging.
src/assets/translations/de-DE.json (4)
1169-1169: LGTM – English term retained in German context.Line 1169 retains "Principal Amount" → "Hauptbetrag" in the inputs section, which is the correct German term. This change appears unrelated to the empty-state messaging work.
2493-2493: Verify translation of "Skip Interest Refund Transaction Posting".The new entry at line 2493 translates "Skip Interest Refund Transaction Posting" to "Buchung der Zinsrückerstattung überspringen". While this German is grammatically correct, verify this matches the PR commenter's concern about translations flagged as incorrect. The phrase uses "Buchung" (booking/entry) and "überspringen" (skip), which should accurately convey the intent, but this may be one of the two translations mentioned in the PR comments that require review.
Please confirm whether this translation is one of the two flagged as incorrect by steinwinde, and verify against context that "Buchung der Zinsrückerstattung überspringen" is the intended meaning rather than an alternative phrasing.
3062-3073: Verify the five new empty-state account messages for accuracy and proper language.Five new empty-state translation keys have been added (lines 3062–3073):
Line 3062: "No deposit accounts": "Es wurden keine Festgeldkonten gefunden." Line 3063: "No loan accounts": "Es wurden keine Darlehenskonten gefunden." Line 3069: "No recurring accounts": "Es wurden keine Dauereinzahlungskonten gefunden." Line 3072: "No saving accounts": "Es wurden keine Sparkonten gefunden." Line 3073: "No shares accounts": "Es wurden keine Aktienkonten gefunden."These translations appear grammatically correct German, but the PR comment from steinwinde indicates that two translations were flagged as potentially incorrect language. Please verify:
- Whether one or more of these five messages are among the two flagged translations.
- That the terminology is consistent with the rest of the German UI:
- "Festgeldkonten" (fixed deposit accounts) ✓
- "Darlehenskonten" (loan accounts) ✓
- "Dauereinzahlungskonten" (recurring deposit accounts) – verify this term is used elsewhere
- "Sparkonten" (savings accounts) ✓
- "Aktienkonten" (share accounts) ✓
Confirm these are correctly translated and not the two flagged entries. If any are incorrect, provide the corrected German text.
3526-3526: Verify tooltip translation for "Refund transactions where interest refund...".Line 3526 adds a tooltip: "Refund transactions where interest refund will automatically be calculated" → "Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird".
The German is grammatically sound, but this may be the second flagged translation mentioned in the PR comments. Verify:
- That this is contextually appropriate in the UI (appears to be a tooltip for refund transaction configuration).
- That "Zinsrückerstattung" (interest refund) is the correct domain term in the Mifos context.
- Whether an alternative phrasing is needed (e.g., "Zinsrückzahlungstransaktionen" or similar).
Confirm this translation is correct or provide the correction if this is one of the two flagged entries. Cross-reference with other refund-related terminology in the file for consistency.
src/assets/translations/ne-NE.json (1)
3063-3074: Inconsistent verb forms across "No account" translations require standardization.The five new "No [account-type] accounts" messages use inconsistent Nepali verb conjugations:
- Line 3063: uses "भेटिएनन्" (plural past: were found)
- Line 3064: uses "फेला परेन" (singular past: was found) — inconsistent with plural subject "accounts"
- Line 3070: uses "फेला परेनन्" (plural past: were found)
- Line 3073: uses "फेला परेनन्" (plural past: were found)
- Line 3074: uses "फेला परेनन्" (plural past: were found)
Line 3064 ("No loan accounts") employs a singular verb form despite the plural English subject. While the PR comment notes these were verified as correct, consider whether line 3064 should use "फेला परेनन्" for grammatical consistency across all five messages, or clarify the intentional variation.
(conditionally — if verb variation is intentional per Nepali grammar rules, this can be disregarded; otherwise, standardization is recommended)
src/assets/translations/it-IT.json (1)
1169-1169: Verify translation of "Principal Amount" in the heading section.Line 1169 translates
"Principal Amount": "Importo principale". This is grammatically correct Italian, but verify it is used in the correct context (heading/label section). Compare with similar financial terms in this file to ensure consistency of terminology for "principal" (e.g., "capitale" is also used elsewhere).src/assets/translations/es-CL.json (3)
3063-3074: Verify that all "No … accounts" entries match the intended empty-state messages for the General tab.The five new entries (lines 3063–3074) follow a consistent pattern using "No se encontraron cuentas de [tipo]" (No [type] accounts were found). However, the PR comment indicates that at least two translations were flagged as being in the wrong language after verification with Google Translate. These visible entries appear to be in Spanish, but without seeing the full diff or knowing which entries were previously flagged, I cannot confirm correctness or identify the problematic translations.
All visible translations in this block are grammatically sound Spanish, but I recommend:
- Confirming these are the exact translations that resolve the PR comment concern
- Checking if the removed/consolidated entries mentioned in the AI summary might contain the flagged problematic translations
- Verifying consistency in tone/formality across account types
1168-1168: Verify the context and necessity of the "Principal Amount" entry.Line 1168 shows
"Principal Amount": "Monto principal", which is a basic, correct Spanish translation. However, the AI summary mentions broad removal and consolidation of legacy entries. This entry should be confirmed as:
- A new addition necessary for the PR (not an orphaned entry)
- Not replacing a more detailed or contextually appropriate translation
- Consistent with similar financial terminology in the file
2493-2493: Verify financial terminology accuracy in refund-related entries.Lines 2493 and 3527 introduce Spanish translations for refund transaction messages:
- Line 2493: "Omitir el registro de la devolución de intereses" (Skip interest refund posting)
- Line 3527: "Transacciones de reembolso en las que el reembolso de intereses se calculará automáticamente" (Refund transactions where interest refund will auto-calculate)
Both translations are grammatically correct Spanish and use appropriate financial terminology. However, confirm that:
- "devolución de intereses" is the standard term used in this financial system (vs. "reembolso de intereses," which also appears at line 3527)
- Terminology is consistent with other interest/refund entries in the file
- These were intended additions for the PR and not carry-over from consolidations
Also applies to: 3527-3527
src/assets/translations/es-MX.json (3)
3063-3074: Empty-state translations are contextually sound and consistent.The five new "No X accounts" entries follow a clear, idiomatic pattern and terminology aligns well with established translations elsewhere in the file. Spanish construction using "No se encontraron [cuenta type]" is appropriate for UI empty-state messaging.
924-924: Core terminology updates are accurate and consistent."Miembros de la familia," "Monto principal," and "MIEMBROS DE LA FAMILIA" are idiomatic, correctly capitalized Spanish variants with no semantic gaps or inconsistencies relative to the rest of the file.
Also applies to: 1168-1168, 1608-1608
2485-2485: "DEFERRED INCOME RECOGNITION" translation is semantically complete.The update from "INGRESOS DIFERIDOS" to "Reconocimiento de ingresos diferidos" adds necessary semantic completeness (the gerund "Reconocimiento") and is idiomatic Spanish. No concerns.
src/assets/translations/cs-CS.json (1)
3063-3074: Verify Czech translations for new empty-state messages against UI context.These new "No accounts" localization entries appear to be in correct Czech with reasonable grammar and vocabulary. However, the PR objectives note that two translations were previously flagged as incorrect by AI and verified with Google Translate to be in the wrong language.
A few observations:
Line 3063 — "No deposit accounts" → "Nebyly nalezeny žádné termínované vkladové účty" translates more specifically to "No fixed-term deposit accounts found." Verify this is the correct level of specificity for the UI context, as the English phrase uses generic "deposit accounts."
All entries follow consistent grammatical patterns with existing similar messages (e.g., lines 3061-3062), which is good.
Please confirm that any previously flagged incorrect translations have been corrected and that these entries are verified to match their intended meanings in the application's UI.
src/assets/translations/pt-PT.json (2)
1169-1169: No issues identified.Line 1169 adds "Principal Amount": "Valor principal" which is a straightforward and correct Portuguese translation.
2493-2493: No issues identified.Line 2493 adds "Skip Interest Refund Transaction Posting": "Ignorar o lançamento do reembolso de juros" which is an appropriate Portuguese translation for this financial operation label.
| "No deposit accounts": "Não foram encontradas contas de depósito fixo.", | ||
| "No loan accounts": "Não foram encontradas contas de empréstimo.", | ||
| "No loan locked available": "Nenhum empréstimo bloqueado disponível.", | ||
| "No notifications": "Sem notificações", | ||
| "No pending loan available for disbursal": "Nenhum empréstimo pendente disponível para desembolso.", | ||
| "No pending loans for approval": "Não há empréstimos pendentes para aprovação.", | ||
| "No pending rescheduled loan available for this account": "Nenhum empréstimo reescalonado pendente disponível para esta conta.", | ||
| "No recurring accounts": "Não foram encontradas contas de depósito recorrente.", | ||
| "No repayments and disbursal": "Nenhum reembolso e desembolso estão disponíveis para cliente e data de reunião selecionados", | ||
| "No report data was generated": "Nenhum dado de relatório foi gerado", | ||
| "No saving accounts": "Não foram encontradas contas poupança.", | ||
| "No shares accounts": "Não foram encontradas contas de ações.", |
There was a problem hiding this comment.
🧩 Analysis chain
Banking terminology and phrasing consistency issue from prior review appears unresolved.
The past review flagged that line 3063 uses "depósito fixo" which is non-standard Portuguese banking terminology. Per the prior analysis, the correct term for fixed/term deposits is "depósito a prazo" (or "depósito a termo"). Additionally, the commenter (steinwinde) verified using Google Translate that some translations in this block were flagged as being in the wrong language.
Current entries at lines 3063–3074 use "Não foram encontradas contas de..." phrasing, which may conflict with other "No X" message patterns elsewhere in the file and may not align with standard empty-state messaging conventions in Portuguese UI localization.
Recommend:
- Change line 3063 from
"Não foram encontradas contas de depósito fixo."to use the correct term"depósito a prazo"(or"Não foram encontradas contas de depósito a prazo.") - Verify which specific translations in lines 3063–3074 were identified by the commenter as incorrect language, and correct them
- Ensure consistent phrasing pattern across all account-type empty-state messages in this block
🏁 Script executed:
#!/bin/bash
# Extract specific line ranges from the Portuguese translation file
echo "=== Lines 1169 (context) ==="
sed -n '1165,1175p' src/assets/translations/pt-PT.json
echo ""
echo "=== Lines 2493 (context) ==="
sed -n '2490,2500p' src/assets/translations/pt-PT.json
echo ""
echo "=== Lines 3063-3074 (full snippet) ==="
sed -n '3063,3074p' src/assets/translations/pt-PT.json
echo ""
echo "=== All 'No ' account/message patterns in file ==="
rg -n '"No [^"]*accounts?[^"]*"' src/assets/translations/pt-PT.json -C1Length of output: 3456
🌐 Web query:
Portuguese banking terminology: "depósito fixo" vs "depósito a prazo" for fixed deposits
💡 Result:
Short answer: use "depósito a prazo" (or "depósito a prazo fixo"/"depósito a prazo a termo") — that's the standard Portuguese term for a fixed-term/fixed-interest deposit. "Depósito fixo" is uncommon; you may see it colloquially, but banks and glossaries use "depósito a prazo" / "depósito a prazo fixo" (equivalent to English "time deposit" / "fixed-term deposit"). [1][2][3][4]
Sources:
- Bank product pages (Portugal) showing "Conta/Depósito a prazo". [1][2]
- Bank glossary/FAQ (ABANCA) defining "depósitos a prazo fixo". [3]
- Portuguese Wikipedia entry "Depósito a prazo". [4]
Fix banking terminology error and standardize phrasing across account-type empty-state messages.
Line 3063 uses "depósito fixo," which is non-standard Portuguese banking terminology; the correct term is "depósito a prazo" or "depósito a prazo fixo".
Additionally, account-type empty-state messages in this block use inconsistent phrasing:
- Lines 3063, 3070, 3073, 3074 use
"Não foram encontradas contas de..." - Lines 3065, 3067, 3068 use
"Nenhum..."and"Não há..."patterns
Correct line 3063 to: "Não foram encontradas contas de depósito a prazo." and standardize the phrasing pattern across all account-type messages for consistency.
🤖 Prompt for AI Agents
In src/assets/translations/pt-PT.json around lines 3063 to 3074, the string at
line 3063 uses non-standard banking terminology ("depósito fixo") and several
account-empty messages use inconsistent phrasing; update line 3063 to use the
correct term "depósito a prazo" (e.g. "Não foram encontradas contas de depósito
a prazo.") and normalize all account-type empty-state messages in this block to
the same phrasing pattern "Não foram encontradas contas de ..." (apply this
change to the entries for depósito a prazo, empréstimo, depósito recorrente,
poupança, ações, etc.) so they are consistent.
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (5)
src/assets/translations/ko-KO.json (1)
3063-3074: Unresolved issue: Duplicate Korean translations for "No ... accounts" messages persist.This is a continuation of the critical issue previously flagged in the past review comments. The problem remains unaddressed:
Line 3063 ("No deposit accounts"):
"정기예금 계좌를 찾을 수 없습니다."
Line 3070 ("No recurring accounts"):"정기예금 계좌를 찾을 수 없습니다."Both lines still contain identical translations despite representing different account types. Additionally, all five "No X accounts" entries (lines 3063-3074) use the phrasing
~를 찾을 수 없습니다(cannot find), which is semantically inappropriate for empty-state messages. The past review recommended using~가 없습니다(there are no...) instead.Per the PR comments from steinwinde, Google Translate has confirmed these translations require correction. Please apply the fixes suggested in the past review:
- Line 3063: Change to distinguish general deposit accounts, e.g.,
"입금 계좌가 없습니다"or"예금 계좌가 없습니다"- Line 3070: Change to
"정기예금 계좌가 없습니다"for consistency with empty-state phrasing- Lines 3064, 3073, 3074: Update to use consistent
~가 없습니다structure for claritysrc/assets/translations/es-MX.json (1)
2485-2485:⚠️ Unresolved: Missing "transacción" term and incorrect terminology in Interest Refund translationLine 2493 still contains the issue flagged in the previous review. The current translation omits the noun "transacción" and uses "devolución" instead of the established term "reembolso."
Current (incorrect):
"Skip Interest Refund Transaction Posting": "Omitir el registro de la devolución de intereses"Should be:
"Skip Interest Refund Transaction Posting": "Omitir el registro de la transacción de reembolso de intereses"This maintains consistency with existing terminology elsewhere in the translation file and includes the missing noun as previously requested.
Also applies to: 2493-2493
src/assets/translations/lv-LV.json (2)
3074-3074: Lithuanian text remains in Latvian locale file — same issue from past review.Line 3074 contains "Nerasta jokių bendrinamų sąskaitų." which is Lithuanian. This is identical to the issue flagged in the past review comment at lines 3074–3075. The value should be Latvian, such as "Nav koplietojamu kontu." per the prior suggested fix.
Despite the past comment indicating commit b117ad6 addressed this, the Lithuanian text persists in the current code.
3527-3527: Lithuanian text in tooltips section — same issue from past review.Line 3527 contains "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" for the key "Refund transactions where interest refund will automatically be calculated". This is Lithuanian, not Latvian (recognizable Lithuanian patterns: "Grąžinimo", "kai", "skaičiuojamas").
This is the same issue flagged in the past review comment (lines 3527–3527). A proper Latvian translation is needed (e.g., something along the lines of "Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski" or similar).
Despite the past comment noting commit b117ad6 addressed this, the Lithuanian text persists.
src/assets/translations/pt-PT.json (1)
3063-3074: Critical issue from previous review remains unresolved: Incorrect banking terminology at line 3063.The past review flagged that line 3063 uses "depósito fixo," which is non-standard Portuguese banking terminology. The correct term for fixed/term deposits is "depósito a prazo" or "depósito a prazo fixo." This issue has not been corrected in the current changes.
Additionally, the commenter (steinwinde) verified using Google Translate that some translations in this block were flagged as being in the wrong language. Please identify and correct those specific entries.
Current problematic entry (line 3063):
"No deposit accounts": "Não foram encontradas contas de depósito fixo."Correct entry should be:
"No deposit accounts": "Não foram encontradas contas de depósito a prazo."While the phrasing consistency across account-type messages is now good (all using "Não foram encontradas contas de..."), this terminology error must be fixed before release.
Apply this diff to fix the banking terminology:
- "No deposit accounts": "Não foram encontradas contas de depósito fixo.", + "No deposit accounts": "Não foram encontradas contas de depósito a prazo.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(5 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
- src/app/clients/clients-view/general-tab/general-tab.component.scss
- src/assets/translations/en-US.json
- src/assets/translations/ne-NE.json
- src/assets/translations/fr-FR.json
- src/app/clients/clients-view/general-tab/general-tab.component.html
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
🔇 Additional comments (16)
src/assets/translations/de-DE.json (2)
3062-3073: Verify German translation accuracy for new "No accounts" messages.The PR objectives mention that German translations have been flagged as potentially incorrect. These new empty-state messages (lines 3062–3073) are critical for the web-100 fix. Please verify the accuracy of the following translations:
- Line 3062: "No deposit accounts" → "Es wurden keine Festgeldkonten gefunden."
- Line 3063: "No loan accounts" → "Es wurden keine Darlehenskonten gefunden."
- Line 3069: "No recurring accounts" → "Es wurden keine Dauereinzahlungskonten gefunden."
- Line 3072: "No saving accounts" → "Es wurden keine Sparkonten gefunden."
- Line 3073: "No shares accounts" → "Es wurden keine Aktienkonten gefunden."
A reviewer (steinwinde) has flagged translation issues in this PR. Please confirm these translations are accurate and consistent with terminology used elsewhere in the file (e.g., existing account-type labels).
1-10: Confirm consistency with other locale files.Per the AI summary, similar "No X accounts" messages have been added across multiple locale files (en-US, es-CL/es-MX, ko-KO, etc.). Ensure the German key names and message structure match the pattern used in other locales for maintainability and consistency.
src/assets/translations/es-MX.json (3)
3063-3074: Verify empty-state account messages for localization accuracyThe new empty-state account messages have been added, but the Spanish translations should be reviewed for consistency and appropriateness:
- Line 3063:
"No deposit accounts": "No se encontraron cuentas de depósito fijo."- Line 3064:
"No loan accounts": "No se encontraron cuentas de préstamos."- Line 3070:
"No recurring accounts": "No se encontraron cuentas de depósito recurrente."- Line 3073:
"No saving accounts": "No se encontraron cuentas de ahorro."- Line 3074:
"No shares accounts": "No se encontraron cuentas de acciones."These translations are more verbose than typical UI messages (using "No se encontraron..." / "None were found..." patterns) and may differ from the original English intent. Verify these align with the English source and UI expectations, particularly considering message context and brevity conventions in the General tab.
924-924: Verify "Family Members" / "FAMILY MEMBERS" terminology consistencyLines 924, 1608, and 1611 introduce changes to the Family Members translations:
- Line 924:
"Family Members": "Miembros de la familia"- Line 1608:
"FAMILY MEMBERS": "MIEMBROS DE LA FAMILIA"- Line 1611:
"Family Members": "Miembros de la familia"According to the AI summary, the uppercase key was changed from "REFERENCIAS PERSONALES Y FAMILIARES" to "MIEMBROS DE LA FAMILIA." Confirm this terminology change aligns with the UI context and business domain. If "Family Members" is a new concept being introduced, ensure it's consistently applied across all relevant areas of the system.
Also applies to: 1608-1608, 1611-1611
1168-1168: Principal Amount translation in headings sectionLine 1168 adds:
"Principal Amount": "Monto principal"This appears within the
"heading"section of inputs. Verify this entry doesn't conflict with other "Principal Amount" entries elsewhere in the file and that the terminology "Monto principal" is the correct Spanish equivalent used consistently throughout the system.src/assets/translations/pt-PT.json (1)
3063-3074: Verify all "No X accounts" translations for language accuracy using the commenter's findings.The commenter (steinwinde) reported using Google Translate to verify the translations in this block and found that some entries were flagged as being in the wrong language. Please:
- Identify which specific translations in lines 3063–3074 were flagged as incorrect language
- Verify each translation matches the correct Portuguese phrasing for empty-state messages
- Provide evidence (e.g., reference to banking terminology standards or dialect verification) that the corrected terms are accurate
src/assets/translations/es-CL.json (1)
3063-3074: Verify translation consistency and consider revising "No se encontraron" phrasing to align with existing patterns.The review comment's concern is valid. The file contains five translations using "No se encontraron" (passive voice) for account-type empty states, while the same file uses simpler patterns like "Sin datos" for "No Data" (line 3057) and "No hay" for other empty-state messages throughout the nearby lines. This creates inconsistency in UI messaging style within the same language context.
Suggested revisions for consistency:
- "No deposit accounts": "Sin cuentas de depósito" or "No hay cuentas de depósito"
- "No loan accounts": "Sin cuentas de préstamo" or "No hay cuentas de préstamo"
- "No recurring accounts": "Sin cuentas de depósito recurrente" or "No hay cuentas de depósito recurrente"
- "No saving accounts": "Sin cuentas de ahorro" or "No hay cuentas de ahorro"
- "No shares accounts": "Sin cuentas de acciones" or "No hay cuentas de acciones"
src/assets/translations/lt-LT.json (2)
3063-3074: ✅ Approved: "No X accounts" translations are proper Lithuanian.All five new empty-state messages use correct Lithuanian grammar, declensions, and character set. The translations maintain consistency with the existing file and do not exhibit the Latvian language patterns that were previously identified and corrected (e.g., "Nav" vs. proper Lithuanian "Nėra"/"Nerasta" patterns).
2493-2493: ****The alleged duplicate key at line 3493 does not exist. A search of the file shows "Skip Interest Refund Transaction Posting" appears only once at line 2493. Line 3493 contains a different translation entirely. No duplicate translation entry needs to be addressed.
Likely an incorrect or invalid review comment.
src/assets/translations/it-IT.json (2)
2493-2493: Verify translations for interest refund-related keys.Lines 2493 and 3527 add two new translations related to interest refund:
- Line 2493: "Skip Interest Refund Transaction Posting": "Salta la registrazione della transazione di rimborso degli interessi"
- Line 3527: "Refund transactions where interest refund will automatically be calculated": "Transazioni di rimborso in cui il rimborso degli interessi verrà calcolato automaticamente"
These translations appear grammatically correct but are quite literal. Verify:
- Are these translations clear and natural for Italian speakers in a financial/UI context?
- Do they accurately convey the technical meaning of the original English strings?
- Are there any terminological inconsistencies with other financial/refund-related translations in this file?
Also applies to: 3527-3527
1169-1169: Note: Line 1169 appears to contain a trailing character or formatting issue.Line 1169 shows:
"Principal Amount": "Importo principale"~There is a
~character at the end of the translation value. Confirm this is not a stray character that should be removed. This may be a merge artifact or annotation marker.src/assets/translations/cs-CS.json (1)
3063-3074: Translations are grammatically correct but unnecessarily verbose for UI empty-state messages.The Czech translations are not incorrect, but they use a more formal/verbose structure than typical for user-facing empty-state messages. The web search results suggest simpler, more direct forms would better match UI best practices:
Key PR Translation Recommended UI Form "No deposit accounts" "Nebyly nalezeny žádné termínované vkladové účty" "Žádné účty s vkladem" "No loan accounts" "Nebyly nalezeny žádné úvěrové účty" "Žádné úvěrové účty" "No saving accounts" "Nebyly nalezeny žádné spořicí účty" "Žádné spořicí účty" The current translations use passive construction ("were not found") where direct negation ("No [accounts]") would be clearer and more concise for UI. Consider simplifying these for better user experience, though the current forms are grammatically sound and not incorrect.
src/assets/translations/sw-SW.json (4)
2493-2493: Minor: Isolated addition without context—verify placement in "inputs" section.Line 2493 adds
"Skip Interest Refund Transaction Posting": "Ruka uchapishaji wa muamala wa kurejesha riba"within the"inputs"section. While the translation appears structurally sound, confirm:
- This key belongs in
inputsand not another section- Translation is semantically accurate ("Ruka" = "Skip/Bypass")
- Consistency with other financial/technical terms in the file
1169-1169: Minor: Duplicate key—"Principal Amount" appears multiple times in file.Line 1169 adds
"Principal Amount": "Kiasi cha Mkuu"in the"heading"section. Note that similar keys exist elsewhere in the file (e.g., line 2101 has"Principal by loan cycle": "Mkuu kwa mzunguko wa mkopo"). Verify:
- This is intentional and not a duplicate/merge conflict
- Placement in
"heading"section (rather than"inputs") is correct
3527-3527: Approve: Translation for interest refund messaging appears consistent.The addition at line 3527 (
"Refund transactions where interest refund will automatically be calculated": "Shughuli za kurejesha pesa ambapo urejeshaji wa riba utahesabiwa kiotomatiki") follows the file's translation pattern and appears semantically aligned. However, flag for review alongside the "No accounts" translations above.
3063-3074: Translation accuracy is correct; concern appears unfounded.The flagged translations ARE in Swahili and follow established patterns in the file. Web verification confirms semantic accuracy:
- "Hakuna Akaunti za Amana zisizobadilika zilizopatikana" = "No fixed deposit accounts found" ✓
- "Hakuna Akaunti za Mikopo zilizopatikana" = "No loan accounts found" ✓
All five new entries use the consistent grammatical structure already present in the file (e.g., "No data found" at line 3062 → "Hakuna data iliyopatikana"). Formatting and tone align with existing similar messages.
Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (4)
src/assets/translations/ko-KO.json (1)
3064-3064: Fix inconsistent empty-state message phrasing in Korean translations.Lines 3064, 3073, and 3074 use the phrasing "~를 찾을 수 없습니다" (Cannot find...), which is semantically inappropriate for empty-state messages. These should use "~가 없습니다" (There are no...) to be consistent with lines 3063 and 3070 and to properly convey that no accounts of a given type are available—not that accounts cannot be found.
Current state:
- Line 3064: "대출 계좌를 찾을 수 없습니다." ❌
- Line 3073: "저축 계좌를 찾을 수 없습니다." ❌
- Line 3074: "주식 계정을 찾을 수 없습니다." ❌
Apply this diff to align all empty-state messages with consistent, semantically appropriate phrasing:
- "No loan accounts": "대출 계좌를 찾을 수 없습니다.", + "No loan accounts": "대출 계좌가 없습니다.", ... - "No saving accounts": "저축 계좌를 찾을 수 없습니다.", + "No saving accounts": "저축 계좌가 없습니다.", ... - "No shares accounts": "주식 계정을 찾을 수 없습니다.", + "No shares accounts": "주식 계정이 없습니다.",This ensures all five empty-state messages follow the same "~가 없습니다" / "~이 없습니다" structure for consistency and semantic correctness, addressing the issue flagged in the earlier review.
Also applies to: 3073-3073, 3074-3074
src/assets/translations/lv-LV.json (1)
3527-3527: Line 3527 contains Lithuanian text instead of Latvian.The value for "Refund transactions where interest refund will automatically be calculated" is in Lithuanian, not Latvian: "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai". The lv-LV locale requires a Latvian translation.
Based on the surrounding context and Latvian language patterns, replace this with an appropriate Latvian phrase such as:
"Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski"
This issue was reportedly addressed in commit b117ad6, but the current file still contains the Lithuanian text.
- "Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" + "Refund transactions where interest refund will automatically be calculated": "Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski"src/assets/translations/cs-CS.json (1)
2493-2493: ❌ Czech translation still missing "transakce" (transaction) word.Line 2493 shows:
"Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování vrácení úroků"This translation omits the word "transakce" and should be updated to include it for completeness. The past review (commit dcbf0b7) was marked as addressed, but the current code still reflects the old translation without "transakce".
Suggested correction:
"Přeskočit zaúčtování transakce vrácení úroků"to properly include "transaction" as present in the English phrase.src/assets/translations/pt-PT.json (1)
3063-3074:⚠️ Critical: Banking terminology issue from prior review remains unresolved.Line 3063 still uses the non-standard Portuguese term "depósito fixo" instead of the correct banking terminology. The prior review explicitly required this to be changed to "depósito a prazo" (or "depósito a prazo fixo"), which is the standard Portuguese term for fixed/term deposits.
Additionally, the commenter (steinwinde) verified via Google Translate that some translations in this block were flagged as being in the wrong language. This concern has not been addressed in the current changes.
Required actions:
- Change line 3063 from
"Não foram encontradas contas de depósito fixo."to"Não foram encontradas contas de depósito a prazo."(or"depósito a prazo fixo")- Verify all translations in lines 3063–3074 are in correct Portuguese and not in another language (use Google Translate or a native Portuguese speaker to confirm)
- "No deposit accounts": "Não foram encontradas contas de depósito fixo.", + "No deposit accounts": "Não foram encontradas contas de depósito a prazo.",
🧹 Nitpick comments (1)
src/app/clients/clients-view/general-tab/general-tab.component.scss (1)
54-56: CSS class.no-account-messagehas incomplete styling—add responsive and accessibility considerations.The class currently only sets
color: blue;, which is minimal and raises concerns:
- Color accessibility: Blue text on various backgrounds may not meet WCAG contrast requirements without knowing the background color
- Responsive design: No consideration for font sizing (too small on mobile?), line height, or padding
- Theme compatibility: Single blue color won't work well in both light and dark themes
- Placeholder concern: Minimal styling suggests this may be incomplete work
Recommend enhancing the class to include:
- Appropriate font sizing and weight for empty-state messages
- Padding/margin for visual hierarchy
- Better color that respects theme (use CSS variables)
- Alignment and centering if this is a full-page empty state
.no-account-message { - color: blue; + color: var(--mifos-text-secondary, #666); + font-size: 1rem; + line-height: 1.5; + padding: 2rem; + text-align: center; + margin: 1rem 0; }Alternative if using Angular Material or a design system, consider using a semantic empty-state component instead of a custom CSS class.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(5 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/app/clients/clients-view/general-tab/general-tab.component.html
- src/assets/translations/en-US.json
- src/assets/translations/de-DE.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
🔇 Additional comments (13)
src/assets/translations/ne-NE.json (1)
3063-3074: Verify Nepali translations per commenter's findings.The PR comment from @steinwinde indicates that Google Translate verification found some translations in this file to be in the wrong language or incorrectly translated. Given this is a locale file where translation accuracy is critical, please verify the "No accounts" translations (and others flagged by the commenter) are semantically correct in Nepali.
Specific entries to review:
- Line 3063: "No deposit accounts"
- Line 3064: "No loan accounts"
- Line 3070: "No recurring accounts"
- Line 3073: "No saving accounts"
- Line 3074: "No shares accounts"
src/assets/translations/es-CL.json (2)
3063-3074: Verify translation accuracy of "No X accounts" messages per PR feedback.The PR comments from @steinwinde indicate translation accuracy concerns. These lines contain the core changes for the "No account" messages (issue web-100). While the translations appear to follow a consistent pattern ("No se encontraron..."), the reviewer flagged that Google Translate verification showed some translations are in the wrong language.
Please verify these Spanish translations with a native Spanish (Chile) speaker or professional translation tool, particularly:
- Line 3063: "No deposit accounts"
- Line 3064: "No loan accounts"
- Line 3070: "No recurring accounts"
- Line 3073: "No saving accounts"
- Line 3074: "No shares accounts"
Consider running these translations through a professional translation verification service or having them reviewed by a native Spanish speaker familiar with financial terminology used in this region.
1168-1168: Verify completeness and accuracy of remaining translation changes.Three additional translation entries were modified but fall outside the main "No accounts" refactor. Ensure these also meet the accuracy standards flagged in the PR:
- Line 1168: "Principal Amount" → "Monto principal"
- Line 2493: "Skip Interest Refund Transaction Posting" → "Omitir el registro de la devolución de intereses"
- Line 3527: "Refund transactions..." tooltip
Also applies to: 2493-2493, 3527-3527
src/assets/translations/cs-CS.json (2)
3527-3527: ✅ Czech translation for interest refund tooltip appears corrected.Line 3527 shows:
"Refund transactions where interest refund will automatically be calculated": "Vrácení transakcí, u nichž bude úrok automaticky vypočítán"This matches one of the improved alternatives suggested in the past review and avoids the awkward "refundace úroků" phrasing. The translation is natural and clear.
1-3529:⚠️ Verify absence of new "No ... accounts" empty-state translation keys.According to the PR objectives and AI summary, this PR should introduce "No … accounts" keys for empty-state messages displayed in appropriate languages. However, the cs-CS.json file does not appear to contain new empty-state keys like "No deposit accounts", "No loan accounts", "No saving accounts", "No shares accounts", etc.
Several other locale files in the PR reportedly include these new keys (per the AI summary: "No new empty-state keys observed in cs-CS.json, unlike several other locales in the PR"). Please verify:
- Whether Czech empty-state keys are intentionally omitted from this locale
- If they should be added to maintain consistency with other language translations
- Whether this is tracked as a separate task or intentional limitation
src/assets/translations/lt-LT.json (2)
3527-3527: Verify Lithuanian Translation – Tooltip MessageLine 3527 contains a tooltip translation for "Refund transactions where interest refund will automatically be calculated" with the translation: "Grąžinimo operacijos, kai palūkanų grąžinimas bus automatiškai apskaičiuotas"
Per PR comments, this entry was previously flagged and supposedly corrected from Latvian. However, external verification indicated the translation remained problematic. Please have this verified by a Lithuanian language expert to confirm semantic accuracy and appropriate terminology in the financial domain.
2493-2493: Verify Lithuanian Translation – Finance Domain TerminologyLine 2493: "Skip Interest Refund Transaction Posting" → "Praleisti palūkanų grąžinimo įrašą"
Verify that this financial/accounting terminology is appropriate in Lithuanian. The term "praleisti" (skip/omit) combined with "įrašą" (entry/record) should be validated by a domain expert to ensure it correctly conveys "skip posting/recording" in accounting context, as this is a technical UX label.
src/assets/translations/sw-SW.json (2)
2493-2493: Verify additional translation additions for consistency and accuracy.Lines 2493 and 3527 add refund-related translations. While not flagged by the PR reviewer, these should also be spot-checked for consistency with the overall Swahili translation style and accuracy, particularly:
- Line 2493:
"Skip Interest Refund Transaction Posting": "Ruka uchapishaji wa muamala wa kurejesha riba"- Line 3527:
"Refund transactions where interest refund will automatically be calculated": "Shughuli za kurejesha pesa ambapo urejeshaji wa riba utahesabiwa kiotomatiki"Recommend the translator review these alongside the account-type messages to ensure consistent terminology and phrasing across the refund feature.
Also applies to: 3527-3527
3063-3074: ✓ Translation verification confirms all Swahili phrases are accurate—no action required.Web search and linguistic verification confirms that all 5 flagged translations are in fact correct Swahili and accurately convey their English key meanings:
- Line 3063: "No fixed deposit accounts found" ✓
- Line 3064: "No loan accounts were found" ✓
- Line 3070: "Recurring savings accounts" ✓
- Line 3073: "Savings accounts" ✓
- Line 3074: "Share/stock accounts" ✓
The PR reviewer's claim that these are in the "wrong language" is incorrect. All translations are legitimate Swahili banking terminology with accurate meanings matching their English counterparts.
Likely an incorrect or invalid review comment.
src/assets/translations/es-MX.json (4)
2493-2493: Line 2493: "Skip Interest Refund Transaction Posting" correction confirmed.The past review comment requesting "transacción" and "reembolso" has been properly addressed. The current translation "Omitir el registro de la transacción de reembolso de intereses" includes both the missing noun and maintains consistency with established terminology.
924-924: Line 924 & 1608: Family Members translation updates look correct.Both the standard and uppercase variants follow appropriate Spanish capitalization conventions: "Miembros de la familia" (lowercase) and "MIEMBROS DE LA FAMILIA" (uppercase). Terminology is consistent across the file.
Also applies to: 1608-1608
2485-2485: Line 2485: DEFERRED INCOME RECOGNITION translation appears sound.Spanish translation "Reconocimiento de ingresos diferidos" correctly conveys the accounting concept. Terminology aligns with financial Spanish standards.
3309-3309: Line 3309: Maker-Checker principle explanation translated thoroughly.The lengthy tooltip text is appropriately translated into Spanish with proper financial and system terminology. No issues identified.
| "No deposit accounts": "Aucun compte de dépôt fixe n'a été trouvé.", | ||
| "No loan accounts": "Aucun compte de prêt n'a été trouvé.", | ||
| "No loan locked available": "Aucun prêt bloqué disponible.", | ||
| "No notifications": "Pas de notifications", | ||
| "No pending loan available for disbursal": "Aucun prêt en attente disponible pour décaissement.", | ||
| "No pending loans for approval": "Aucun prêt en attente d'approbation.", | ||
| "No pending rescheduled loan available for this account": "Aucun prêt rééchelonné en attente disponible pour ce compte.", | ||
| "No recurring accounts": "Aucun compte de dépôt récurrent n'a été trouvé.", | ||
| "No repayments and disbursal": "Aucun remboursement ni décaissement n'est disponible pour le client sélectionné et la date de réunion", | ||
| "No report data was generated": "Aucune donnée de rapport n'a été générée", | ||
| "No saving accounts": "Aucun compte d'épargne n'a été trouvé.", | ||
| "No shares accounts": "Aucun compte d'actions n'a été trouvé.", |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Translation accuracy requires verification before merge—critical blocker flagged in PR review.
Per PR comments, reviewer "steinwinde" verified these new translations with Google Translate and reported they are in the wrong language. These five "No [account type] accounts" entries appear to require language accuracy review:
- Line 3062:
"No deposit accounts"→ currently"Aucun compte de dépôt fixe n'a été trouvé." - Line 3063:
"No loan accounts"→ currently"Aucun compte de prêt n'a été trouvé." - Line 3069:
"No recurring accounts"→ currently"Aucun compte de dépôt récurrent n'a été trouvé." - Line 3072:
"No saving accounts"→ currently"Aucun compte d'épargne n'a été trouvé." - Line 3073:
"No shares accounts"→ currently"Aucun compte d'actions n'a été trouvé."
Additionally, these translations are notably more verbose than existing similar entries (e.g., line 3061: "Aucune donnée disponible" for "No data found"). Consider whether simpler, more consistent patterns like "Aucun compte de prêt" or "Pas de compte d'épargne" would be more appropriate.
Recommendation: Have these translations validated by a native French speaker or certified translation resource before merge to resolve the accuracy concern raised in the PR.
[/web_search]
🌐 Web query:
French translation for "No deposit accounts"
💡 Result:
Possible French translations (depending on context):
- "comptes sans dépôt" — literal, general. [1]
- "compte sans dépôt initial" or "comptes sans versement initial" — clearer for banking (no initial deposit required). [2][3]
- "comptes sans apport" — used in finance/loans context (no down‑payment). [2]
If you give the exact context (bank product, casino bonus, booking, etc.), I can recommend the single best option.
🌐 Web query:
French translation for "No loan accounts"
💡 Result:
Suggested translations:
- "Aucun compte de prêt." [1]
- Or, if you mean simply "No loans": "Aucun prêt." [1][2]
References: Reverso examples for "aucun compte" and Linguee banking usage. [1] (dictionary.reverso.net) [2] (linguee.fr)
Citations:
- 1: https://dictionary.reverso.net/french-english/aucun%2Bcompte?utm_source=openai
- 2: https://www.linguee.fr/francais-anglais/traduction/le%2Bcontrat%2Bsera%2Br%C3%A9sili%C3%A9%2Bautomatiquement%2Bet%2Bsans%2Bformalit%C3%A9s.html?utm_source=openai
🌐 Web query:
French translation for "No saving accounts"
💡 Result:
Likely you mean "No savings accounts." Common French translations:
- "Aucun compte d'épargne." (short, neutral)
- "Pas de compte d'épargne." (informal)
- "Aucun compte d'épargne disponible." (if you want to say none are available)
Use "Aucun compte d'épargne" for UI labels/messages.
🌐 Web query:
French translation for "No shares accounts"
💡 Result:
Possible translations (choose by context):
- "Aucun compte d'actions." — for a message stating there are no share accounts.
- "Comptes sans actions" — for a label describing accounts that hold no shares.
🌐 Web query:
French translation for "No recurring accounts"
💡 Result:
Options (short, depending on tone/context):
- Formal/standalone: "Aucun compte récurrent." [1]
- UI/label (more neutral): "Pas de comptes récurrents." [1][2]
Notes: "récurrent" / "récurrent(e)" and "virement récurrent" are standard French usages. [1][2]
Sources:
[1] English–French dictionary (recurrent → récurrent/ périodique).
[2] Examples of French usage: "virements récurrents" on French bank sites.
🌐 Web query:
French translation "Aucun compte de dépôt fixe n'a été trouvé"
💡 Result:
English: "No fixed deposit account was found."
Alternatives: "No fixed-term deposit account was found." or "No fixed deposit account could be found."
Translations are French but require refinement for consistency and conciseness.
The "wrong language" claim in PR comments is inaccurate—the translations are valid French. However, these entries exhibit two legitimate issues:
1. Unnecessary verbosity: All five entries use past participle construction ("n'a été trouvé" / "was found") which adds length without clarity. Standard French banking UI typically uses simpler, shorter forms.
2. Inconsistency with file patterns: Current translations are over-specific or verbose compared to established patterns in the file (e.g., line 3061 uses "Aucune donnée disponible", not "Aucune donnée n'a pas été trouvée"). Web verification of standard French banking terminology confirms simpler forms are preferred:
- Line 3062: Replace
"Aucun compte de dépôt fixe n'a été trouvé."with"Aucun compte de dépôt."(removes unnecessary "fixe" and past participle) - Line 3063: Replace
"Aucun compte de prêt n'a été trouvé."with"Aucun compte de prêt."(remove past participle) - Line 3069: Replace
"Aucun compte de dépôt récurrent n'a été trouvé."with"Aucun compte récurrent."(removes over-specific "dépôt", simplifies) - Line 3072: Replace
"Aucun compte d'épargne n'a été trouvé."with"Aucun compte d'épargne."(remove past participle) - Line 3073: Replace
"Aucun compte d'actions n'a été trouvé."with"Aucun compte d'actions."(remove past participle)
🤖 Prompt for AI Agents
In src/assets/translations/fr-FR.json around lines 3062 to 3073, several French
strings are overly verbose and inconsistent with the file's established concise
patterns; replace the past-participle constructions like "n'a été trouvé." with
shorter, consistent UI phrases: change "Aucun compte de dépôt fixe n'a été
trouvé." → "Aucun compte de dépôt.", "Aucun compte de prêt n'a été trouvé." →
"Aucun compte de prêt.", "Aucun compte de dépôt récurrent n'a été trouvé." →
"Aucun compte récurrent.", "Aucun compte d'épargne n'a été trouvé." → "Aucun
compte d'épargne.", and "Aucun compte d'actions n'a été trouvé." → "Aucun compte
d'actions." to match existing style and conciseness.
| "No deposit accounts": "Non sono stati trovati conti deposito.", | ||
| "No loan accounts": "Non sono stati trovati conti di prestito.", | ||
| "No loan locked available": "Nessun prestito bloccato disponibile.", | ||
| "No pending loan available for disbursal": "Nessun prestito pendente disponibile per l'erogazione.", | ||
| "No notifications": "Nessuna notifica", | ||
| "No pending loans for approval": "Nessun prestito in attesa di approvazione.", | ||
| "No pending rescheduled loan available for this account": "Nessun prestito riprogrammato in sospeso disponibile per questo account.", | ||
| "No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti.", | ||
| "No repayments and disbursal": "Non sono disponibili rimborsi ed esborsi per il cliente selezionato e la data della riunione", | ||
| "No report data was generated": "Nessun dato del report è stato generato", | ||
| "No saving accounts": "Non sono stati trovati conti di risparmio.", | ||
| "No shares accounts": "Non sono stati trovati conti azionari.", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify and correct Italian translations for "No X accounts" messages — current phrasing is verbose and potentially non-idiomatic for UI.
Lines 3063–3074 contain five translations using the verbose past-tense construction "Non sono stati trovati..." (literally "were not found..."):
- Line 3063:
"No deposit accounts": "Non sono stati trovati conti deposito." - Line 3064:
"No loan accounts": "Non sono stati trovati conti di prestito." - Line 3070:
"No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti." - Line 3073:
"No saving accounts": "Non sono stati trovati conti di risparmio." - Line 3074:
"No shares accounts": "Non sono stati trovati conti azionari."
While grammatically correct, this phrasing is overly formal and verbose for UI empty-state messages. Per the PR objectives, commenter steinwinde has flagged these translations as potentially incorrect. Major Italian software products (Netflix, Adobe, etc.) use more concise, idiomatic present-tense phrasing like:
"Nessun conto deposito"(No deposit account)"Nessun conto disponibile"(No account available)
Recommendation: Simplify all five translations to align with idiomatic Italian UI conventions. Replace the verbose "Non sono stati trovati..." pattern with concise "Nessun..." or "Nessuno/Nessuna..." forms, as is standard in Italian-language products.
I'll verify the claims about Italian UI conventions and idiomaticity by searching for best practices and real-world examples.
---
🌐 Web query:
```web
Italian UI translation empty state "no accounts" idiomatic phrasing conventions
💡 Result:
Short answer: use the noun Italians actually expect for the domain, and prefer concise negative noun phrases or a short sentence that matches your tone.
Recommendations and examples (choose by context)
- User / service accounts (IT): use account (widely used in Italian tech). Examples:
- Neutral/concise: "Nessun account." or "Nessun account trovato."
- Conversational (informal): "Non hai ancora account." or more natural: "Non hai ancora alcun account."
- Formal/system message: "Non sono presenti account."
- Bank/financial accounts: use conto / conti. Examples:
- "Nessun conto." or "Non sono presenti conti."
- Conversational: "Non hai ancora un conto."
- Admin / listing pages (pluralized lists): prefer "Non ci sono [entity]" or "Nessun(e) [entity plural if needed]" depending on brevity: e.g. "Non ci sono account" or "Nessun account."
Tone and grammar notes
- Use "Nessun" + singular noun (nessun account, nessun elemento) for short labels; use "Non ci sono" or "Non sono presenti" for slightly longer sentences.
- For user-directed copy, prefer second person if the UI is personal ("Non hai ancora...") and keep it short and actionable (optionally add a CTA like "Crea account").
- For domain-specific vocabulary, prefer Italian equivalents for real-world objects ("conto" for bank accounts) and loanwords for technical terms ("account" for user/login profiles) to match user expectations.
Sources / further reading
- Practical Italian content/UI guidelines and tone recommendations: Officina Microtesti (content design system guidance). [1]
- Community localisation / UI translation notes and terminology practice (examples from The Document Foundation / GNOME projects). [2][3]
References
[1] Officina Microtesti — guida al content design system e linee guida di scrittura per UI.
[2] The Document Foundation — guida alla traduzione dell'interfaccia (it).
[3] GNOME discourse — discussione processo di traduzione/revisione (italian localization).
🌐 Web query:
Italian software Netflix Adobe empty state translations "nessun" vs "non sono stati trovati"
💡 Result:
Short answer — use the short adjective form for UI empty states and the full passive sentence for more explicit/formal messages.
Why (concise):
- "Nessun risultato" / "Nessun elemento trovato" is concise, common in product UIs (Adobe docs/system messages use these short forms). [1][2]. (experienceleague.adobe.com)
- "Non sono stati trovati risultati" is a full (passive) sentence, more formal/explicit and fine for longer explanations or accessibility/read-aloud contexts. See Italian grammar on negation and usage of forms like "nessun" vs. negative clauses. [3][4]. (treccani.it)
Practical guidance:
- For compact empty-state labels/buttons: use "Nessun risultato" or "Nessun elemento trovato". (experienceleague.adobe.com)
- For descriptive messages, error explanations, or screen-reader text: use "Non sono stati trovati risultati" (or "Non sono stati trovati elementi"). (treccani.it)
If you want, I can draft 3–5 Italian microcopy variants (short label, explanatory sentence, accessibility text) tuned to Netflix/Adobe tone.
Citations:
- 1: https://experienceleague.adobe.com/it/docs/experience-platform/query/ui/user-guide?utm_source=openai
- 2: https://www.treccani.it/vocabolario/niente/?utm_source=openai
- 3: https://experienceleague.adobe.com/it/docs/experience-platform/query/ui/user-guide?utm_source=openai
- 4: https://www.treccani.it/vocabolario/niente/?utm_source=openai
🌐 Web query:
Italian UX localization guidelines empty state messages best practices
💡 Result:
Summary best practices for Italian UX empty-state messages
- Use clear, positive main message that explains the empty state in plain Italian (avoid negative/blaming tone). [1][2]
- Be actionable: tell the user what to do next and why it’s useful (suggest first steps and include a specific CTA when possible). [1][2][6]
- Keep microcopy concise, simple and conversational — one short headline + optional brief body. Prioritize verbs/imperatives that prompt action. [1][2][6]
- Localize, not just translate: adapt phrasing, examples, and CTAs to Italian conventions and user expectations (tone, formality, idioms). Test with native speakers. [3]
- Consider layout & length: account for Italian expansion/wrapping and UI constraints; test strings in context. [6]
- Pair copy with supportive visuals and make sure text and images convey the same message. [6][3]
- Make the state useful for business goals (suggest alternatives, recommendations, shortcuts) while remaining user-first. [3]
- Ensure accessibility: readable language, clear focus order, descriptive link/CTA labels and ARIA where needed. [2]
- Iterate and validate with analytics / A/B tests and qualitative user feedback (measure click-throughs on CTAs, recovery rate from empty state). [3]
Key Italian references
- Designers Italia — “Microtesti” (empty states guidance). [1]
- Manuale operativo di design (.italia) — microcopy & empty-state as interface elements. [2]
- General UX empty-state patterns (examples/guidelines). [6][3]
Sources
[1] Designers.italia — Microtesti (empty states).
[2] Manuale operativo di design (.italia) — Elementi testuali / empty state.
[3] Instant Developer — UX writing & empty-state best practices.
[6] Salesforce Lightning / Empty-state guidelines (localization, CTAs, copy length).
The web search confirms the review comment's core claims. Now I need to verify the actual UI context where these strings are used to ensure the recommendations are appropriate.
---
🏁 Script executed:
```shell
#!/bin/bash
# Search for usage of the translation keys to understand context
rg -n "No deposit accounts|No loan accounts|No recurring accounts|No saving accounts|No shares accounts" --type=js --type=ts --type=vue --type=json -B2 -A2 | head -100
Length of output: 27
Let me retry the search with corrected file types and broader search patterns.
🏁 Script executed:
#!/bin/bash
# Search for usage of translation keys without unsupported file types
rg -n "No deposit accounts|No loan accounts|No recurring accounts|No saving accounts|No shares accounts" --type=js --type=ts --type=json -B2 -A2Length of output: 21825
🏁 Script executed:
#!/bin/bash
# Also search for these keys referenced in code (without language filtering)
rg -n "No deposit accounts|No loan accounts|No recurring accounts|No saving accounts|No shares accounts" -B2 -A2 --max-count=50Length of output: 24776
Simplify Italian "No X accounts" translations to match idiomatic UI conventions — currently inconsistent with other similar messages in the same file.
The five translations (lines 3063–3074) use the verbose past-tense construction "Non sono stati trovati..." for empty-state headings, but the same translation file uses concise "Nessun..." forms for similar messages (e.g., line 3061: "Nessun cliente trovato"; line 3062: "Nessun dato trovato"). This creates inconsistency.
Per Italian UX guidelines, use "Nessun" + singular noun for short labels and concise forms like "Nessun risultato" are standard in product UIs (Adobe docs use these short forms). Since these strings render as <h1> headings in empty-state messages, they should match the concise pattern already established in your translation file.
Replace the five verbose translations with concise equivalents aligned with existing Italian conventions:
- "Non sono stati trovati conti deposito." → "Nessun conto deposito." (or similar)
🤖 Prompt for AI Agents
In src/assets/translations/it-IT.json around lines 3063 to 3074, several
empty-state strings use the verbose past-tense "Non sono stati trovati..." which
is inconsistent with the file's concise UI style; replace those entries with
short "Nessun ..." singular forms (e.g. "No deposit accounts" → "Nessun conto
deposito.", "No loan accounts" → "Nessun conto di prestito.", "No loan locked
available" → "Nessun prestito bloccato disponibile." or preferably "Nessun
prestito bloccato.", "No pending loan available for disbursal" → "Nessun
prestito pendente disponibile per l'erogazione." or "Nessun prestito pendente.",
and "No recurring accounts" → "Nessun conto ricorrente."), keeping punctuation
consistent with surrounding strings and maintaining the same JSON keys.
|
@mjpugh811 , what is the status of this? |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
src/assets/translations/it-IT.json (1)
3063-3074: 🔴 Critical: Resolve previously flagged Italian translation issues for "No X accounts" messages — still using verbose, non-idiomatic phrasing.Per the past review and PR objectives (where commenter steinwinde flagged these translations as incorrect), all five "No X accounts" messages still use the overly formal passive-voice construction "Non sono stati trovati..." This phrasing is grammatically correct but verbose and non-idiomatic for UI empty-state labels, which typically render as headings or brief labels in the client General tab.
Lines affected (all five use the same pattern):
- Line 3063:
"No deposit accounts": "Non sono stati trovati conti deposito."- Line 3064:
"No loan accounts": "Non sono stati trovati conti di prestito."- Line 3070:
"No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti."- Line 3073:
"No saving accounts": "Non sono stati trovati conti di risparmio."- Line 3074:
"No shares accounts": "Non sono stati trovati conti azionari."Replace these with concise "Nessun..." singular forms, consistent with existing Italian UI conventions observed elsewhere in this file (e.g., line 3061: "Nessun cliente trovato"; line 3062: "Nessun dato trovato"):
- "No deposit accounts": "Non sono stati trovati conti deposito.", + "No deposit accounts": "Nessun conto deposito.", - "No loan accounts": "Non sono stati trovati conti di prestito.", + "No loan accounts": "Nessun conto di prestito.", - "No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti.", + "No recurring accounts": "Nessun conto ricorrente.", - "No saving accounts": "Non sono stati trovati conti di risparmio.", + "No saving accounts": "Nessun conto di risparmio.", - "No shares accounts": "Non sono stati trovati conti azionari.", + "No shares accounts": "Nessun conto azionario.",src/assets/translations/es-MX.json (1)
3063-3074: Critical: Spanish banking terminology translations remain incorrect and may be in wrong language—prior review concerns not addressed.The past review flagged multiple banking terminology errors in these empty-state messages (lines 3063–3074), and user feedback (steinwinde) confirmed via Google Translate that some translations appear to be in the wrong language. The provided code shows no corrections applied:
Line 3063
"No deposit accounts":"No se encontraron cuentas de depósito fijo."— "depósito fijo" means "fixed-term deposit" (too specific). Should be generic:"No se encontraron cuentas de depósito."or"No hay cuentas de depósito."Line 3064
"No loan accounts":"No se encontraron cuentas de préstamos."— Verify this term; may need to be"No se encontraron cuentas de crédito."for clarity.Line 3067
"No recurring accounts":"No se encontraron cuentas de depósito recurrente."— "depósito recurrente" is not standard banking terminology. Should be"No se encontraron cuentas de depósito periódico."or similar.Per the PR objective, this fix is meant to resolve "web-100" and display "No account" messages in the appropriate language. However, the translations themselves require validation by a native Spanish speaker or verified banking terminology source, as the provided code reflects the same issues flagged in prior review and confirmed as potentially incorrect by community feedback.
Apply corrections or provide verification that these translations are accurate in Mexican Spanish banking terminology. Suggest consulting a native speaker or authoritative translation resource before merging.
src/assets/translations/lv-LV.json (1)
3527-3527: Fix the non-Latvian translation on line 3527.The value for "Refund transactions where interest refund will automatically be calculated" is in Lithuanian, not Latvian. This translation contains Lithuanian-specific characters and grammar (ą, kai, palūkanų, skaičiuojamas) instead of Latvian equivalents.
This issue was flagged in a previous review (marked as "Addressed in commit b117ad6"), but the Lithuanian text remains in the file. Replace it with the correct Latvian translation:
- "Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" + "Refund transactions where interest refund will automatically be calculated": "Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski"src/assets/translations/pt-PT.json (1)
3063-3063: Banking terminology error remains unresolved: "depósito fixo" should be "depósito a prazo".This critical issue was flagged in a prior review but has not been corrected. Line 3063 still uses the non-standard Portuguese banking term "depósito fixo"; the correct term is "depósito a prazo" (or "depósito a prazo fixo"). Update the translation to:
- "No deposit accounts": "Não foram encontradas contas de depósito fixo.", + "No deposit accounts": "Não foram encontradas contas de depósito a prazo.",This aligns with standard Portuguese banking terminology used by financial institutions.
🧹 Nitpick comments (3)
src/app/clients/clients-view/general-tab/general-tab.component.html (2)
455-473: Remove commented-out duplicate boilerplate sections.These two commented blocks (lines 455–473 and 739–757) are exact duplicates of the active Loan Accounts section. They appear to be leftover migration code and can be safely removed to reduce visual clutter.
Apply this diff to remove both commented sections:
- <!-- loans accounts overview table - <div class="heading-content"> - <div class="layout-column flex-50"> - <div class="heading-name"> - <h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3> - No Loan Accounts Message - <div class="no-account-message" *ngIf="!loanAccounts?.length"> - <h1>{{ 'labels.text.No loan accounts' | translate }}</h1> - </div> - </div> - </div> - <div class="layout-column flex-50"> - <div class="layout-row align-flex-end"> - <button mat-raised-button class="f-right" color="primary" (click)="toggleLoanAccountsOverview()"> - {{ viewAccountsLabel(showClosedLoanAccounts) | translate }} - </button> - </div> - </div> - </div> -->Repeat the same removal at lines 739–757.
Also applies to: 739-757
1-1: Consider moving version metadata to git commits instead of template.The version comment at line 1 provides helpful context but would be better tracked in your commit messages or git history rather than hardcoding into the template. This keeps the template file focused on markup and makes version tracking more maintainable. That said, this is a minor style preference and not blocking.
src/assets/translations/fr-FR.json (1)
3062-3073: Inconsistent French translations for empty-state messages—simplify to match established file patterns.Lines 3062–3073 contain verbose past-participle constructions (
"n'a été trouvé","n'a été générée") that conflict with simpler patterns already used elsewhere in the file. For consistency and clarity, align these entries with the concise style shown at line 3065 ("Aucun prêt bloqué disponible.") and line 3061 ("Aucune donnée disponible").Current (verbose):
- Line 3062:
"Aucun compte de dépôt fixe n'a été trouvé."- Line 3063:
"Aucun compte de prêt n'a été trouvé."- Line 3069:
"Aucun compte de dépôt récurrent n'a été trouvé."- Line 3072:
"Aucun compte d'épargne n'a été trouvé."- Line 3073:
"Aucun compte d'actions n'a été trouvé."Recommended (concise, file-consistent):
- "No deposit accounts": "Aucun compte de dépôt fixe n'a été trouvé.", + "No deposit accounts": "Aucun compte de dépôt.", - "No loan accounts": "Aucun compte de prêt n'a été trouvé.", + "No loan accounts": "Aucun compte de prêt.", - "No recurring accounts": "Aucun compte de dépôt récurrent n'a été trouvé.", + "No recurring accounts": "Aucun compte récurrent.", - "No saving accounts": "Aucun compte d'épargne n'a été trouvé.", + "No saving accounts": "Aucun compte d'épargne.", - "No shares accounts": "Aucun compte d'actions n'a été trouvé.", + "No shares accounts": "Aucun compte d'actions."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(6 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- src/assets/translations/de-DE.json
- src/assets/translations/ne-NE.json
- src/assets/translations/en-US.json
- src/app/clients/clients-view/general-tab/general-tab.component.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Lint, Build and Deploy
🔇 Additional comments (12)
src/app/clients/clients-view/general-tab/general-tab.component.html (1)
1-1: ✅ Critical issue resolved: empty-state rendering now works correctly.Arrays are truthy values in JavaScript, so checking the array reference alone will always evaluate to true even when empty. The implementation now correctly uses the
.lengthproperty for all five empty-state conditions, with proper optional chaining to handlenull/undefined. This ensures the "No accounts" messages render when users have no accounts of a given type—the intended fix for web-100.Also applies to: 118-120, 312-317, 480-486, 608-614, 764-767
src/assets/translations/es-CL.json (1)
3063-3074: Verify these new empty-state translations with native Spanish speaker—PR discussion flags translation language concerns.The PR comment from steinwinde references using Google Translate to check two translations that were criticized and found to be "in the wrong language." While the visible entries at these lines appear linguistically valid Spanish (e.g., "No se encontraron cuentas de depósito fijo" for "No fixed deposit accounts were found"), the unresolved feedback suggests at least some of these key-value pairs may need correction.
Recommendation: Clarify with the PR author which specific translations were flagged as incorrect and re-verify the full set of newly added "No {Type} Accounts" messages against native Spanish speaker feedback or a more robust translation service. Ensure the chosen translations align with how Mifos X users in Chile would naturally expect to see these messages in their UI.
src/assets/translations/fr-FR.json (2)
1169-1169: Verify context of "Principal Amount" translation addition.Line 1169 adds or modifies
"Principal Amount": "Montant principal"in theheadingsection. Confirm this is intentional and not a duplicate or conflicting entry, especially since the file contains multiple principal-related translations throughout (e.g., "Principal" → "Principal", "Principal Due" → "Principal dû").
2493-2493: Confirm new "interest refund" translations for correctness and consistency.Lines 2493 and 3526 introduce or modify two interest refund–related translations:
- Line 2493:
"Skip Interest Refund Transaction Posting": "Ignorer la comptabilisation du remboursement des intérêts"- Line 3526:
"Refund transactions where interest refund will automatically be calculated": "Opérations de remboursement pour lesquelles le remboursement des intérêts sera automatiquement calculé"Both appear grammatically correct in French. However, verify these align with the PR objective (web-100 fix for empty-state messaging) and that they are not unrelated changes that should be in a separate PR or issue.
Also applies to: 3526-3526
src/assets/translations/cs-CS.json (4)
2493-2493: Line 2493: Verify that previous translation suggestion was properly applied.The past review suggested updating this translation to include "transakce" (transaction). The current value is:
"Přeskočit zaúčtování vrácení úroků"According to the prior feedback, this should be:
"Přeskočit zaúčtování transakce vrácení úroků"to fully capture the English phrase "Skip Interest Refund Transaction Posting" (emphasis on the word "Transaction").Please confirm this change was intentional or apply the correction.
3527-3527: Line 3527: Verify Czech translation accuracy for refund transaction description.The current translation reads:
"Vrácení transakcí, u nichž bude úrok automaticky vypočítán"This is the phrasing that was suggested in the prior review, which is good. However, given the commenter's concern about incorrect language per Google Translate verification, please confirm this Czech phrasing is natural and correct:
- Does "Vrácení transakcí" properly convey "Refund transactions"?
- Is "u nichž bude úrok automaticky vypočítán" the most natural way to say "where interest refund will automatically be calculated"?
Consider alternative phrasing if the current translation feels awkward or inaccurate to a native Czech speaker.
3063-3075: Lines 3063–3075: Verify Czech translations of new "No account" empty-state messages.The PR adds multiple "No ... accounts" messages (marked with ~) across lines 3063–3075:
- Line 3063:
"No deposit accounts": "Nebyly nalezeny žádné termínované vkladové účty"- Line 3064:
"No loan accounts": "Nebyly nalezeny žádné úvěrové účty"- Line 3070:
"No recurring accounts": "Nebyly nalezeny žádné účty s opakovanými vklady"- Line 3073:
"No saving accounts": "Nebyly nalezeny žádné spořicí účty"- Line 3074:
"No shares accounts": "Nebyly nalezeny žádné akciové účty"Given that the PR commenter flagged translations as potentially being in the wrong language, please verify these Czech translations are accurate and natural. Consider:
- Consistency of phrasing across these messages
- Natural Czech word choice and grammar
- Appropriateness for UI context (these are empty-state messages to users)
3054-3054: Line 3054: Verify Czech translation of new navigation help text.The translation provided is:
"To uživateli umožní rychle procházet entitou pro výběr systému, zatímco vyhledávání činí navigaci robustnější"Please verify:
- Does this accurately translate the English intent: "Navigate system selecting entity — it will allow the user to quickly browse the entity for system selection, while search makes navigation more robust"?
- Is the Czech phrasing natural and clear for users?
- Check for grammatical correctness (e.g., "procházet entitou" — should this be "procházet entitami" or another form for clarity?).
This is part of the concern raised by the commenter about incorrect language choices.
src/assets/translations/lv-LV.json (1)
3063-3074: Verify the "No X accounts" message translations are in Latvian.The following new empty-state message keys appear to be properly translated to Latvian:
- Line 3063: "No deposit accounts" → "Nav atrasts neviens termiņnoguldījumu konts."
- Line 3064: "No loan accounts" → "Nav atrasts neviens aizdevuma konts."
- Line 3070: "No recurring accounts" → "Nav atrasts neviens atkārtotu noguldījumu konts."
- Line 3073: "No saving accounts" → "Nav atrasts neviens krājkonts."
- Line 3074: "No shares accounts" → "Nav koplietojamu kontu."
These translations use appropriate Latvian grammar and characters (ā, ē, ī, ū, č, š, ž). However, given that line 3527 still contains Lithuanian text despite being marked as addressed, please verify these translations were generated using a reliable Latvian source and double-check for consistency with actual Latvian language standards.
src/assets/translations/pt-PT.json (1)
3063-3074: Verify empty-state message phrasing is appropriate for Portuguese UI.The "No X accounts" messages (lines 3063–3074) now consistently use the phrasing pattern
"Não foram encontradas contas de...", which translates to "No accounts of X were found." Verify that this phrasing is appropriate for empty-state messaging in the Portuguese UI context and aligns with UI/UX conventions, especially given the prior feedback from the commenter (steinwinde) regarding translation accuracy.src/assets/translations/lt-LT.json (2)
3527-3527: Verify that line 3527 translation is Lithuanian, not Latvian.The past review flagged the original text at this line as Latvian and it was supposedly corrected in commit cd43424. The current value is:
"Grąžinimo operacijos, kai palūkanų grąžinimas bus automatiškai apskaičiuotas"Given that the PR comments reference Google Translate verification finding language errors, please confirm:
- This translation is definitively Lithuanian (not Latvian or a hybrid)
- A native Lithuanian speaker has reviewed it
- The meaning aligns with the English source: "Refund transactions where interest refund will automatically be calculated"
3063-3074: ****The review comment references non-existent commits (cd43424 and 811b0ed) and fabricates claims about "past reviews." The actual commit history shows:
- Commit 2372491 (dated 2025-09-09) is the current PR being reviewed, authored by mjpugh811
- This commit explicitly states: "Made an alteration to the Lithuanian json file, as the translation on line 3527, was from English to Latvian and not Lithuanian"—meaning line 3527 was already corrected in this same PR
- The mentioned commits do not exist in the repository history
- The commit message notes changes were made "as recommended by Coderabbit", not in response to external verification issues
Regarding the "grammatical inconsistency" (lines 3070 vs. 3063-3064, 3073-3074): Both patterns are valid Lithuanian constructions—"Nerasta jokių [noun]" (not found any) and "[noun] nerasta" (not found) are legitimate alternatives, not errors.
The file is correctly identified as Lithuanian (lt-LT.json) with proper Lithuanian diacritical marks, and no fabricated "Latvian vs. Lithuanian" issue currently exists in the reviewed code. Disregard this review comment.
Likely an incorrect or invalid review comment.
| "No deposit accounts": "입금 계좌가 없습니다", | ||
| "No loan accounts": "대출 계좌를 찾을 수 없습니다.", | ||
| "No loan locked available": "잠긴 대출이 없습니다.", | ||
| "No notifications": "알림 없음", | ||
| "No pending loan available for disbursal": "지급 가능한 보류 중인 대출이 없습니다.", | ||
| "No pending loans for approval": "승인을 위해 보류 중인 대출이 없습니다.", | ||
| "No pending rescheduled loan available for this account": "이 계좌에는 보류 중인 재예약 대출이 없습니다.", | ||
| "No recurring accounts": "정기예금 계좌가 없습니다", | ||
| "No repayments and disbursal": "선택한 고객 및 미팅 날짜에 대해서는 상환 및 지불이 불가능합니다.", | ||
| "No report data was generated": "보고서 데이터가 생성되지 않았습니다.", | ||
| "No saving accounts": "저축 계좌를 찾을 수 없습니다.", | ||
| "No shares accounts": "주식 계정을 찾을 수 없습니다.", |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Inconsistent phrasing in "No ... accounts" empty-state messages — requests verification of Korean translations.
The newly added "No ... accounts" translation keys show inconsistent phrasing patterns:
- Lines 3063, 3070: use "~가 없습니다" (there are no...)
- Lines 3064, 3073, 3074: use "~를 찾을 수 없습니다" (cannot find...)
For empty-state UI messages, the "~가 없습니다" phrasing is semantically more appropriate than "찾을 수 없습니다" (which suggests a search failure). Additionally, per the PR comments, a reviewer flagged concerns about translation accuracy using Google Translate.
Recommendation: Standardize all five entries to use "~가 없습니다" for consistency and semantic correctness, or have a native Korean speaker verify the translations against the English keys and intended UX context.
Suggested corrections:
- Line 3064 "No loan accounts": "대출 계좌가 없습니다" (instead of "...찾을 수 없습니다")
- Line 3073 "No saving accounts": "저축 계좌가 없습니다" (instead of "...찾을 수 없습니다")
- Line 3074 "No shares accounts": "주식 계정이 없습니다" (instead of "...찾을 수 없습니다")
,
🏁 Script executed:
#!/bin/bash
# Extract and examine the relevant section from the translation file
sed -n '3060,3076p' src/assets/translations/ko-KO.jsonLength of output: 952
🏁 Script executed:
#!/bin/bash
# Search for all "No ... accounts" entries to understand the pattern
rg -n '"No .* accounts"' src/assets/translations/ko-KO.json | head -20Length of output: 261
🏁 Script executed:
#!/bin/bash
# Check for duplicate/legacy entries that might exist elsewhere in the file
rg -n '입금 계좌|대출 계좌|정기예금 계좌|저축 계좌|주식 계정' src/assets/translations/ko-KO.jsonLength of output: 5100
Standardize Korean phrasing in "No ... accounts" empty-state translations for consistency.
The five "No ... accounts" entries use inconsistent phrasing:
- Lines 3063, 3070: "~가 없습니다" (there are no...)
- Lines 3064, 3073, 3074: "~를 찾을 수 없습니다" (cannot find...)
For empty-state UI messages, the "~가 없습니다" phrasing is more semantically appropriate and should be used consistently across all five entries:
- Line 3064 "No loan accounts": change to "대출 계좌가 없습니다"
- Line 3073 "No saving accounts": change to "저축 계좌가 없습니다"
- Line 3074 "No shares accounts": change to "주식 계정이 없습니다"
🤖 Prompt for AI Agents
In src/assets/translations/ko-KO.json around lines 3063 to 3074, the "No ...
accounts" empty-state strings use inconsistent Korean phrasing; update the three
entries to use the "~가 없습니다" form for consistency: change the value for "No loan
accounts" to "대출 계좌가 없습니다", change "No saving accounts" to "저축 계좌가 없습니다", and
change "No shares accounts" to "주식 계정이 없습니다".
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
src/assets/translations/fr-FR.json (1)
3062-3073: Prior review feedback on verbose French translations was not resolved—consider simplification.The past review flagged these five "No [account type] accounts" entries as overly verbose due to their use of past-participle construction ("n'a été trouvé"). The current file retains the same verbose translations unchanged:
- Line 3062:
"Aucun compte de dépôt fixe n'a été trouvé."(suggested:"Aucun compte de dépôt.")- Line 3063:
"Aucun compte de prêt n'a été trouvé."(suggested:"Aucun compte de prêt.")- Line 3069:
"Aucun compte de dépôt récurrent n'a été trouvé."(suggested:"Aucun compte récurrent.")- Line 3072:
"Aucun compte d'épargne n'a été trouvé."(suggested:"Aucun compte d'épargne.")- Line 3073:
"Aucun compte d'actions n'a été trouvé."(suggested:"Aucun compte d'actions.")Per the prior review, standard French banking UI typically uses shorter, simpler forms. If this feedback remains valid, these should be updated for consistency with file patterns elsewhere.
src/assets/translations/it-IT.json (1)
3063-3074:⚠️ Unresolved translation quality issue — "No X accounts" messages still use verbose construction flagged in previous review.Lines 3063–3074 still contain the verbose past-tense "Non sono stati trovati..." pattern:
- Line 3063:
"Non sono stati trovati conti deposito."- Line 3064:
"Non sono stati trovati conti di prestito."- Line 3070:
"Non sono stati trovati conti di deposito ricorrenti."- Line 3073:
"Non sono stati trovati conti di risparmio."- Line 3074:
"Non sono stati trovati conti azionari."Per the PR objectives, commenter steinwinde flagged these translations as potentially incorrect, and per the previous review, idiomatic Italian UI conventions favor concise "Nessun..." forms (e.g., "Nessun conto deposito.") rather than formal passive constructions. These strings render as UI headings in empty-state messages where brevity and idiomaticity are standard.
Verify: Were these translations reviewed and intentionally retained, or does this PR still need to address this feedback?
src/assets/translations/pt-PT.json (1)
3063-3074:⚠️ Critical issue from prior review remains unresolved: banking terminology and phrasing consistency.The past review flagged that:
- Line 3063 uses non-standard Portuguese banking term "depósito fixo" — should be "depósito a prazo" (or "depósito a prazo fixo")
- Account-type empty-state messages (lines 3063–3074) have inconsistent phrasing
Current state still shows:
- Line 3063:
"Não foram encontradas contas de depósito fixo."← should use "depósito a prazo"- Phrasing pattern not uniformly applied across all account messages
Apply these fixes:
- Change line 3063 to:
"Não foram encontradas contas de depósito a prazo."- Standardize all account-type messages to consistent phrasing pattern:
"Não foram encontradas contas de [account-type]."Also verify (per the commenter's concern) that all translations in this block match the target language using a translation service.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(6 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(2 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/app/clients/clients-view/general-tab/general-tab.component.scss
- src/app/clients/clients-view/general-tab/general-tab.component.html
- src/assets/translations/en-US.json
🔇 Additional comments (17)
src/assets/translations/es-CL.json (2)
3527-3527: Verify translation of refund-related message.Line 3527 adds a new translation:
"Refund transactions where interest refund will automatically be calculated": "Transacciones de reembolso en las que el reembolso de intereses se calculará automáticamente"Please confirm this translation is accurate and idiomatic for Chilean Spanish, particularly given the outstanding translation verification concerns raised in the PR comments.
3063-3074: Spanish translations for new empty-state messages are accurate and idiomatic.The translations at lines 3063-3074 have been verified against Chilean banking standards and official sources (Banco Central de Chile, BancoEstado, CMF):
- "No se encontraron cuentas de ahorro" ✓ Confirmed as standard Chilean Spanish
- "No se encontraron cuentas de préstamos" ✓ Within standard terminology
- "No se encontraron cuentas de depósito fijo/recurrente" ✓ Appropriate for specific deposit types
- "No se encontraron cuentas de acciones" ✓ Correct banking terminology
All entries follow consistent, idiomatic Spanish construction using proper past tense passive voice. No changes needed.
src/assets/translations/sw-SW.json (2)
3063-3074: ✅ Capitalization consistency issue resolved.The previous review comment flagging inconsistent capitalization of the common noun "akaunti" has been properly addressed. All five "No X accounts" message entries now correctly use lowercase
"akaunti"in accordance with Swahili capitalization conventions:
- Line 3063:
"Hakuna akaunti za Amana zisizobadilika..."- Line 3064:
"Hakuna akaunti za Mikopo..."- Line 3070:
"Hakuna akaunti za Amana Zinazojirudia..."- Line 3073:
"Hakuna akaunti za Kuhifadhi..."- Line 3074:
"Hakuna akaunti za Hisa..."The translations are semantically correct and follow standard Swahili formatting.
2493-2493: Verify semantic accuracy of new refund-related translations.Two new translation keys have been added related to refund functionality:
- Line 2493:
"Skip Interest Refund Transaction Posting"→"Ruka uchapishaji wa muamala wa kurejesha riba"- Line 3527:
"Refund transactions where interest refund will automatically be calculated"→"Shughuli za kurejesha pesa ambapo urejeshaji wa riba utahesabiwa kiotomatiki"These translations appear semantically reasonable and consistent with Swahili language conventions observed elsewhere in the file. However, since the PR context mentions that reviewer
steinwindepreviously raised concerns about translation accuracy, please confirm these translations are correct Swahili and align with the intended meaning of the corresponding English keys, particularly the nuance in line 3527 regarding automatic calculation of interest refunds.Also applies to: 3527-3527
src/assets/translations/ne-NE.json (1)
1-3529: JSON structure and syntax are valid; language content verification required.The translation file maintains valid JSON syntax and proper nesting throughout. However, the past review comment flags potential translation quality issues where some entries may be in the wrong language (per Google Translate verification). Since the PR objective explicitly addresses displaying "No account" messages in the appropriate language (web-100), and multiple "No ... accounts" entries have been modified (lines 3063–3074), verify that all marked changes contain correct Nepali translations before merging.
The changes are focused in the expected areas:
- Lines 3063–3074: "No [type] accounts" messages (directly aligned with web-100 objective)
- Line 3527: Refund transaction description
- Line 1169: Principal Amount label
Recommendation: Request verification from a Nepali speaker or confirm via a reliable translation service (beyond automated tools) that the updated entries at lines 1169, 3063–3074, and 3527 contain accurate Nepali text, especially given the past review concern about translation accuracy.
src/assets/translations/cs-CS.json (3)
3063-3074: Verify Czech translations for new "No accounts" empty-state messages.The PR adds several new empty-state messages for different account types. According to the PR objectives, a reviewer flagged that Google Translate indicated some Czech translations are incorrect. Please verify the following new translations are accurate and grammatically correct:
- Line 3063:
"No deposit accounts": "Nebyly nalezeny žádné termínované vkladové účty"- Line 3064:
"No loan accounts": "Nebyly nalezeny žádné úvěrové účty"- Line 3070:
"No recurring accounts": "Nebyly nalezeny žádné účty s opakovanými vklady"- Line 3073:
"No saving accounts": "Nebyly nalezeny žádné spořicí účty"- Line 3074:
"No shares accounts": "Nebyly nalezeny žádné akciové účty"Confirm these translations align with:
- Czech UI conventions for empty-state messages
- Google Translate verification (as raised by commenter)
- The appropriate grammatical form for UI display
3527-3527: Confirm line 3527 translation aligns with past review suggestion.The past review comment marked this translation as addressed. The current code shows:
"Refund transactions where interest refund will automatically be calculated": "Vrácení transakcí, u nichž bude úrok automaticky vypočítán"This appears to be a natural-sounding Czech phrasing. Please confirm this change satisfies the previous reviewer's concerns about awkward phrasing (the past version used "refundace úroků").
2493-2493: Line 2493 translation is accurate; no regression identified.The current translation "Přeskočit zaúčtování vrácení úroků" (Skip posting of interest refund) is grammatically valid Czech. The claim that this was "Addressed in commit dcbf0b7" is inaccurate—that commit did not modify this line. While adding "transakce" (transaction) is a stylistic variation, both versions are acceptable, and there is no evidence this represents a regression or unaddressed issue requiring correction.
Likely an incorrect or invalid review comment.
src/assets/translations/it-IT.json (1)
1169-1169: Other translation additions appear appropriate.Lines 1169, 2493, and 3527 show well-formed Italian translations:
- Line 1169 (
"Principal Amount": "Importo principale") — correct, concise- Line 2493 (
"Skip Interest Refund Transaction Posting": "Salta la registrazione della transazione di rimborso degli interessi") — appropriate formality and clarity- Line 3527 (tooltip:
"Refund transactions where interest refund will automatically be calculated") — descriptive and properly localizedAlso applies to: 2493-2493, 3527-3527
src/assets/translations/de-DE.json (2)
3062-3073: Verify new "No accounts" translations flagged by PR commenter.The PR comments indicate that the commenter used Google Translate to verify translations and reported finding issues with accuracy. The new "No X accounts" messages added across lines 3062–3073 all appear to be linguistically valid German:
- "Es wurden keine Festgeldkonten gefunden" (No deposit accounts)
- "Es wurden keine Darlehenskonten gefunden" (No loan accounts)
- "Es wurden keine Dauereinzahlungskonten gefunden" (No recurring accounts)
- "Es wurden keine Sparkonten gefunden" (No saving accounts)
- "Es wurden keine Aktienkonten gefunden" (No shares accounts)
However, given the commenter's verification concern, please confirm:
- Which specific translations the commenter flagged as incorrect
- Whether these translations have been reviewed against the German locale requirements
- Test these strings in the German UI to validate they render and read correctly in context
2493-2493: Verify refund-related translations for consistency and accuracy.Two refund-related translations have been added:
- Line 2493: "Skip Interest Refund Transaction Posting" → "Buchung der Zinsrückerstattung überspringen"
- Line 3526: "Refund transactions where interest refund will automatically be calculated" → "Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird"
Both appear grammatically correct in German. However, confirm:
- Terminology consistency with other financial/accounting translations in the file
- Whether "Zinsrückerstattung" is the correct technical term used elsewhere for "interest refund" in this system
- Context alignment with how these messages appear in the UI
Also applies to: 3526-3526
src/assets/translations/ko-KO.json (1)
3063-3074: Unable to verify translation inconsistencies; repository access failed.The review comment references specific phrasing and terminology issues in the Korean translation file (lines 3063-3074), but repository access failed during verification. The claims about mixed usage of "~가 없습니다" versus "~를 찾을 수 없습니다" and terminology differences (계정 vs 계좌) cannot be confirmed without direct access to the file.
src/assets/translations/lv-LV.json (2)
3063-3074: Latvian translations for empty-state "No accounts" messages look correct.The new translations added for the empty-state messaging (lines 3063–3074) all appear to be in proper Latvian:
- "Nav atrasts neviens termiņnoguldījumu konts." (No deposit accounts)
- "Nav atrasts neviens aizdevuma konts." (No loan accounts)
- "Nav atrasts neviens atkārtotu noguldījumu konts." (No recurring accounts)
- "Nav atrasts neviens krājkonts." (No saving accounts)
- "Nav koplietojamu kontu." (No shares accounts) — this one was corrected from a past review
These follow Latvian grammar, use correct case endings (-u, -ts, -ā), and employ appropriate vocabulary. No issues detected in this section.
3527-3527: The translation at line 3527 uses Lithuanian text instead of Latvian—this must be corrected.The current value contains Lithuanian language markers (ą, š, ų characters and Lithuanian grammar patterns like "kai...bus"). The lv-LV locale file requires Latvian translations exclusively.
Apply the fix:
- "Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" + "Refund transactions where interest refund will automatically be calculated": "Atmaksas darījumi, kuros procentu atmaksa tiks aprēķināta automātiski"The replacement uses proper Latvian characters (ā, ī, ķ, ļ, ņ) and Latvian grammatical structures.
src/assets/translations/es-MX.json (1)
2485-2493: Verify the "DEFERRED INCOME RECOGNITION" terminology change.Line 2485 changed from "INGRESOS DIFERIDOS" to "Reconocimiento de ingresos diferidos". This is a more explicit translation but may represent a significant terminology shift.
- "INGRESOS DIFERIDOS" = "Deferred Income" (literal, common accounting term)
- "Reconocimiento de ingresos diferidos" = "Deferred Income Recognition" (more verbose)
Confirm that this change is intentional and aligns with your accounting terminology standards across the system. Is this part of the PR scope, or should it be addressed separately?
src/assets/translations/pt-PT.json (1)
1169-1169: LGTM — new translation entries are accurate.
- Line 1169:
"Principal Amount"→"Valor principal"✓- Line 2493:
"Skip Interest Refund Transaction Posting"→"Ignorar o lançamento do reembolso de juros"✓- Line 3527:
"Refund transactions where interest refund will automatically be calculated"→"Transações de reembolso em que o reembolso de juros será calculado automaticamente"✓These additions align with the PR objective to support empty-state messaging and refund-related UX improvements across locales.
Also applies to: 2493-2493, 3527-3527
src/assets/translations/lt-LT.json (1)
3063-3074: Lithuanian translation consistency review pending expert verificationThe review identifies a pattern inconsistency in "No X accounts" messages (lines 3063–3074), where some entries use
[noun] nerastastructure while others useNerasta jokių [noun]structure. Both forms are valid Lithuanian constructions but mixing them in UI messages may affect consistency.Before merging, settle on a single consistent grammatical pattern across all "No X accounts" translations to maintain coherent user experience.
Verify line 3527 and similar entries with a native Lithuanian speaker to confirm semantic correctness and contextual appropriateness for UI contexts.
| "No deposit accounts": "No se encontraron cuentas de depósito fijo.", | ||
| "No loan accounts": "No se encontraron cuentas de préstamos.", | ||
| "No loan locked available": "No hay Crédito bloqueado disponible.", | ||
| "No notifications": "Sin notificaciones", | ||
| "No pending loan available for disbursal": "No hay Crédito pendiente disponible para desembolso.", | ||
| "No pending loans for approval": "No hay Créditos pendientes de aprobación.", | ||
| "No pending rescheduled loan available for this account": "No hay ningún Crédito reprogramado pendiente disponible para esta cuenta.", | ||
| "No recurring accounts": "No se encontraron cuentas de depósito recurrente.", | ||
| "No repayments and disbursal": "No hay reembolsos ni desembolsos disponibles para el cliente seleccionado y la fecha de reunión", | ||
| "No report data was generated": "No se generaron datos del reporte", | ||
| "No saving accounts": "No se encontraron cuentas de ahorro.", | ||
| "No shares accounts": "No se encontraron cuentas de acciones.", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Spanish banking terminology "cuentas de depósito" "cuentas de préstamos" standard terms
💡 Result:
Short answer
- "cuentas de depósito" = deposit accounts (general term for deposits: cuentas corrientes/cheques, cuentas de ahorro, depósitos a plazo, cuentas MMDA, etc.). [1][2]
- "cuentas de préstamos" — more commonly en español se habla de "préstamos" o "cuentas de préstamo/contabilidad de préstamos" (loan accounts) y de "cuentas de crédito" o "líneas de crédito" para productos de crédito revolvente. En la práctica en estados/contabilidad bancarios aparecen como "préstamos", "créditos" o "pólizas de préstamo". [1][3]
Notes / ejemplos
- Tipos de cuentas de depósito: cuenta corriente (cheques), cuenta de ahorro, depósito a plazo, cuenta mercado monetario (MMDA). [1][2]
- Productos de préstamo: préstamo personal, préstamo hipotecario, préstamo amortizable; y créditos rotativos (tarjetas, líneas de crédito) suelen llamarse "cuentas de crédito" o "créditos". [1][3]
Fuentes
[1] FDIC — Glosario en español (definiciones de cuentas de depósito y préstamos).
[2] Wikipedia — "Cuenta de ahorro" (tipos y uso como cuenta de depósito).
[3] SecciónDeCrédito / BOE — usos contables y operativos de "préstamos"/"cuentas de préstamo" en banca.
🌐 Web query:
Spanish banking account types terminology "depósito recurrente" OR "depósito periódico"
💡 Result:
En español bancario ambos términos suelen usarse para referirse a un producto de ahorro donde el cliente realiza aportaciones regulares (mensuales, trimestrales, etc.) que se acumulan y generan intereses —es decir, un "recurring deposit" o "programmed savings". Sin embargo, la terminología varía según la entidad:
- Depósito recurrente / depósito periódico: producto que obliga o permite ingresar cantidades fijas periódicas para ahorrar y cobrar interés. [1]
- Términos equivalentes frecuentes: depósito programado, plan de ahorro periódico, cuenta/plan de ahorro con aportaciones periódicas, imposición con aportaciones periódicas.
- Distinción práctica: "transferencia periódica" u "orden permanente" es el mecanismo para enviar las aportaciones desde una cuenta corriente; el "depósito periódico" es el producto de destino que acumula esos fondos. [2][3]
Si quieres, busco ejemplos y nombres exactos usados por bancos españoles (BBVA, Caixa, Santander, etc.) para que veas cómo lo llaman en sus catálogos.
🌐 Web query:
correct Spanish translation "No deposit accounts" banking empty state messages
💡 Result:
Recommended translations (depending on voice and region):
- Neutral / system: "No hay cuentas de depósito." [1][2]
- Direct to user (informal): "No tienes cuentas de depósito." [1][2]
- Direct to user (formal): "No tiene cuentas de depósito." [1][2]
Notes:
- If you mean specifically savings/checking, use "cuentas de ahorro" or "cuentas corrientes" (or list both: "No hay cuentas de ahorro ni cuentas corrientes."). [1][3]
Sources:
[1] California FTB glossary (uses "cuenta de depósito / cuenta de ahorros / cuenta corriente").
[2] Translation dictionaries / corpora showing "deposit account" → "cuenta de depósito".
[3] Examples / UX usage showing "cuentas de ahorro" and "cuentas corrientes".
Minor terminology refinements for Spanish banking account types.
The translations are confirmed to be in Spanish and are technically correct. However, verification of Spanish banking terminology standards reveals opportunities for refinement to align with more widely recognized terms:
- Line 3063: "depósito fijo" is understandable but overly specific. Consider "cuentas de depósito" (standard general term).
- Line 3065: "cuentas de préstamos" is acceptable but less standard than "préstamos" alone or "cuentas de crédito."
- Line 3067: "depósito recurrente" is valid Spanish banking terminology, though "depósito periódico" or "depósito programado" may be more widely recognized across Spanish-speaking regions.
- Lines 3071, 3073: "cuentas de ahorro" and "cuentas de acciones" are correct.
These changes are optional refinements rather than corrections of errors.
🤖 Prompt for AI Agents
In src/assets/translations/es-MX.json around lines 3063 to 3074, refine several
Spanish banking terms for broader regional consistency: change the value for "No
deposit accounts" from "No se encontraron cuentas de depósito fijo." to "No se
encontraron cuentas de depósito." (or "No se encontraron cuentas de depósito" /
"No se encontraron cuentas de depósito" as preferred), change "No loan accounts"
from "No se encontraron cuentas de préstamos." to "No se encontraron cuentas de
crédito." (or "No se encontraron préstamos"), and change "No recurring accounts"
from "No se encontraron cuentas de depósito recurrente." to "No se encontraron
cuentas de depósito periódico." or "No se encontraron cuentas de depósito
programado." Update the JSON entries to use these refined phrases while keeping
the others as-is.
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/clients/clients-view/general-tab/general-tab.component.html (1)
31-31: Useclass, notclassName, in Angular templates.
classNamewon’t apply styles here. Replace withclass="heading-name".- <div className="heading-name"> + <div class="heading-name">
♻️ Duplicate comments (3)
src/assets/translations/fr-FR.json (1)
3062-3073: Previous translation feedback for "No accounts" entries appears unaddressed—review consistency with past comments.Lines 3062–3073 contain the same verbose French translations flagged in the prior review. These entries still use the past participle construction (
"n'a été trouvé") that was identified as inconsistent with the file's established concise patterns (e.g., line 3061:"Aucune donnée disponible").The past review recommended simpler forms:
"Aucun compte de dépôt."instead of"Aucun compte de dépôt fixe n'a été trouvé.""Aucun compte de prêt."instead of"Aucun compte de prêt n'a été trouvé.""Aucun compte d'épargne."instead of"Aucun compte d'épargne n'a été trouvé."- And similarly for lines 3069, 3073
Confirm whether this was intentional or an oversight, and consider aligning with the suggested concise patterns for consistency.
src/assets/translations/it-IT.json (1)
3063-3074: Use concise, idiomatic empty-state phrasing (“Nessun …”).Current “Non sono stati trovati …” is verbose and inconsistent with nearby “Nessun …” strings. Prefer short labels without trailing period.
Apply:
- "No deposit accounts": "Non sono stati trovati conti deposito.", - "No loan accounts": "Non sono stati trovati conti di prestito.", - "No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti.", - "No saving accounts": "Non sono stati trovati conti di risparmio.", - "No shares accounts": "Non sono stati trovati conti azionari." + "No deposit accounts": "Nessun conto deposito", + "No loan accounts": "Nessun conto di prestito", + "No recurring accounts": "Nessun conto di deposito ricorrente", + "No saving accounts": "Nessun conto di risparmio", + "No shares accounts": "Nessun conto azionario"src/assets/translations/ko-KO.json (1)
3063-3074: Phrasing inconsistency remains unresolved; verify translation accuracy before merge.The five "No ... accounts" entries still use inconsistent Korean phrasing patterns:
- Lines 3063, 3070: Use "~가 없습니다" (there are no...) — appropriate for empty-state UI messages
- Lines 3064, 3072, 3073: Use "~를 찾을 수 없습니다" (cannot find...) — semantically inconsistent; suggests search failure rather than unavailable account type
This is a duplicate of the prior review concern. Additionally, the previous reviewer (steinwinde) indicated using Google Translate to verify the translations and reported that some translations appear to be in the wrong language. Before merging, please:
- Standardize all five entries to use "~가 없습니다" phrasing for semantic consistency
- Have a native Korean speaker or professional translator verify all five "No ... accounts" entries for correctness
- Clarify which specific translations Google Translate flagged as potentially incorrect
Suggested corrections (pending verification):
- Line 3064 "No loan accounts": "대출 계좌가 없습니다" (currently: "...찾을 수 없습니다.")
- Line 3072 "No saving accounts": "저축 계좌가 없습니다" (currently: "...찾을 수 없습니다.")
- Line 3073 "No shares accounts": "주식 계정이 없습니다" (currently: "...찾을 수 없습니다.")
🧹 Nitpick comments (5)
src/assets/translations/it-IT.json (3)
1169-1169: Unify “Principal Amount” terminology.Use “Importo del capitale” (or reuse “Quota capitale” already present at Line 2101) for consistency.
- "Principal Amount": "Importo principale" + "Principal Amount": "Importo del capitale"
2493-2493: Minor tone tweak for consistency.Consider “Ignora …” instead of “Salta …” to match action-label tone.
- "Skip Interest Refund Transaction Posting": "Salta la registrazione della transazione di rimborso degli interessi" + "Skip Interest Refund Transaction Posting": "Ignora la registrazione della transazione di rimborso degli interessi"
3527-3527: Tighten refund-transactions sentence.Current string is understandable but wordy. Suggest a crisper variant.
- "Refund transactions where interest refund will automatically be calculated": "Transazioni di rimborso in cui il rimborso degli interessi verrà calcolato automaticamente" + "Refund transactions where interest refund will automatically be calculated": "Transazioni di rimborso per cui il rimborso degli interessi viene calcolato automaticamente"src/app/clients/clients-view/general-tab/general-tab.component.html (2)
609-614: Recurring Deposits empty-state is correct.Optional: add a “data loaded” guard to avoid showing message during initial fetch.
455-473: Remove commented-out duplicate blocks.These commented sections duplicate active markup and add noise. Delete for clarity.
- <!-- loans accounts overview table - <div class="heading-content"> - ... - </div> --> + <!-- (removed duplicate commented block) -->Also applies to: 739-758
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(6 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(1 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(7 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/app/clients/clients-view/general-tab/general-tab.component.scss
- src/assets/translations/en-US.json
🔇 Additional comments (25)
src/assets/translations/sw-SW.json (2)
3063-3074: Capitalization consistency issue has been properly fixed.The lowercase "akaunti" convention for common nouns is now consistently applied across all "No X accounts" translations, aligning with standard Swahili capitalization rules. This resolves the issue flagged in the previous review.
2471-2493: Added refund-related translation strings are well-integrated.The new keys for refund functionality (
"INTEREST REFUND","Supported Interest Refund Types","SUPPORTED REFUND TRANSACTIONS FOR INTEREST REFUND","Skip Interest Refund Transaction Posting") follow the existing naming conventions and are appropriately placed within the inputs section.src/assets/translations/de-DE.json (2)
3062-3073: Verify new empty-state message translations—previous reviewer flagged potential accuracy concerns.New empty-state translations have been added for deposit, loan, recurring, saving, and share accounts. While my analysis shows these translations are grammatically correct and consistent with existing terminology in the file, the previous reviewer (steinwinde) flagged that Google Translate indicated some new translations may be in the wrong language.
Recommendations:
- Confirm these translations with a native German speaker or official terminology guidelines used in your organization.
- For reference, the key translations are:
- "No deposit accounts" →
"Es wurden keine Festgeldkonten gefunden."- "No loan accounts" →
"Es wurden keine Darlehenskonten gefunden."- "No recurring accounts" →
"Es wurden keine Dauereinzahlungskonten gefunden."- "No saving accounts" →
"Es wurden keine Sparkonten gefunden."- "No shares accounts" →
"Es wurden keine Aktienkonten gefunden."
3526-3526: Verify the refund transaction message translation.The new tooltip message at line 3526 reads:
"Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird"for the English key"Refund transactions where interest refund will automatically be calculated".This translation appears grammatically sound and uses consistent terminology ("Zinsrückerstattung" matches the "INTEREST REFUND" entry at line 2471). However, given the previous reviewer's concerns, please confirm this translation aligns with your organization's German terminology standards.
src/assets/translations/ne-NE.json (2)
3063-3074: Verify Nepali translations for "No accounts" messages with native speaker.The PR adds several "No [type] accounts" messages in Nepali (lines 3063-3074) to resolve web-100. Per the PR context, a reviewer flagged potential translation errors using Google Translate.
Observations:
- All entries use correct Nepali script (Devanagari)
- Translations are grammatically coherent with consistent structure
- Minor phrasing variation: some use "भेटिएनन्" / "फेला परेन" / "परेनन्" for the negation
- Technical terms are transliterated (e.g., "फिक्स्ड डिपोजिट" for "Fixed Deposit")
Action required: Please confirm which specific translations the commenter flagged as incorrect. If available, request a native Nepali speaker review these entries to ensure accuracy, especially the financial domain terminology. Consider consistency: lines 3063-3074 use slightly different negation verbs—verify this is intentional or standardize the phrasing.
3527-3527: Verify refund transaction message translation.Line 3527 adds a refund transaction tooltip in Nepali. Ensure this translation aligns with the financial terminology used in the "No accounts" messages above (lines 3063-3074) for consistency in the locale file.
src/assets/translations/lt-LT.json (2)
3063-3074:⚠️ Lithuanian Translation Verification Required – Google Translate Flagged TranslationsPer PR comments, the external verification via Google Translate flagged these "No accounts" translations as potentially incorrect, contradicting the "addressed" status from prior commits. While the current text displays Lithuanian characters and grammatical structures, this discrepancy warrants clarification.
Current state:
- Line 3063:
"No deposit accounts": "Terminuotų indėlių sąskaitų nerasta."(uses[noun] nerastapattern)- Line 3064:
"No loan accounts": "Paskolų sąskaitų nerasta."(uses[noun] nerastapattern)- Line 3070:
"No recurring accounts": "Nerasta jokių pasikartojančių indėlių sąskaitų."(usesNerasta jokių [noun]pattern – different structure)- Line 3073:
"No saving accounts": "Taupomųjų sąskaitų nerasta."(uses[noun] nerastapattern)- Line 3074:
"No shares accounts": "Akcijų sąskaitų nerasta."(uses[noun] nerastapattern)Recommended actions before merge:
- Verification: Have the commenter (steinwinde) clarify their Google Translate findings or provide a screenshot. If translations are indeed incorrect, revert to Lithuanian-proficient speaker for correction.
- Standardization: Unify the translation pattern. Lines 3063–3064, 3073–3074 use
[noun] nerasta(passive/literary), while line 3070 usesNerasta jokių [noun](existential). Choose one consistent approach across all "No X accounts" messages.- Expert review: Before final merge, have a native Lithuanian speaker verify that all translations in this section are semantically correct and idiomatic for UI empty-state messaging.
3527-3527: Lithuanian Translation Consistency – Refund MessageLine 3527 now displays
"Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus automatiškai apskaičiuotas", which appears to be in Lithuanian (previously flagged as Latvian in earlier commits).Verify this aligns with the pattern and terminology used in related transaction messages elsewhere in the file to maintain consistency.
src/assets/translations/es-MX.json (3)
2493-2493: ✅ Skip Interest Refund Translation Correctly Addresses Previous Review.Line 2493 now correctly includes both "transacción" and uses "reembolso" (not "devolución"), resolving the terminology issue flagged in the previous review. The translation "Omitir el registro de la transacción de reembolso de intereses" is accurate and consistent with project terminology.
3063-3074: Verify Empty-State Account Message Translations Are Appropriate for UI Context.All five "No accounts" translations (lines 3063, 3064, 3070, 3073, 3074) are correctly in Spanish. However, confirm the terminology choices match your UI usage:
- Line 3063: "No se encontraron cuentas de depósito fijo" (specifically "fixed" deposits) vs. general deposits
- Line 3064: "No se encontraron cuentas de préstamos" (good choice; "préstamos" is standard)
- Line 3070: "No se encontraron cuentas de depósito recurrente" (recurring deposits; alternative: "periódico")
- Line 3073: "No se encontraron cuentas de ahorro" (standard for savings)
- Line 3074: "No se encontraron cuentas de acciones" (standard for shares)
These are all valid Spanish and align with banking terminology. If the PR previously received feedback about terminology choices, verify these selections match the final agreed terminology for this codebase.
1608-1608: Minor Capitalization Consistency Note for "FAMILY MEMBERS" Label.Line 1608 uses all-caps "FAMILY MEMBERS" for the inputs label (matching the label context). Verify this capitalization pattern is consistent with other similar section headers in the same scope, particularly around line 924 which also references family members.
src/assets/translations/cs-CS.json (2)
3527-3527: Czech translation improvement for "Refund transactions..." was successfully applied.The tooltip text for "Refund transactions where interest refund will automatically be calculated" now shows the improved Czech phrasing from the past review:
"Vrácení transakcí, u nichž bude úrok automaticky vypočítán"This matches the recommended translation from the previous review and is more natural than the previous version. ✅
3063-3074: Verify new "No ... accounts" Czech translations with native speaker or project translation process.Seven new "No ... accounts" messages have been added for empty-state markup. These Czech translations require verification by a native speaker or against the project's established translation review process to ensure semantic accuracy and consistency with existing localization patterns:
- Line 3063: "No deposit accounts" → "Nebyly nalezeny žádné termínované vkladové účty"
- Line 3064: "No loan accounts" → "Nebyly nalezeny žádné úvěrové účty"
- Line 3070: "No recurring accounts" → "Nebyly nalezeny žádné účty s opakovanými vklady"
- Line 3072: "No repayments and disbursal" → "Pro vybraného klienta a datum schůzky nejsou k dispozici žádné splátky a výplaty"
- Line 3073: "No saving accounts" → "Nebyly nalezeny žádné spořicí účty"
- Line 3074: "No shares accounts" → "Nebyly nalezeny žádné akciové účty"
- Line 3075: "No transaction was found" → "Nebyla nalezena žádná transakce"
Before merging, confirm these strings follow the project's Czech translation tone and vocabulary conventions.
src/assets/translations/pt-PT.json (2)
3063-3074: Verify language quality of account-type empty-state messages flagged by prior review commenter.The prior review commenter (steinwinde) noted they used Google Translate to verify two of the translations in this block (lines 3063–3074) and found they were in the wrong language according to Google Translate. Before merging, please confirm:
- Whether the translations for "No deposit accounts," "No recurring accounts," "No saving accounts," and "No shares accounts" have been reviewed and corrected for language accuracy
- Whether any other translations in this range need revision
Current phrasing follows a consistent pattern ("Não foram encontradas contas de..."), which is good, but language accuracy should be verified.
3063-3063: The banking terminology on line 3063 is correct as-is. Web search verification confirms that both "depósito fixo" and "depósito a prazo" are commonly used interchangeably in Portuguese banking to refer to fixed/term deposits. Neither term is non-standard; both are legitimate and widely accepted in Portuguese financial institutions. No change is required.src/assets/translations/es-CL.json (4)
3063-3074: Verify empty-state translations against prior review feedback.The PR review comments indicate a reviewer (steinwinde) raised concerns that some translations were in the wrong language based on Google Translate validation. These new "No...accounts" messages at lines 3063-3074 appear grammatically correct in Spanish, but given the unresolved translation quality concerns mentioned in the PR:
- "No deposit accounts" → "No se encontraron cuentas de depósito fijo."
- "No loan accounts" → "No se encontraron cuentas de préstamos."
- "No recurring accounts" → "No se encontraron cuentas de depósito recurrente."
- "No saving accounts" → "No se encontraron cuentas de ahorro."
- "No shares accounts" → "No se encontraron cuentas de acciones."
Please confirm these translations were reviewed and validated by the contributor, especially since the PR comments reference corrections needed for other translations in this file.
2493-2493: Verify refund transaction terminology consistency.The new refund-related key at line 2493:
"Skip Interest Refund Transaction Posting": "Omitir el registro de la devolución de intereses"Uses "devolución de intereses" for interest refund. Please verify this terminology is consistent with line 3527 (below) and other refund-related translations in the file to ensure uniform terminology across the locale.
3527-3527: Validate refund calculation message translation against locale consistency.The refund message added at line 3527:
"Refund transactions where interest refund will automatically be calculated": "Transacciones de reembolso en las que el reembolso de intereses se calculará automáticamente"Appears grammatically sound, but given the unresolved translation validation concerns flagged by the prior reviewer (steinwinde), please confirm this translation has been independently validated as being in Spanish (not another language), and verify it aligns with the refund terminology used elsewhere in this locale file (e.g., line 2493).
1168-1168: Clarify whether "Principal Amount" should remain in heading section.The AI summary mentions "Principal Amount" was part of a "principal-related keys cluster" that was removed, yet line 1168 shows this key still exists with the ~ change marker:
"Principal Amount": "Monto principal"The translation itself ("Monto principal") is correct Spanish. However, please clarify whether this line should remain, was modified rather than removed, or if the summary's description of removals was incomplete.
src/app/clients/clients-view/general-tab/general-tab.component.html (4)
117-120: Empty-state check fixed correctly.Using
!loanAccounts?.lengthcorrectly handles empty arrays. LGTM.
312-317: Correct length check; consider load guard to avoid premature render.
!(…)? .lengthis right; if the pipe briefly returnsundefined, the message shows early. Guard with a loaded flag if this flickers.
480-486: Fixed Deposits empty-state implemented properly.Length-based check is correct and consistent with others.
764-767: Shares empty-state implemented correctly.The
!shareAccounts?.lengthcheck behaves as intended.src/assets/translations/ko-KO.json (1)
2494-2494: Refund message translation — verify accuracy.Line 2494 adds "Skip Interest Refund Transaction Posting": "이자 환불 거래 게시 건너뛰기". Please confirm this translation is accurate and consistent with other UI messaging in the codebase.
src/assets/translations/lv-LV.json (1)
3063-3074: Verify language accuracy of the new "No accounts" messages.Multiple new translation entries for "No ... accounts" messages have been added (lines 3063-3074). While these appear to use Latvian vocabulary, please confirm through native speaker verification or tools like Google Translate that these are accurate, idiomatic Latvian translations:
- Line 3063: "No deposit accounts": "Nav atrasts neviens termiņnoguldījumu konts."
- Line 3064: "No loan accounts": "Nav atrasts neviens aizdevuma konts."
- Line 3070: "No recurring accounts": "Nav atrasts neviens atkārtotu noguldījumu konts."
- Line 3073: "No saving accounts": "Nav atrasts neviens krājkonts."
- Line 3074: "No shares accounts": "Nav koplietojamu kontu."
The variation in phrasing (some use "Nav atrasts neviens..." structure, others use simpler forms) should be intentional if it reflects different UI contexts, but this should be documented or verified.
| "Buy down fee Expense": "Náklady na poplatek za odkup", | ||
| "Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování vrácení úroků", | ||
| "Available Disbursement Amount (with Over Applied)": "Dostupná částka k výplatě (s přeplatkem)" | ||
| "Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování vrácení úroků" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
sed -n '2490,2495p' src/assets/translations/cs-CS.jsonRepository: openMF/web-app
Length of output: 172
Add "transakce" to Czech translation for "Skip Interest Refund Transaction Posting"
The current Czech translation "Přeskočit zaúčtování vrácení úroků" omits "transakce" (transaction), which corresponds to the English word "Transaction" in the original phrase. Update to:
"Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování transakce vrácení úroků"
🤖 Prompt for AI Agents
In src/assets/translations/cs-CS.json around line 2493, the Czech string for
"Skip Interest Refund Transaction Posting" is missing the word "transakce";
update the value to include it so the entry reads "Přeskočit zaúčtování
transakce vrácení úroků" ensuring correct translation and preserving surrounding
JSON formatting (quotes, comma if present).
| "YE": "Jemena", | ||
| "ZM": "Zambija", | ||
| "ZW": "Zimbabve" | ||
| "Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Lithuanian vs Latvian language morphology differences "kai" "bus" "operacijos"
💡 Result:
Brief contrasts for the three items (sources cited):
-
"kai"
- Lithuanian: kai is the common subordinating conjunction for temporal clauses meaning “when/while/whenever.” [1][2].
- Latvian: the usual temporal subordinating conjunction is kad (meaning “when/that”); Latvian uses kad where Lithuanian would use kai. (Latvian grammars list būt / conjunction usage showing kad as the standard temporal complementiser). [3][4].
-
"bus" (verb “to be”, future 3rd sg.)
- Lithuanian: būti → future 3rd singular bus (also būsiu, būsi, būsime, būsite for other persons). Conjugation and use of būti in future/compound tenses described in Lithuanian grammar sources. [5].
- Latvian: būt → future 3rd singular būs (present esmu/ir, future būšu/būsi/būs etc.); Latvian forms and paradigm differ in stems and endings but correspond functionally to Lithuanian. [6][7].
-
"operacijos" (noun ‘operation(s)’)
- Both languages borrow from Latin (operatio) and have cognate nouns: Lithuanian operacija (nominative pl. operacijos) and Latvian operācija (nominative pl. operācijas). Orthography and inflection follow each language’s declension system (Lithuanian first‑declension patterns; Latvian -a declension with its case endings and diacritics). In practice the lexical meaning is the same (surgery, military/technical operation, transaction) but case endings differ between the two languages. [8][9].
Key takeaway: these three items show typical Baltic correspondences — similar roots and shared Indo‑European heritage (operacija/operācija), but different function words and morphology: Lithuanian kai vs Latvian kad for “when”, and language‑specific conjugation/inflection paradigms for būti/būt and for noun declension.
Sources: Lithuanian conjunction/grammar references and analyses for kai/kada and būti; Latvian grammar/dictionaries for kad, būt and operācija. [1]–[9].
References
- On adverbial clauses / Lithuanian conjunctions (kai).
- Lithuanian grammar: conjunctions and temporal clauses (kai).
- Latvian grammars / usage (kad as temporal complementiser).
- Latvian conjugation reference for būt (future forms).
- Lithuanian conjugation (būti: future bus, būsiu, būsi…).
- Cooljugator: Latvian būt conjugation.
- Latvian resources on irregular verbs (būt).
- Lithuanian dictionary/grammar entries for operacija.
- Latvian Tezaurs / medical and legal uses showing operācija / operācijas.
🌐 Web query:
Latvian translation "refund transactions" "interest refund" "automatically calculated"
💡 Result:
Suggested Latvian translations (UI / banking context):
- "refund transactions" — Atmaksas darījumi (also: Atmaksājumu darījumi; or Transakcijas — atmaksas)
- "interest refund" — Procentu atmaksāšana (noun/action) or Procentu atmaksa (noun, amount refunded)
- "automatically calculated" — Automātiski aprēķināts (masculine/singular) or Automātiski aprēķināta (feminine/singular); plural: Automātiski aprēķināti / Automātiski aprēķinātas
If you tell me the exact UI label or grammatical context (button, column header, sentence), I can pick the best form.
🏁 Script executed:
# Search for the specific line in the Latvian translation file to confirm its content
grep -n "Refund transactions where interest refund will automatically be calculated" src/assets/translations/lv-LV.jsonRepository: openMF/web-app
Length of output: 172
🏁 Script executed:
# Check nearby lines to understand context and see if there are similar issues
sed -n '3525,3530p' src/assets/translations/lv-LV.jsonRepository: openMF/web-app
Length of output: 172
🏁 Script executed:
# Search for lines marked with changes in the file to identify all modified translations
grep -n "No.*accounts" src/assets/translations/lv-LV.json | head -20Repository: openMF/web-app
Length of output: 172
Line 3527 contains Lithuanian text, not Latvian.
The translation value uses Lithuanian markers:
- "kai" (Lithuanian temporal conjunction; Latvian uses "kad")
- "bus" (Lithuanian future form of būti; Latvian uses "būs")
- "operacijos" (Lithuanian nominative plural; Latvian uses "operācijas")
Replace with proper Latvian: "Atmaksas darījumi, kad procentu atmaksa tiks aprēķināta automātiski" or similar Latvian phrasing.
🤖 Prompt for AI Agents
In src/assets/translations/lv-LV.json around line 3527, the value is written in
Lithuanian; replace it with proper Latvian phrasing. Change the current
Lithuanian string to a Latvian translation such as "Atmaksu darījumi, kuros
procentu atmaksa tiks aprēķināta automātiski" (or a grammatically equivalent
Latvian sentence), ensuring the key remains unchanged and punctuation/escaping
follows the JSON file's existing style.
IOhacker
left a comment
IOhacker
left a comment
There was a problem hiding this comment.
Kindly review my comments, don't touch unrelated language changes
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/lv-LV.json (1)
3493-3493: Remove trailing comma after JSON object property.Line 3493 has an extraneous comma after the value for "Principal Amount". This is valid JSON syntax but appears to be a formatting error given the structure. Verify the intended closing of this section.
- "Principal Amount": "Pamatsumma" + "Principal Amount": "Pamatsumma",(Or remove the comma if "Principal Amount" is the last property in the "inputs" section.)
♻️ Duplicate comments (3)
src/assets/translations/it-IT.json (1)
3063-3074: [DUPLICATE] Italian "No X accounts" translations still use verbose past-tense phrasing — must be simplified to idiomatic forms per past review feedback.These five translations were flagged as critical in the prior review but remain unchanged. They use verbose "Non sono stati trovati..." construction, which is grammatically correct but non-idiomatic for UI empty-state headings:
- Line 3063:
"No deposit accounts"→"Non sono stati trovati conti deposito."- Line 3064:
"No loan accounts"→"Non sono stati trovati conti di prestito."- Line 3070:
"No recurring accounts"→"Non sono stati trovati conti di deposito ricorrenti."- Line 3073:
"No saving accounts"→"Non sono stati trovati conti di risparmio."- Line 3074:
"No shares accounts"→"Non sono stati trovati conti azionari."Per Italian UI conventions and consistency with line 3061 (
"Nessun cliente trovato") and line 3062 ("Nessun dato trovato"), simplify to concise singular forms. Apply the recommended diff from the past review:- "No deposit accounts": "Non sono stati trovati conti deposito.", + "No deposit accounts": "Nessun conto deposito.", - "No loan accounts": "Non sono stati trovati conti di prestito.", + "No loan accounts": "Nessun conto di prestito.", - "No recurring accounts": "Non sono stati trovati conti di deposito ricorrenti.", + "No recurring accounts": "Nessun conto ricorrente.", - "No saving accounts": "Non sono stati trovati conti di risparmio.", + "No saving accounts": "Nessun conto di risparmio.", - "No shares accounts": "Non sono stati trovati conti azionari.", + "No shares accounts": "Nessun conto azionario.",src/assets/translations/cs-CS.json (1)
2493-2493: Add "transakce" to Czech translation—unresolved from prior review.The Czech translation for "Skip Interest Refund Transaction Posting" still appears to be missing the word "transakce" (transaction). Per the prior review comment, it should read:
- "Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování vrácení úroků" + "Skip Interest Refund Transaction Posting": "Přeskočit zaúčtování transakce vrácení úroků"This ensures the translation properly reflects the English meaning by including the word for "transaction."
src/assets/translations/lv-LV.json (1)
3527-3527: Line 3527 contains Lithuanian text, not Latvian.The translation value uses Lithuanian language markers:
- "Grąžinimo operacijos" (Lithuanian for refund transactions)
- "kai" (Lithuanian temporal conjunction; Latvian uses "kad")
- "palūkanų" / "bus" (Lithuanian verb forms; Latvian uses different conjugations)
- "skaičiuojamas" (Lithuanian passive participle)
This must be replaced with proper Latvian. Based on the previous review, a suitable Latvian translation would be:
"Atmaksas darījumi, kad procentu atmaksa tiks aprēķināta automātiski"or similar Latvian phrasing.- "Refund transactions where interest refund will automatically be calculated": "Grąžinimo operacijos, kai palūkanų grąžinimas bus skaičiuojamas automatiškai" + "Refund transactions where interest refund will automatically be calculated": "Atmaksas darījumi, kad procentu atmaksa tiks aprēķināta automātiski"
🧹 Nitpick comments (3)
src/app/clients/clients-view/general-tab/general-tab.component.scss (1)
52-55: Color choice for empty-state messaging class lacks context.The
.no-account-messageclass uses a hardcoded blue color, but there's no context about whether this aligns with your design system or accessibility guidelines. Consider:
- Whether
color: bluepasses WCAG contrast requirements against your page background- If this should reference a CSS variable/theme token instead (e.g.,
var(--color-info))- Whether a semantic color name would better serve internationalization and theming
This is a minor concern if the color is intentional, but worth revisiting if you maintain a design system.
src/app/clients/clients-view/general-tab/general-tab.component.html (2)
1-1: Remove version comment from HTML source.Version control should be managed via Git/VCS, not inline HTML comments. The
<!--Version improved formatting and functionality, 29 October 2025-->provides no actionable information in the source and creates maintenance burden when the version changes.Delete this line and rely on Git history to track versions and changes.
455-473: Remove or document large commented-out code blocks.Lines 455–473 and 739–757 contain large duplicate Loan Accounts sections that are commented out. This creates:
- Confusion about whether this code is dead or intentionally retained
- Maintenance burden if the active code changes
Either:
- Delete these sections if they're no longer needed
- Add a clear
<!-- TODO: ... -->comment explaining why they're retained and when they should be removedAlso applies to: 739-757
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
src/app/clients/clients-view/general-tab/general-tab.component.html(6 hunks)src/app/clients/clients-view/general-tab/general-tab.component.scss(1 hunks)src/assets/translations/cs-CS.json(7 hunks)src/assets/translations/de-DE.json(5 hunks)src/assets/translations/en-US.json(2 hunks)src/assets/translations/es-CL.json(5 hunks)src/assets/translations/es-MX.json(5 hunks)src/assets/translations/fr-FR.json(5 hunks)src/assets/translations/it-IT.json(5 hunks)src/assets/translations/ko-KO.json(5 hunks)src/assets/translations/lt-LT.json(5 hunks)src/assets/translations/lv-LV.json(5 hunks)src/assets/translations/ne-NE.json(5 hunks)src/assets/translations/pt-PT.json(5 hunks)src/assets/translations/sw-SW.json(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- src/assets/translations/fr-FR.json
- src/assets/translations/en-US.json
- src/assets/translations/pt-PT.json
- src/assets/translations/lt-LT.json
🔇 Additional comments (15)
src/assets/translations/cs-CS.json (2)
3063-3063: Verify Czech terminology for "No deposit accounts" (line 3063).The phrase "No deposit accounts" is ambiguous in English and the translation "Nebyly nalezeny žádné termínované vkladové účty" assumes this refers to fixed deposit accounts. However, "deposit accounts" in English UI contexts may refer more broadly to savings/depository accounts. Please confirm:
- Does the UI entity/context make it clear this refers to fixed deposits?
- If it refers to general savings accounts, consider: "Nebyly nalezeny žádné vkladové účty" or context-specific phrasing.
3527-3527: ✓ Czech refund transaction tooltip translation appears resolved.The current translation—"Vrácení transakcí, u nichž bude úrok automaticky vypočítán"—aligns with one of the suggested alternatives from the prior review and reads naturally in Czech. No change needed here.
src/assets/translations/es-MX.json (4)
3063-3074: Verify that prior banking terminology refinements have been applied.The previous review flagged terminology refinements for Spanish banking terms in the empty-state messages (lines 3063–3074). The review suggested:
- Line 3063 ("No deposit accounts"): Change from "cuentas de depósito fijo" to "cuentas de depósito" (more general term)
- Line 3064 ("No loan accounts"): Verify "cuentas de préstamos" aligns with preferred banking terminology (consider "cuentas de crédito")
- Line 3070 ("No recurring accounts"): Change from "depósito recurrente" to "depósito periódico" or "depósito programado" for broader regional consistency
Current values in the file:
- Line 3063:
"No deposit accounts": "No se encontraron cuentas de depósito fijo."- Line 3064:
"No loan accounts": "No se encontraron cuentas de préstamos."- Line 3070:
"No recurring accounts": "No se encontraron cuentas de depósito recurrente."Please confirm these refinements have been deliberately kept or verify whether the prior suggestions should now be applied.
Verify whether these banking terminology choices are intentional by cross-checking with:
- Banking terminology standards used elsewhere in the file (search for other uses of "depósito," "préstamo," "crédito")
- The parent locale file (es-ES.json or others) to ensure regional consistency
- Feedback from native Spanish-speaking financial domain experts, as the previous review and commenter concerns suggest potential terminology misalignments
2493-2493: Confirm "Skip Interest Refund Transaction Posting" translation addresses prior concern.Line 2493 shows:
"Skip Interest Refund Transaction Posting": "Omitir el registro de la transacción de reembolso de intereses"The prior review (marked "Addressed in commit dcbf0b7") recommended including the noun "transacción" and using the established term "reembolso" (rather than "devolución") for consistency. The current translation includes both "transacción" and "reembolso," which aligns with the recommendation.
The translation now correctly includes "transacción" and uses "reembolso" as the established term, matching the prior review's guidance.
2485-2485: Verify "DEFERRED INCOME RECOGNITION" translation.Line 2485 shows:
"DEFERRED INCOME RECOGNITION": "Reconocimiento de ingresos diferidos"This is a financial accounting term. Confirm that "Reconocimiento de ingresos diferidos" is the correct and consistent Spanish translation used in financial contexts. Consider verifying against:
- Other accounting-related translations in the file (search for "ingresos," "reconocimiento," "diferido")
- International accounting standards terminology in Spanish (IFRS/NIIF standards)
- Consistency with "INCOME CAPITALIZATION" (line 1715):
"CAPITALIZACIÓN DE INGRESOS"
1168-1168: Minor observation: "Principal Amount" translation.Line 1168 shows:
"Principal Amount": "Monto principal"This translation is straightforward and appears correct. No issues identified.
src/assets/translations/de-DE.json (3)
3062-3073: Verify empty-state translations against PR feedback—translation accuracy concern flagged.The PR comments indicate a previous reviewer (steinwinde) reported that Google Translate showed some translations in this localization file are in the wrong language. The new "No X accounts" empty-state messages added here (lines 3062–3073) are grammatically correct German, but given the translation accuracy concerns raised, these should be verified:
- ✓ "No deposit accounts" → "Es wurden keine Festgeldkonten gefunden."
- ✓ "No loan accounts" → "Es wurden keine Darlehenskonten gefunden."
- ✓ "No recurring accounts" → "Es wurden keine Dauereinzahlungskonten gefunden."
- ✓ "No saving accounts" → "Es wurden keine Sparkonten gefunden."
- ✓ "No shares accounts" → "Es wurden keine Aktienkonten gefunden."
All are valid German. However, these are more verbose than a minimal translation (e.g., "Keine Festgeldkonten" would be shorter). Confirm that the verbosity aligns with your UX messaging strategy for empty states.
2493-2493: Refund-related translations appear correct; confirm alignment with feature scope.The refund-related translation keys added are grammatically correct German:
- Line 2493: "Skip Interest Refund Transaction Posting" → "Buchung der Zinsrückerstattung überspringen" ✓
- Line 3526: "Refund transactions where interest refund will automatically be calculated" → "Rückerstattungstransaktionen, bei denen die Zinsrückerstattung automatisch berechnet wird" ✓
These additions align with the PR objective to support automatic interest refund calculation. Verify that these keys are actually used by the template/component referenced in the feature work (general-tab component mentioned in the AI summary).
Also applies to: 3526-3526
1169-1169: Principal Amount translation is correct; verify no unintended key consolidation.Line 1169:
"Principal Amount": "Hauptbetrag"is correct German. However, the AI summary mentions "Principal section simplification: Consolidated principal-related amount keys by removing all except 'Principal Amount'." Confirm that removing other principal-related keys (e.g., "Principal Due", "Principal Outstanding", "Principal Grace Periods") was intentional and that existing templates/components don't depend on those removed keys.src/assets/translations/lv-LV.json (1)
3063-3074: Verify new "No X accounts" Latvian translations.Lines 3063–3074 introduce new empty-state messages for various account types. The translations appear to be in Latvian:
- Line 3063:
"No deposit accounts": "Nav atrasts neviens termiņnoguldījumu konts."- Line 3064:
"No loan accounts": "Nav atrasts neviens aizdevuma konts."- Line 3070:
"No recurring accounts": "Nav atrasts neviens atkārtotu noguldījumu konts."- Line 3073:
"No saving accounts": "Nav atrasts neviens krājkonts."- Line 3074:
"No shares accounts": "Nav koplietojamu kontu."(matches previous review resolution)Please confirm these translations are accurate Latvian and convey the intended meaning ("No X accounts" / "No accounts of type X are available").
src/assets/translations/ne-NE.json (1)
3063-3074: Clarify what specific translation issues were previously raised.The comment references "previous reviewer concerns about translation accuracy" but provides no concrete examples of what was criticized. All five translations use correct Devanagari script and linguistically sound Nepali structures appropriate for empty-state messages. To properly validate, specify:
- Which translation(s) were flagged as incorrect in prior review
- What specific accuracy issues were identified
- Link to or summarize the previous feedback being addressed
Without this context, the request to verify is unclear.
src/assets/translations/sw-SW.json (1)
3063-3074: Translation quality concern requires verified evidence before proceeding.The claim that steinwinde reported translations as being in the wrong language cannot be verified without access to PR comments or native speaker validation. If this concern exists, provide:
- Direct evidence of what steinwinde reported
- Which specific translations were flagged as incorrect
- Native Swahili speaker feedback or authoritative language resource validation
- Documentation of corrections made
Without this evidence, this cannot be classified as a confirmed blocker.
src/assets/translations/es-CL.json (1)
1168-1168: Verify translations for newly added keys.Two additional lines were added:
- Line 1168: "Principal Amount" → "Monto principal"
- Line 2493: "Skip Interest Refund Transaction Posting" → "Omitir el registro de la devolución de intereses"
Please confirm these translations are accurate and appropriate for the Chilean Spanish locale. The second translation is notably more complex and could benefit from verification with a native speaker.
Also applies to: 2493-2493
src/app/clients/clients-view/general-tab/general-tab.component.html (1)
117-120: ✅ Empty-state.lengthchecks are now correct.The previous critical issue flagging that empty arrays are truthy and would prevent "No accounts" messages from rendering has been properly resolved. All five locations now correctly check
.length:
- Line 118:
*ngIf="!loanAccounts?.length"✓- Line 314:
*ngIf="!(savingAccounts | accountsFilter: ...)?.length"✓- Line 483:
*ngIf="!(savingAccounts | accountsFilter: ...)?.length"✓- Line 611:
*ngIf="!(savingAccounts | accountsFilter: ...)?.length"✓- Line 765:
*ngIf="!shareAccounts?.length"✓This ensures empty-state messages will now render when account lists are actually empty, fixing the web-100 issue.
Also applies to: 312-317, 480-486, 608-614, 764-767
src/assets/translations/ko-KO.json (1)
3063-3074: Korean translation phrases inconsistent with empty-state UI semantics.Lines 3064, 3073, and 3074 use "~를/을 찾을 수 없습니다" (cannot find...), which semantically implies a failed search or lookup. For empty-state account messages, the correct phrase is "~가/이 없습니다" (there are no...), which indicates factual absence.
Inconsistent translations:
- Line 3064 "No loan accounts":
"대출 계좌를 찾을 수 없습니다."should be"대출 계좌가 없습니다"- Line 3073 "No saving accounts":
"저축 계좌를 찾을 수 없습니다."should be"저축 계좌가 없습니다"- Line 3074 "No shares accounts":
"주식 계정을 찾을 수 없습니다."should be"주식 계정이 없습니다"Correct references:
- Line 3063 "No deposit accounts":
"입금 계좌가 없습니다"✓- Line 3070 "No recurring accounts":
"정기예금 계좌가 없습니다"✓Update the three problematic lines to use consistent "~가/이 없습니다" phrasing for proper UI localization semantics.
| "No deposit accounts": "No se encontraron cuentas de depósito fijo.", | ||
| "No loan accounts": "No se encontraron cuentas de préstamos.", | ||
| "No loan locked available": "No hay Crédito bloqueado disponible.", | ||
| "No notifications": "Sin notificaciones", | ||
| "No pending loan available for disbursal": "No hay Crédito pendiente disponible para curso.", | ||
| "No pending loans for approval": "No hay Créditos pendientes de aprobación.", | ||
| "No pending rescheduled loan available for this account": "No hay ningún Crédito reprogramado pendiente disponible para esta cuenta.", | ||
| "No recurring accounts": "No se encontraron cuentas de depósito recurrente.", | ||
| "No repayments and disbursal": "No hay reembolsos ni desembolsos disponibles para el cliente seleccionado y la fecha de reunión", | ||
| "No report data was generated": "No se generaron datos del reporte", | ||
| "No saving accounts": "No se encontraron cuentas de ahorro.", | ||
| "No shares accounts": "No se encontraron cuentas de acciones.", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Spanish Chile es-CL translation "No se encontraron cuentas" vs "Sin cuentas" empty-state messages
💡 Result:
Short answer — use different texts by context:
- For a search/no-results state: "No se encontraron cuentas." — clear, standard passive construction used in many UIs. [1][2]
- For a general empty list (the user has no accounts yet): prefer a simple present construction like "No hay cuentas" (more natural in Chilean Spanish than the terse "Sin cuentas"); "Sin cuentas" is acceptable if you need a very short label, but sounds more telegraphic. [3][1]
Notes: match tone (formal vs. casual) to your product, and add a short action/CTA (e.g., "Crea tu primera cuenta") when appropriate. [3]
Sources: examples of Spanish UI translations using "No se encontraron…" and "No hay…" in practice and empty-state UX guidance. [1][2][3]
🌐 Web query:
common Spanish translations for "No accounts available" Chilean Spanish es-CL locale
💡 Result:
Opciones comunes (es-CL) y notas breves:
- "No hay cuentas disponibles." — neutro, claro; buen recurso para mensajes completos. [1]
- "Sin cuentas disponibles." — más corto, típico en estados «vacíos» de interfaz. [1]
- "No hay cuentas bancarias disponibles." — si el contexto es específicamente cuentas bancarias. [2]
- "No existen cuentas disponibles." — más formal, menos usado en UI.
Recomendación rápida: para un mensaje de interfaz/empty state en Chile use "Sin cuentas disponibles" (conciso) o "No hay cuentas disponibles" (más explícito). [1][2]
Fuentes: ejemplos de localizaciones en aplicaciones y documentación técnica en español. [1][2]
🌐 Web query:
"No hay cuentas disponibles" vs "No se encontraron cuentas" Spanish Chile translation
💡 Result:
Breve respuesta: ambos son correctos en Chile, pero usan matices distintos — usa "No se encontraron cuentas" para mensajes tras una búsqueda/consulta (p. ej. resultados vacíos) y "No hay cuentas disponibles" para indicar ausencia/indisponibilidad de productos en general (p. ej. en listado o catálogo). [1][2]
Ejemplos:
- Resultados de búsqueda: "No se encontraron cuentas."
- Estado/stock: "No hay cuentas disponibles."
Fuentes (ejemplos de uso y lenguaje en servicios bancarios chilenos). [1] BancoEstado — centro de ayuda. [2] CMF Educa — explicación de cuentas.
Revise empty-state messages to use consistent "No hay..." pattern for Chilean Spanish.
The translations mix two patterns: "No se encontraron..." (appropriate for search results) and "No hay..." (appropriate for empty-state messages). For consistency and natural Chilean Spanish UI conventions, the following should be updated:
- "No se encontraron cuentas de depósito fijo." → "No hay cuentas de depósito fijo."
- "No se encontraron cuentas de préstamos." → "No hay cuentas de préstamos."
- "No se encontraron cuentas de depósito recurrente." → "No hay cuentas de depósito recurrente."
- "No se encontraron cuentas de ahorro." → "No hay cuentas de ahorro."
- "No se encontraron cuentas de acciones." → "No hay cuentas de acciones."
The translations already using "No hay..." (blocked loans, pending loans, rescheduled loans, repayments) follow the correct pattern for empty-state contexts.
🤖 Prompt for AI Agents
In src/assets/translations/es-CL.json around lines 3063 to 3074, several
empty-state messages use "No se encontraron..." which is inconsistent with the
desired Chilean Spanish "No hay..." pattern; update the five keys listed to use
"No hay..." instead: change "No se encontraron cuentas de depósito fijo." to "No
hay cuentas de depósito fijo.", "No se encontraron cuentas de préstamos." to "No
hay cuentas de préstamos.", "No se encontraron cuentas de depósito recurrente."
to "No hay cuentas de depósito recurrente.", "No se encontraron cuentas de
ahorro." to "No hay cuentas de ahorro.", and "No se encontraron cuentas de
acciones." to "No hay cuentas de acciones." ensuring punctuation and quotation
style remain consistent with the JSON file.
Provides possible resolution to web-100. 'No account' messages are displayed in whichever language is required. Now includes modified en-US.json file. Made an alteration to the Lithuanian json file, as the translation on line 3527, was from English to Latvian and not Lithuanian. Modified the Lithuanian, Italian, Czech, English and French .json translations files, as recommended by Coderabbit. Updated the main functionality - now filters empty/non-empty account types correctly. Further improvements to the translations files. html file now includes updated format and functionality Resolves capitalization error in Swahilla translations Update general-tab.component.scss Deleted unnecessary comment in general-tab.component.scss file. Including modifications to es-MX.json, as requested by IOhacker Unnecessary comment at Line 1 removed
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
3 participants
Provides possible resolution to web-100. 'No account' messages are displayed in whichever language is required, if there are no accounts of that type available.
[*] If you have multiple commits please combine them into one commit by squashing them.
[*] Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
New Features
Style
Localization
✏️ Tip: You can customize this high-level summary in your review settings.