fix: support multiple packets per WebSocket frame #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden signals: This is not officially supported in the specification, but some server implementations hide domain signals, but automatically subscribe them them a corresponding value signal is subscribed. This results in a "surprise" subscribe notification for a signal that was not previously announced. This was not previously handled. Tables with names other than signals: Some implementations assign table names that do not match the IDs of the signals that drive them. This was not previously supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes four changes:
Multiple packets per WebSocket frame
Although not explicitly clarified in the spec, some implementations transmit multiple Streaming Protocol packets concatenated (without padding) in a single WebSocket frame. This PR adds support for that.
Hidden signals
This is not officially supported in the specification, but some server implementations hide domain signals, but automatically subscribe them when a corresponding value signal is subscribed. This results in a "surprise" subscribe notification for a signal that was not previously announced. This was not previously handled.
Tables with names other than signals
Some implementations assign table names that do not match the IDs of the signals that drive them. This was not previously supported.
Support units in "definition" object
Some implementations strictly follow the spec and only populate "units" in the "definition" section and omit the one in "interpretation." This was not previously supported. However, implementations should probably still fill out the "interpretation.units" object anyway, as it contains more fields than the one in "definition" and logically belongs there anyway.