Fix use-after-free on OpcUaServer stop during device teardown#26
Open
alexadereyko wants to merge 1 commit into
Open
Fix use-after-free on OpcUaServer stop during device teardown#26alexadereyko wants to merge 1 commit into
alexadereyko wants to merge 1 commit into
Conversation
TmsServer::stop stopped the OpcUaServer (nulling its UA_Server*) before releasing tmsDevice/tmsContext. A device worker thread emitting core events during teardown could still reach the live TmsServerSignal listeners, which call into the already-stopped server -- use-after-free on the null UA_Server* (crash in UA_LOCK). Reset tmsDevice and tmsContext first so ~TmsServerContext unsubscribes from the core event channel before the server is stopped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TmsServer::stop stopped the OpcUaServer (nulling its UA_Server*) before releasing tmsDevice/tmsContext. A device worker thread emitting core events during teardown could still reach the live TmsServerSignal listeners, which call into the already-stopped server -- use-after-free on the null UA_Server* (crash in UA_LOCK).
Reset tmsDevice and tmsContext first so ~TmsServerContext unsubscribes from the core event channel before the server is stopped.