Conversions between openDAQ and C for openDAQ core types #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomaz-cvetko
left a comment
tomaz-cvetko
left a comment
There was a problem hiding this comment.
Looks good in general, it would be good to rename some conversion functions to always have consistent naming in alignment with the direction of conversion.
There is also some discussion to be had regarding sideways interface casting - maybe I need to be educated what is possible there and what is not.
JakaMohorko
requested changes
Jan 29, 2026
tomaz-cvetko
reviewed
Feb 2, 2026
tomaz-cvetko
reviewed
Feb 2, 2026
tomaz-cvetko
reviewed
Feb 2, 2026
Collaborator
Author
|
This pull is outdated and made redundant due to another PR have the changes proposed in here included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversions for: