feat(otlp-http): improve endpoint handling, add User-Agent header, an…#2074
Open
arjun-rajappa wants to merge 1 commit intoopen-telemetry:mainfrom
Open
feat(otlp-http): improve endpoint handling, add User-Agent header, an…#2074arjun-rajappa wants to merge 1 commit intoopen-telemetry:mainfrom
arjun-rajappa wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
…d enhance metrics - Add spec-compliant default User-Agent header with exporter version and Ruby runtime info - Fix endpoint path construction to properly handle OTEL_EXPORTER_OTLP_ENDPOINT with/without trailing slashes - Implement proper endpoint precedence: explicit endpoint > OTEL_EXPORTER_OTLP_TRACES_ENDPOINT > OTEL_EXPORTER_OTLP_ENDPOINT - Add metrics for compressed and uncompressed message sizes - Add specific error handling and logging for 404 responses - Refactor endpoint and header preparation into dedicated methods - Prevent header mutation by duplicating Hash parameters - Add comprehensive test coverage for endpoint path handling and User-Agent header Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
| private_constant(:ERROR_MESSAGE_INVALID_HEADERS) | ||
|
|
||
| def initialize(endpoint: OpenTelemetry::Common::Utilities.config_opt('OTEL_EXPORTER_OTLP_TRACES_ENDPOINT', 'OTEL_EXPORTER_OTLP_ENDPOINT', default: 'http://localhost:4318/v1/traces'), | ||
| DEFAULT_USER_AGENT = "OTel-OTLP-Exporter-Ruby/#{OpenTelemetry::Exporter::OTLP::HTTP::VERSION} Ruby/#{RUBY_VERSION} (#{RUBY_PLATFORM}; #{RUBY_ENGINE}/#{RUBY_ENGINE_VERSION})".freeze |
| compression: OpenTelemetry::Common::Utilities.config_opt('OTEL_EXPORTER_OTLP_TRACES_COMPRESSION', 'OTEL_EXPORTER_OTLP_COMPRESSION', default: 'gzip'), | ||
| timeout: OpenTelemetry::Common::Utilities.config_opt('OTEL_EXPORTER_OTLP_TRACES_TIMEOUT', 'OTEL_EXPORTER_OTLP_TIMEOUT', default: 10), | ||
| metrics_reporter: nil) | ||
| raise ArgumentError, "invalid url for OTLP::Exporter #{endpoint}" unless OpenTelemetry::Common::Utilities.valid_url?(endpoint) |
Contributor
There was a problem hiding this comment.
why remove this validation?
Comment on lines
-141
to
+142
| request.body = if @compression == 'gzip' | ||
| request.add_field('Content-Encoding', 'gzip') | ||
| Zlib.gzip(bytes) | ||
| else | ||
| bytes | ||
| end | ||
| if @compression == 'gzip' | ||
| request.add_field('Content-Encoding', 'gzip') | ||
| body = Zlib.gzip(bytes) | ||
| @metrics_reporter.record_value('otel.otlp_exporter.message.compressed_size', value: body.bytesize) | ||
| else | ||
| body = bytes | ||
| end | ||
| request.body = body |
Contributor
There was a problem hiding this comment.
There is no metrics support at this point, so I don't think it needs to change here.
value = if ... else ... is more idiomatic in Ruby.
| redo if backoff?(retry_count: retry_count += 1, reason: response.code) | ||
| FAILURE | ||
| when Net::HTTPNotFound | ||
| log_request_failure(response.code) |
Contributor
There was a problem hiding this comment.
There is no metrics support, OpenTelemetry.handle_error seems enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1667