Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -386,10 +386,10 @@ def _collect_imports(self, proto_file: str) -> Set[str]:
Returns:
Set of import statement strings
"""
return set(
return {
"import " + self._get_module_path(dep_file)
for dep_file in self._file_dependencies.get(proto_file, [])
)
}

def _generate_enums_for_file(
self,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def __init__(
elif isinstance(self._headers, dict):
self._headers = tuple(self._headers.items())
if self._headers is None:
self._headers = tuple()
self._headers = ()

if channel_options:
# merge the default channel options with the one passed as parameter
Expand Down
8 changes: 2 additions & 6 deletions opentelemetry-sdk/src/opentelemetry/sdk/util/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,8 @@ def get_dict_as_key(labels):
"""Converts a dict to be used as a unique key"""
return tuple(
sorted(
map(
lambda kv: (
(kv[0], tuple(kv[1])) if isinstance(kv[1], list) else kv
),
labels.items(),
)
(kv[0], tuple(kv[1])) if isinstance(kv[1], list) else kv
for kv in labels.items()
)
)

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ select = [
"F", # pyflakes
"E", # pycodestyle errors
"W", # pycodestyle warnings
"C4", # flake8-comprehensions
"PLC", # pylint convention
"PLE", # pylint error
"Q", # flake8-quotes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ def assertIsNotChildOf(self, spanA, spanB):
self.assertNotEqual(ctxA.span_id, ctxB.span_id)

def assertNamesEqual(self, spans, names):
self.assertEqual(list(map(lambda x: x.name, spans)), names)
self.assertEqual([x.name for x in spans], names)