feat: add support for metric data-point flags#4916
feat: add support for metric data-point flags#4916herin049 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
| min: float | ||
| max: float | ||
| exemplars: Sequence[Exemplar] = field(default_factory=list) | ||
| flags: DataPointFlags = DEFAULT_DATA_POINT_FLAGS |
There was a problem hiding this comment.
I think this is why the public-symbols-check fails but it should be fine with the defined default.
There was a problem hiding this comment.
I think it is complaining because specifically the order of these fields are changing (which I've opted to do for consistency). I can move it back, but then the argument order will be inconsistent between the different data-point types. Do we want to just label this as a breaking change?
There was a problem hiding this comment.
label this as a breaking change?
I say do it!
| flags=0, | ||
| min=min_, | ||
| max=max_, | ||
| # FIXME: Find the right value for flags |
There was a problem hiding this comment.
With the new get_default, are the Fixme still needed?
There was a problem hiding this comment.
I'm not sure if there is additional work to be done here for determining what exactly the flags should be set to, so I have opted to leave the comment here.
| positive=Buckets(offset=6, bucket_counts=[7, 8]), | ||
| negative=Buckets(offset=9, bucket_counts=[10, 11]), | ||
| flags=12, | ||
| flags=DataPointFlags.get_default(), |
There was a problem hiding this comment.
We have a mixture of DataPointFlags.DEFAULT and DataPointFlags.get_default() in this file, can we consolidate onto the new version?
3 participants
Description
Adds support for metric data-point flags per the OpenTelemetry metric data model: https://opentelemetry.io/docs/specs/otel/metrics/data-model/#data-point-flags
Fixes #4726
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Relevant unit tests have been added/updated to test the added features.
Does This PR Require a Contrib Repo Change?
Checklist: