test(mysql): cover database semconv modes#4683
Open
popsiclelmlm wants to merge 1 commit into
Open
Conversation
Adds MySQL instrumentation coverage for default, stable, and duplicate database semantic convention modes. Assisted-by: ChatGPT 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds MySQL instrumentation tests for default, stable, and duplicate database semantic convention modes.
Reproduction
Issue #1632 asks to make sure MySQL instrumentation follows semantic conventions. The MySQL package delegated span attributes to the shared DB-API helpers, but the package tests did not assert the exact legacy/stable/duplicate attribute sets.
Root cause
Without MySQL-specific semconv assertions, regressions in the connection attributes passed through
MySQLInstrumentor.instrument_connection()could miss schema URL, database, user, and peer/server attribute changes.Changes
useron the MySQL connection mock so legacy/dupdb.useris verified.database,http, anddatabase/dup,http/dupmodes.Tests
.venv/bin/python -m pytest instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py -q -k semconv.venv/bin/python -m pytest instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py -q.venv/bin/python -m ruff check instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.py.venv/bin/python -m py_compile instrumentation/opentelemetry-instrumentation-mysql/tests/test_mysql_integration.pyScreenshots/Logs
Not applicable; test-only change.
Refs #1632