fix(asgi): exclude background task duration from HTTP server metrics#4656
Open
grvmishra788 wants to merge 2 commits into
Open
fix(asgi): exclude background task duration from HTTP server metrics#4656grvmishra788 wants to merge 2 commits into
grvmishra788 wants to merge 2 commits into
Conversation
herin049
approved these changes
Jun 7, 2026
Comment on lines
+714
to
+717
| for metric in metrics: | ||
| if metric.name == "http.server.duration": | ||
| data_points = list(metric.data.data_points) | ||
| for point in data_points: |
Contributor
There was a problem hiding this comment.
This logic of finding the duration data point appears to be duplicated in each of the three tests cases, could we create a small helper function to clean up these tests a bit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Duration metrics include background task execution time because the ASGI middleware measures duration in the
finallyblock, which blocks until background tasks complete.This PR captures a timestamp when the final response body is sent and uses that for duration calculation. If no response is sent, it falls back to
default_timer().Fixes #3591
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: