fix(confluent-kafka): use PUBLISH operation for producer spans#4435
Open
alliasgher wants to merge 3 commits intoopen-telemetry:mainfrom
Open
fix(confluent-kafka): use PUBLISH operation for producer spans#4435alliasgher wants to merge 3 commits intoopen-telemetry:mainfrom
alliasgher wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…ts gauge leak If wsgi_app() raises an uncaught exception, the active_requests_counter decrement at the end of _wrapped_app was never reached, causing the gauge to permanently read high. Kubernetes HPA and similar systems would see phantom load. Add a bare try/except that decrements the counter and re-raises on exception, matching the pattern already used in the WSGI instrumentation. Fixes open-telemetry#4431 Signed-off-by: alliasgher <alliasgher123@gmail.com>
Celery's Context object copies all message properties as instance attrs, including numeric fields like timelimit. CeleryGetter.get() wrapped these in a tuple but didn't convert to str, causing TextMapPropagators to crash with "TypeError: expected string or bytes-like object, got 'int'" when calling re.split() in TraceState.from_header(). Coerce non-string, non-iterable values to str before wrapping in a tuple. Fixes open-telemetry#4359 Signed-off-by: alliasgher <alliasgher123@gmail.com>
wrap_produce was setting messaging.operation=RECEIVE on producer spans. The correct OTel semantic value for a send/produce operation is PUBLISH. Fixes open-telemetry#4292 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4292.
wrap_producewas settingmessaging.operation=RECEIVEon producer spans — the correct OTel semantic value for a produce/send operation isPUBLISH.