Add __iter__ method to TracedCursorProxy#4427
Open
lrafeei wants to merge 4 commits intoopen-telemetry:mainfrom
Open
Add __iter__ method to TracedCursorProxy#4427lrafeei wants to merge 4 commits intoopen-telemetry:mainfrom
lrafeei wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Apr 14, 2026
| span = spans_list[0] | ||
| self.assertEqual(span.attributes[DB_STATEMENT], "Test query") | ||
|
|
||
| def test_executemany_iterable_cursor(self): |
Contributor
There was a problem hiding this comment.
I think pylint will warn that this can be made a staticmethod, you can add a self.assertTrue("no raise") or disable the rule for the method. You can run tox -e lint-instrumentation-dbapi locally
Author
There was a problem hiding this comment.
Thanks for the heads up. Fixed and pushed up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the upgrade to support
wraptv2.0, the inherited class forTracedCursorProxyinopentelemetry/instrumentation/dbapi/__init__.pywas changed toBaseObjectProxy. One of the changes inwraptv2.0 is that theBaseObjectProxyno longer provides a proxy implementation for the__iter__()method. The issue with this is that the DBAPI cursor is an iterable, so this breaks any potential instrumentation relying on this. As a fix, an__iter__()method is added to theTracedCursorProxyclass.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.