fix(flask): stop reading deprecated flask.__version__#4422
Open
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Open
fix(flask): stop reading deprecated flask.__version__#4422alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
alliasgher wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Flask 3.1 deprecated the module-level __version__ attribute and emits a
DeprecationWarning on access; 3.2 will remove it. The Flask
instrumentor was hitting that warning at import time via
_IS_FLASK_31_PLUS = hasattr(flask, "__version__") and
package_version.parse(flask.__version__) >= package_version.parse("3.1.0")
even though it already computes the installed Flask version via
importlib.metadata.version("flask") a few lines below. Use that
flask_version for the 3.1+ check and drop the deprecated attribute
access entirely.
Fixes open-telemetry#4402
Signed-off-by: Ali <alliasgher123@gmail.com>
Contributor
|
Thank you for this @alliasgher . Please could you run |
Signed-off-by: alliasgher <alliasgher123@gmail.com>
Author
|
Done, ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flask 3.1 deprecated the module-level
flask.__version__attribute and emits aDeprecationWarningon access; 3.2 will remove it. The Flask instrumentor was hitting that warning at import time via:even though it already computes the installed Flask version via
importlib.metadata.version("flask")a few lines below. Use thatflask_versionfor the 3.1+ check and drop the deprecated attribute access entirely.Fixes #4402
Test plan
_IS_FLASK_31_PLUS— just a different, non-deprecated source for the version string.Signed-off-by: Ali alliasgher123@gmail.com