Add log and metrics provider to langchain#4214
Conversation
instrumentation-genai/opentelemetry-instrumentation-langchain/CHANGELOG.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Production code changes are quite small and they LGTM. Kudos for thorough testing, but IMO, if they don't already, these tests should live in genai utils rather than here, as they are testing that code. For this PR, I think a spot check or even just a test that verifies the provider wiring would suffice.
edit: I'll approve this PR. Production code changes are fine from my perspective, and it has thorough integration tests -- where they should live may be a matter of personal preference.
...ntelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/__init__.py
Show resolved
Hide resolved
JWinermaSplunk
left a comment
There was a problem hiding this comment.
Looks good, though I do agree with the comment @nagkumar91 left
instrumentation-genai/opentelemetry-instrumentation-langchain/tests/test_llm_call.py
Show resolved
Hide resolved
|
Can you update the spellcheck config? https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.codespellrc |
Description
Add log and metrics provider in langchain's call to genai utils telemetry handler.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.