Skip to content

Comments

Add log and metrics provider to langchain#4214

Merged
aabmass merged 8 commits intoopen-telemetry:mainfrom
wrisa:add-logs-metrics-langchain
Feb 19, 2026
Merged

Add log and metrics provider to langchain#4214
aabmass merged 8 commits intoopen-telemetry:mainfrom
wrisa:add-logs-metrics-langchain

Conversation

@wrisa
Copy link
Contributor

@wrisa wrisa commented Feb 18, 2026

Description

Add log and metrics provider in langchain's call to genai utils telemetry handler.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@wrisa wrisa changed the title Added log and metrics provider to langchain Add log and metrics provider to langchain Feb 18, 2026
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Production code changes are quite small and they LGTM. Kudos for thorough testing, but IMO, if they don't already, these tests should live in genai utils rather than here, as they are testing that code. For this PR, I think a spot check or even just a test that verifies the provider wiring would suffice.

edit: I'll approve this PR. Production code changes are fine from my perspective, and it has thorough integration tests -- where they should live may be a matter of personal preference.

@wrisa wrisa marked this pull request as ready for review February 19, 2026 16:22
@wrisa wrisa requested a review from a team as a code owner February 19, 2026 16:22
Copy link

@JWinermaSplunk JWinermaSplunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I do agree with the comment @nagkumar91 left

@aabmass
Copy link
Member

aabmass commented Feb 19, 2026

@aabmass aabmass merged commit e8fdc53 into open-telemetry:main Feb 19, 2026
762 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.