google-genai: include thinking tokens in output token count#4206
Draft
Rima-ag wants to merge 4 commits intoopen-telemetry:mainfrom
Draft
google-genai: include thinking tokens in output token count#4206Rima-ag wants to merge 4 commits intoopen-telemetry:mainfrom
Rima-ag wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
github-actions
bot
assigned
codefromthecrypt,
karthikscale3,
lmolkova,
lzchen and
nirga
Rima-ag
changed the title
Rima-ag
changed the title
Rima-ag
force-pushed
the
thoughts-tokens
branch
from
431c67d to
2331945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Google GenAI instrumentation to include thinking tokens in the total output token count.
Previously only candidate tokens were counted in the
output_tokens, resulting in inaccurate cost estimations for models that produce separate thinking tokens.Thinking tokens are reported in GenerateContentResponseUsageMetadata.thoughts_token_count.
Fixes #3890
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.