urllib3: add support for capturing client headers #4050
+484
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herin049
approved these changes
Dec 23, 2025
| will extract ``content-type`` and ``custom_request_header`` from the request headers and add them as span attributes. | ||
| Request header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment |
Contributor
There was a problem hiding this comment.
Suggested change
| Request header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment | |
| Request header names in urllib3 are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment |
| will extract ``content-type`` and ``custom_response_header`` from the response headers and add them as span attributes. | ||
| Response header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment |
Contributor
There was a problem hiding this comment.
Suggested change
| Response header names in aiohttp are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment | |
| Response header names in urllib3 are case-insensitive. So, giving the header name as ``CUStom-Header`` in the environment |
Comment on lines
+536
to
+543
| response_headers_to_set = get_custom_header_attributes( | ||
| response.headers, | ||
| captured_response_headers, | ||
| sensitive_headers, | ||
| normalise_response_header_name, | ||
| ) | ||
| for header, value in response_headers_to_set.items(): | ||
| span.set_attribute(header, value) |
Contributor
There was a problem hiding this comment.
nit: any reason not to just do this
Suggested change
| response_headers_to_set = get_custom_header_attributes( | |
| response.headers, | |
| captured_response_headers, | |
| sensitive_headers, | |
| normalise_response_header_name, | |
| ) | |
| for header, value in response_headers_to_set.items(): | |
| span.set_attribute(header, value) | |
| span.set_attributes(get_custom_header_attributes( | |
| response.headers, | |
| captured_response_headers, | |
| sensitive_headers, | |
| normalise_response_header_name, | |
| )) |
Contributor
|
I did a little bit of digging into the urllib source and it looks like some headers are added within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to capture and sanitize custom client headers in the urllib3 instrumentation.
Refs #3962
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.