-
Notifications
You must be signed in to change notification settings - Fork 232
feat: Add support for exporting telemetry API 'platform.*' log events #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for exporting telemetry API 'platform.*' log events #2058
Conversation
296c7f2 to
0c0e36a
Compare
|
@herin049 I see your solution captures all the logs by default. Does it also fix the issue, so can you exclude the extension logs and only get function and platform logs like was the reason for the original issue? |
Yes, I can verify again by manually deploying the layer into my AWS account. The original issue is worded a bit weirdly, the original issue is that The determining factor if you receive these logs or not if whether you add |
wpessers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks regarding implementation to check out. Other than that, overall idea and approach looks good! 🚀
wpessers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some final thoughts / questions. Lmk what you think.
e1fb692 to
0364b37
Compare
|
@wpessers Updated all |
|
Thanks again for the work! Nice one! 🚀 |
Fixes issue #2054 where
platform.*telemetry API event types (except part ofplatform.report) do not get exported for logging. The implemented solution captures all logs by default, and simplifies the current implementation by reusing the core log record construction logic while reducing code duplication.I have setup a toy lambda function to export logs to Grafana Cloud with the changes in this PR, here are the updated logs:
