Skip to content

Ratpack library instrumentation: rename three methods #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
trask wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ratpack library instrumentation: rename three methods #16013

trask wants to merge 1 commit into from
+45 −15

Conversation

@trask
Copy link
Member

@trask trask commented Jan 27, 2026 •
edited
Loading

Rename

  • getHandler() -> createHandler()
  • getExecInterceptor() -> createExecInterceptor()
  • getExecInitializer() -> createExecInitializer()

@trask trask mentioned this pull request Jan 27, 2026
Open
40 tasks
laurit
laurit reviewed Jan 27, 2026
View reviewed changes
...rary/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/RatpackServerTelemetry.java Outdated

/** Returns {@link ExecInterceptor} instance to support Ratpack Registry binding. */
public ExecInterceptor getExecInterceptor() {
public static ExecInterceptor getExecInterceptor() {
Copy link
Contributor

@laurit laurit Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a binary incompatible change, is that ok?

Copy link
Member Author

@trask trask Jan 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's not ideal to not have deprecation cycle, but we don't make any guarantees about non-stable artifacts

that said, I don't love these method names, I have now renamed them to createExec*, since they're stateless empty objects anyways and so having a single shared instance isn't important

Copy link
Contributor

@laurit laurit Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether leaving these as non-static would look nicer. It could help if we needed to change them to non-singletons and configure them in some way.

@trask trask force-pushed the ratpack branch 2 times, most recently from 9f8bba2 to a5133a7 Compare January 27, 2026 20:14
@trask trask marked this pull request as ready for review January 27, 2026 20:19
@trask trask requested a review from a team as a code owner January 27, 2026 20:19
@trask trask changed the title Ratpack library instrumentation: rename getHandler to createHandler Ratpack library instrumentation: rename three methods Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trask @laurit