JDBC pekko and servlet metadata #15967
Merged
+530
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
commented
Jan 22, 2026
| private static final String TMP_DIR = ".telemetry"; | ||
| private static final Pattern MODULE_PATTERN = | ||
| Pattern.compile("(.*?/instrumentation/.*?)(/javaagent|/library|/testing)"); | ||
| Pattern.compile("(.*?/instrumentation/.*)(/javaagent|/library|/testing|/.*?-testing)"); |
Member
Author
There was a problem hiding this comment.
this change is to support servlet:servlet-5.0:jetty12-testing:test
jaydeluca
commented
Jan 22, 2026
| List.of( | ||
| "asdf", | ||
| "x-test-", | ||
| "test-parameter", |
Member
Author
There was a problem hiding this comment.
to filter out servlet.request.parameter.test-parameter from servlet test telemetry
laurit
reviewed
Jan 28, 2026
docs/instrumentation-list.yaml
Outdated
| type: list | ||
| default: '' | ||
| - name: otel.instrumentation.servlet.add-trace-id-request-attribute | ||
| description: Adds the trace ID as a request attribute for downstream servlet |
laurit
approved these changes
Jan 28, 2026
…mentation into jdbc-servlet-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14096