Convert lettuce to use instrumenter by steverao · Pull Request #15838 · open-telemetry/opentelemetry-java-instrumentation

steverao · 2026-01-12T05:55:27Z

Resolved #15703

…tation

…uest

# Conflicts: # instrumentation/lettuce/lettuce-5.1/library/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/LettuceTelemetry.java # instrumentation/lettuce/lettuce-5.1/library/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/LettuceTelemetryBuilder.java # instrumentation/lettuce/lettuce-5.1/library/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/OpenTelemetryTracing.java

…thod

trask · 2026-02-14T22:12:30Z

hey @steverao! I sent steverao#12 with a couple of suggestions

* Consolidate LettuceServerAttributesGetter into LettuceDbAttributesGetter DbClientAttributesGetter extends ServerAttributesGetter, so DbClientAttributesExtractor already handles server attributes internally. Remove the separate LettuceServerAttributesGetter and ServerAttributesExtractor to match the canonical pattern used by other DB instrumentations (Jedis, etc.). * Prevent double-ending of span in finish() Null out context after instrumenter.end() to guard against both the onComplete callback and Lettuce's direct finish() call executing. Add comment explaining error lifecycle when start() was not called.

steverao · 2026-02-20T11:48:07Z

Please take a look again! @open-telemetry/java-instrumentation-approvers

…use-instrumenter

…use-instrumenter # Conflicts: # instrumentation/lettuce/lettuce-5.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_1/LettuceReactiveClientTest.java # instrumentation/lettuce/lettuce-5.1/testing/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceAsyncClientTest.java # instrumentation/lettuce/lettuce-5.1/testing/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceReactiveClientTest.java # instrumentation/lettuce/lettuce-5.1/testing/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientAuthTest.java # instrumentation/lettuce/lettuce-5.1/testing/src/main/java/io/opentelemetry/instrumentation/lettuce/v5_1/AbstractLettuceSyncClientTest.java

steverao force-pushed the convert-lettuce-to-use-instrumenter branch from 2d37785 to 429eeed Compare January 13, 2026 14:59

steverao marked this pull request as ready for review January 13, 2026 15:00

steverao requested a review from a team as a code owner January 13, 2026 15:00

trask and others added 4 commits January 13, 2026 23:14

Convert lettuce-5.1 to use Instrumenter

dd408ae

Add support for OpenTelemetry semconv attributes in Lettuce instrumen…

9bbabd0

…tation

fix: remove unnecessary blank line in build.gradle.kts

850a25d

Add buffered error

4a353bb

steverao force-pushed the convert-lettuce-to-use-instrumenter branch from 287e8bd to 4a353bb Compare January 13, 2026 15:21

laurit reviewed Jan 22, 2026

View reviewed changes

Comment thread instrumentation/lettuce/lettuce-5.1/library/build.gradle.kts Outdated

steverao added 2 commits January 22, 2026 22:22

fix: remove deprecated DbIncubatingAttributes and clean up LettuceReq…

7e169e0

…uest

Merge branch 'main' into convert-lettuce-to-use-instrumenter

9b930f3