Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/doxygen-tidy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: doxygen-tidy

on:
push:
branches: [main]
pull_request:
branches: [main]

permissions:
contents: read

jobs:
doxygen-lint:
name: Doxygen lint
runs-on: ubuntu-latest
env:
DOXYFILE_FOLDER: 'docs/public'
DOXYFILE_NAME: 'Doxyfile.lint'
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Install doxygen
run: |
sudo apt-get update
sudo apt-get install -y doxygen
echo "Installed Doxygen version: $(doxygen --version)"
- name: Analyze Doxygen comments
working-directory: ${{ env.DOXYFILE_FOLDER }}
run: |
mkdir /tmp/doxyoutput
doxygen ${{ env.DOXYFILE_NAME }}
- name: Check for Doxygen warnings
working-directory: ${{ env.DOXYFILE_FOLDER }}
run: |
if [ -s doxygen_warnings.log ]; then
echo "Doxygen warnings found:"
cat doxygen_warnings.log
exit 1
else
echo "No Doxygen warnings found."
fi
8 changes: 4 additions & 4 deletions api/include/opentelemetry/logs/logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,10 @@ class Logger
/**
* Log an event
*
* @severity severity of the log
* @event_id event identifier of the log
* @format an utf-8 string following https://messagetemplates.org/
* @attributes key value pairs of the log
* @param severity severity of the log
* @param event_id event identifier of the log
* @param format an utf-8 string following https://messagetemplates.org/
* @param attributes key value pairs of the log
*/
virtual void Log(Severity severity,
const EventId &event_id,
Expand Down
2 changes: 1 addition & 1 deletion docs/public/Doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ FILTER_SOURCE_PATTERNS =
# (index.html). This can be useful if you have a project on for instance GitHub
# and want to reuse the introduction page also for the doxygen output.

USE_MDFILE_AS_MAINPAGE = ./Overview.md
USE_MDFILE_AS_MAINPAGE =

#---------------------------------------------------------------------------
# Configuration options related to source browsing
Expand Down
12 changes: 12 additions & 0 deletions docs/public/Doxyfile.lint
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
@INCLUDE = Doxyfile

OUTPUT_DIRECTORY = /tmp

WARNINGS = YES
WARN_IF_UNDOCUMENTED = NO
WARN_IF_DOC_ERROR = YES
WARN_IF_INCOMPLETE_DOC = YES
WARN_NO_PARAMDOC = YES
WARN_AS_ERROR = NO
WARN_LOGFILE = doxygen_warnings.log
QUIET = YES
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class BatchLogRecordProcessor : public LogRecordProcessor
* any time
*
* @param notify_force_flush Sequence to indicate whether to notify force flush completion.
* @param exporter The log exporter instance that handles exporting logs to the backend.
* @param synchronization_data Synchronization data to be notified.
*/
static void NotifyCompletion(uint64_t notify_force_flush,
Expand Down
1 change: 1 addition & 0 deletions sdk/include/opentelemetry/sdk/logs/logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class Logger final : public opentelemetry::logs::Logger
* Initialize a new logger.
* @param name The name of this logger instance
* @param context The logger provider that owns this logger.
* @param instrumentation_scope The instrumentation scope for this logger.
*/
explicit Logger(
opentelemetry::nostd::string_view name,
Expand Down
3 changes: 3 additions & 0 deletions sdk/include/opentelemetry/sdk/logs/logger_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ class OPENTELEMETRY_EXPORT LoggerProvider final : public opentelemetry::logs::Lo
* @param processor The log record processor for this logger provider. This must
* not be a nullptr.
* @param resource The resources for this logger provider.
* @param logger_configurator The scope configurator used to determine the configs for loggers
* created using this logger provider.
*/
explicit LoggerProvider(
std::unique_ptr<LogRecordProcessor> &&processor,
Expand Down Expand Up @@ -87,6 +89,7 @@ class OPENTELEMETRY_EXPORT LoggerProvider final : public opentelemetry::logs::Lo
* @param library_name The version of the library.
* @param library_version The version of the library.
* @param schema_url The schema URL.
* @param attributes The attributes to be associated with the logger.
*/
nostd::shared_ptr<opentelemetry::logs::Logger> GetLogger(
nostd::string_view logger_name,
Expand Down
4 changes: 4 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/meter_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ class MeterContext : public std::enable_shared_from_this<MeterContext>
* Initialize a new meter provider
* @param views The views to be configured with meter context.
* @param resource The resource for this meter context.
* @param meter_configurator A scope configurator defining the behavior of a meter associated with
* this meter context.
*/
MeterContext(
std::unique_ptr<ViewRegistry> views = std::unique_ptr<ViewRegistry>(new ViewRegistry()),
Expand Down Expand Up @@ -128,6 +130,8 @@ class MeterContext : public std::enable_shared_from_this<MeterContext>

/**
* Attaches a View to list of configured Views for this Meter context.
* @param instrument_selector The instrument selector for this view.
* @param meter_selector The meter selector for this view.
* @param view The Views for this meter context. This
* must not be a nullptr.
*
Expand Down
2 changes: 2 additions & 0 deletions sdk/include/opentelemetry/sdk/metrics/meter_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ class OPENTELEMETRY_EXPORT MeterProvider final : public opentelemetry::metrics::

/**
* Attaches a View to list of configured Views for this Meter provider.
* @param instrument_selector The instrument selector for this view.
* @param meter_selector The meter selector for this view.
* @param view The Views for this meter provider. This
* must not be a nullptr.
*
Expand Down
3 changes: 2 additions & 1 deletion sdk/include/opentelemetry/sdk/resource/resource.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class Resource
*
* The specification notes that if schema urls collide, the resulting
* schema url is implementation-defined. In the C++ implementation, the
* schema url of @param other is picked.
* schema url of @p other is picked.
*
* @param other the Resource that will be merged with this.
* @returns the newly merged Resource.
Expand All @@ -50,6 +50,7 @@ class Resource
* Returns a newly created Resource with the specified attributes.
* It adds (merge) SDK attributes and OTEL attributes before returning.
* @param attributes for this resource
* @param schema_url The schema URL for this resource.
* @returns the newly created Resource.
*/

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ class BatchSpanProcessor : public SpanProcessor
* any time
*
* @param notify_force_flush Sequence to indicate whether to notify force flush completion.
* @param exporter The span exporter instance that handles exporting spans to the backend.
* @param synchronization_data Synchronization data to be notified.
*/
static void NotifyCompletion(uint64_t notify_force_flush,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace trace

/**
* Factory class for TracerProvider.
* See @ref TracerProvider.
* See @ref opentelemetry::trace::TracerProvider
*/
class OPENTELEMETRY_EXPORT TracerProviderFactory
{
Expand Down
Loading