Fix: Prevent 409 conflicts in Playwright pagination tests on retry#26480
Open
Fix: Prevent 409 conflicts in Playwright pagination tests on retry#26480
Conversation
Code Review ✅ ApprovedPrevents 409 conflicts in Playwright pagination tests on retry by addressing the underlying race condition. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
|
Contributor
🟡 Playwright Results — all passed (28 flaky)✅ 3314 passed · ❌ 0 failed · 🟡 28 flaky · ⏭️ 183 skipped
🟡 28 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Playwright tests were failing with 409 Conflict on retry because entity classes (DatabaseClass, DriveServiceClass, etc.) were instantiated at module level. When Playwright retries a failed beforeAll, the module is already cached — the same instance with the same UUID is reused, causing the POST to fail on an already-existing entity.
Moved all entity class instantiations inside beforeAll so a fresh instance (with a new UUID) is created on every run/retry
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>