Skip to content

Conversation

@dhruvjsx
Copy link
Contributor

@dhruvjsx dhruvjsx commented Jan 27, 2026

Describe your changes:

Screenshot 2026-01-27 at 4 06 13 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test synchronization improvements:
    • Added explicit waitFor({ state: 'visible' }) for owner-select-teams-search-bar in DataAssetRulesDisabled.spec.ts
    • Enhanced assignGlossaryTerm utility to await PATCH API responses before continuing test execution
  • Enhanced utility functions:
    • Added optional entityEndpoint parameter to assignGlossaryTerm in utils/entity.ts for API synchronization
    • Updated all call sites across 5 test files to pass entity endpoint context
  • Defensive null handling:
    • Added fallback in getUserDisplayName() to return name when displayName is undefined
    • Added filter for undefined owner names in addMultiOwner function
  • Improved visibility checks:
    • Refactored fillTextInputDetails with try-catch for more reliable element visibility detection

This will update automatically on new commits.


@github-actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link

gitar-bot bot commented Jan 27, 2026

Rules 🎸 1 action taken

Gitar Rules

🎸 Summary Enhancement: PR description had unfilled template placeholders; added 4-category technical summary

2 rules not applicable. Show all rules by commenting gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.81% (55588/84462) 44.82% (28657/63945) 47.72% (8734/18301)

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant