-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(test): right entity panel spec failure #25547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/RightEntityPanelFlow.spec.ts
Outdated
Show resolved
Hide resolved
Code Review ✅ Approved 1 resolved / 1 findingsWell-structured test refactoring that improves isolation by creating fresh test entities per test. The hardcoded timeout from the previous review has been removed. ✅ 1 resolved✅ Quality: Hardcoded timeout is fragile for CI/CD environments
Rules ✅ All requirements metGitar Rules
2 rules not applicable. Show all rules by commenting OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
Failed to cherry-pick changes to the 1.11.7 branch. |
* fix(test): right entity panel spec failure * fix token issue for table creation * remove hardcoded timeout (cherry picked from commit 34a7f5e)



This pull request refactors the
RightEntityPanelFlow.spec.tsPlaywright test to improve test isolation and reliability by creating and cleaning up the main test entity (adminTestEntity) within each test case, rather than sharing it across all tests. It also updates references to use the correct property for the entity name and introduces some minor utility improvements.Test entity lifecycle management:
adminTestEntityfrom a shared instance to being created in each test'sbeforeEachand deleted inafterEach, ensuring a clean environment for every test run. [1] [2] [3] [4]Test reliability and correctness:
adminTestEntity.entity.nametoadminTestEntity.entityResponseData.nameto use the correct property for entity navigation, preventing potential test failures due to stale or incorrect data. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Utility improvements:
redirectToHomePageto the imports and used it in navigation steps to ensure the browser is in a consistent state before and after each test. [1] [2]These changes make the test suite more robust, maintainable, and less prone to side effects from shared state.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>