Skip to content

Conversation

@karanh37
Copy link
Contributor

@karanh37 karanh37 commented Jan 27, 2026

Summary

  • Fixed the should select multiple columns and bulk edit test in ColumnBulkOperations.spec.ts to target only non-collapsible row checkboxes using tbody tr:not(:has(button.expand-button)), avoiding accidental clicks on aggregate/expandable parent rows
  • Fixed flaky glossary rename test in Glossary.spec.ts by adding waitForLoadState('networkidle') after save to allow sidebar refresh requests to complete before asserting the updated name

Test plan

  • Run ColumnBulkOperations.spec.ts multi-select test and verify it selects only single-occurrence columns
  • Run Glossary.spec.ts rename test and verify it no longer flakes on name assertion

🤖 Generated with Claude Code


Summary by Gitar

  • Test refactoring:
    • Moved visitColumnBulkOperationsPage calls to beforeEach hooks across multiple test describe blocks in ColumnBulkOperations.spec.ts
    • Reduces redundant page navigation and improves test execution efficiency
  • Test flakiness fixes:
    • Non-collapsible row selector prevents accidental selection of expandable parent rows
    • Network idle wait ensures glossary sidebar updates complete before assertions

This will update automatically on new commits.


- Select only non-collapsible row checkboxes in multi-select test to
  avoid clicking aggregate/expandable parent rows
- Add networkidle wait after glossary rename to handle sidebar refresh
  requests before asserting updated name

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.8% (55633/84546) 44.84% (28707/64015) 47.68% (8740/18329)

Rohit0301
Rohit0301 previously approved these changes Jan 27, 2026
@gitar-bot
Copy link

gitar-bot bot commented Jan 27, 2026

🔍 CI failure analysis for e17bcb0: Shard 6/6 failed with 1 test in Users.spec.ts (unrelated to PR changes). Shards 1 and 5 passed. Shards 2, 3, 4 still pending.

Issue

The playwright-ci-postgresql (6, 6) shard failed with 1 test failure in Users.spec.ts. This failure is unrelated to the PR changes.

Root Cause

Failed test: Users.spec.ts:255 - "User should be visible in right panel on table page when added as custom property"

Error:

Error: expect(locator).toHaveText(expected) failed
Locator: getByTestId('user-display-name')
Expected: "Boldc076c7edZebra5f6f6822"
Error: element(s) not found

The test expected to find a user display name element with specific text, but the element was not present on the page. This indicates a timing or data setup issue in the test.

Why this is unrelated to the PR:

  1. Different file: The PR only modifies ColumnBulkOperations.spec.ts and Glossary.spec.ts, not Users.spec.ts
  2. Different feature: User custom properties vs. column bulk operations and glossary functionality
  3. No logical connection: The PR's changes (checkbox selectors with :not(:has(button.expand-button)), beforeEach refactoring, and network idle waits) do not affect user management UI or custom property assignment
  4. High success rate: 526 out of 527 tests passed in this shard (99.8%)
  5. Other shards successful: Shards 1 and 5 passed completely with the same code changes

Details

Details

PR changes:

  • ColumnBulkOperations.spec.ts: Fixed checkbox selector to target non-collapsible rows + moved page navigation to beforeEach hooks
  • Glossary.spec.ts: Added waitForLoadState('networkidle') after rename operation

Evidence this is a flaky test:

  1. Element not found: The user-display-name element wasn't rendered, suggesting a timing or data issue
  2. Timing-dependent: User assignment to custom properties involves async operations that may not have completed
  3. Shard-specific: Only shard 6 failed; shards 1 and 5 passed with identical code
  4. No code path overlap: PR's selector and wait changes cannot affect user profile rendering

Shard status:

  • Shard 1: ✅ PASS
  • Shard 2: ⏳ PENDING
  • Shard 3: ⏳ PENDING
  • Shard 4: ⏳ PENDING
  • Shard 5: ✅ PASS
  • Shard 6: ❌ FAIL (1 test, unrelated file)
Code Review ✅ Approved

Well-structured test refactoring that consolidates page navigation into beforeEach hooks and fixes flaky tests with improved selectors and proper waits. The changes follow Playwright best practices and reduce code duplication.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants