-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix Playwright tests for column bulk operations and glossary spec #25546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Select only non-collapsible row checkboxes in multi-select test to avoid clicking aggregate/expandable parent rows - Add networkidle wait after glossary rename to handle sidebar refresh requests before asserting updated name Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🔍 CI failure analysis for e17bcb0: Shard 6/6 failed with 1 test in Users.spec.ts (unrelated to PR changes). Shards 1 and 5 passed. Shards 2, 3, 4 still pending.IssueThe Root CauseFailed test: Error: The test expected to find a user display name element with specific text, but the element was not present on the page. This indicates a timing or data setup issue in the test. Why this is unrelated to the PR:
DetailsDetailsPR changes:
Evidence this is a flaky test:
Shard status:
Code Review ✅ ApprovedWell-structured test refactoring that consolidates page navigation into beforeEach hooks and fixes flaky tests with improved selectors and proper waits. The changes follow Playwright best practices and reduce code duplication. Tip Comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Summary
should select multiple columns and bulk edittest inColumnBulkOperations.spec.tsto target only non-collapsible row checkboxes usingtbody tr:not(:has(button.expand-button)), avoiding accidental clicks on aggregate/expandable parent rowsGlossary.spec.tsby addingwaitForLoadState('networkidle')after save to allow sidebar refresh requests to complete before asserting the updated nameTest plan
ColumnBulkOperations.spec.tsmulti-select test and verify it selects only single-occurrence columnsGlossary.spec.tsrename test and verify it no longer flakes on name assertion🤖 Generated with Claude Code
Summary by Gitar
visitColumnBulkOperationsPagecalls tobeforeEachhooks across multiple test describe blocks inColumnBulkOperations.spec.tsThis will update automatically on new commits.