Fix: Removed the .keyword suffix for the JSONLogic query builder
#25514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
safe to test
aniketkatkar97
added
the
To release
ShaileshParmar11
previously approved these changes
Jan 25, 2026
Contributor
Jest test CoverageUI tests summary
|
anuj-kumary
previously approved these changes
Jan 25, 2026
|
openmetadata-ui/src/main/resources/ui/playwright/utils/customProperty.ts
Show resolved
Hide resolved
ShaileshParmar11
approved these changes
Jan 26, 2026
Member
Author
|
Failures are unrelated and will be taken care of in #25459 |
Contributor
|
Failed to cherry-pick changes to the 1.11.7 branch. |
aniketkatkar97
added a commit
that referenced
this pull request
Jan 26, 2026
* Removed the keyword suffix for the jsonlogic * Fix the Entity Ref custom property test flakiness * Fix custom property failures and flakiness --------- Co-authored-by: Anujkumar Yadav <anujf0510@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the advanced search functionality by allowing the custom property subfield generation logic to adapt based on a new
searchOutputTypeparameter. This enables more flexible handling of search field keys depending on the search backend (such as ElasticSearch or JSONLogic). The changes also include comprehensive updates to unit tests to ensure correct propagation and handling of the new parameter.Key changes include:
Advanced Search Logic Enhancements
getCustomPropertiesSubFieldsinAdvancedSearchClassBaseto accept asearchOutputTypeparameter, adjusting subfield key generation logic based on whether ElasticSearch or JSONLogic is used.processCustomPropertyFieldandprocessEntityTypeFieldsto accept and pass through thesearchOutputTypeparameter, ensuring consistent behavior throughout the advanced search utilities. [1] [2] [3] [4]Type and Import Updates
SearchOutputTypeenum to relevant imports for proper type-checking and usage across the codebase. [1] [2]Testing Improvements
AdvancedSearchUtils.test.tsxto verify that thesearchOutputTypeparameter is correctly passed and handled in bothprocessCustomPropertyFieldandprocessEntityTypeFields, covering ElasticSearch, JSONLogic, and undefined cases. [1] [2]These updates make the advanced search system more robust and adaptable to different search backends, while ensuring correctness through improved testing.