Chore(UI): Fix service form certificate file name overflow issue #24790
+185
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
safe to test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix an overflow issue when uploading certificate files with long names in service forms. The fix adds CSS width constraints to the password widget component to prevent UI overflow. However, the PR also includes unrelated code formatting changes in DomainUtils.tsx and has a critical issue in the new E2E test where an extremely long certificate string is used as a filename, which could cause filesystem errors.
Key Changes:
- CSS fix: Added
width: 100%to.password-widgetclass andm-t-smmargin to Radio.Group - New E2E test: Added test coverage for SSL certificate upload functionality
- Unrelated: Code formatting improvements in DomainUtils.tsx
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/password-widget.less | Added width: 100% to password-widget class to constrain width and prevent overflow |
| openmetadata-ui/src/main/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/PasswordWidget.tsx | Added m-t-sm margin class to Radio.Group for better spacing |
| openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/ServiceForm.spec.ts | Added E2E test for SSL certificate upload, but uses CERT_FILE constant as filename (critical bug) |
| openmetadata-ui/src/main/resources/ui/playwright/constant/serviceForm.ts | Added CERT_FILE constant with mock certificate data (very long string) |
| openmetadata-ui/src/main/resources/ui/src/utils/DomainUtils.tsx | Unrelated formatting changes: updated copyright year and reformatted long lines for readability |
openmetadata-ui/src/main/resources/ui/playwright/constant/serviceForm.ts
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/ServiceForm.spec.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/ServiceForm.spec.ts
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/ServiceForm.spec.ts
Outdated
Show resolved
Hide resolved
aniketkatkar97
had a problem deploying
to
test
GitHub Actions
Failure
aniketkatkar97
added
the
To release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the overflow issue while uploading a certification file with a long name.
Before:
Screen.Recording.2025-12-11.at.10.34.40.AM.mov
After:
Screen.Recording.2025-12-11.at.10.35.07.AM.mov