Skip to content

implement segregation of duties policy with detailed roles.#9

Closed
patel-lyzr wants to merge 1 commit intoopen-gitagent:mainfrom
patel-lyzr:feat/segregation-of-duties
Closed

implement segregation of duties policy with detailed roles.#9
patel-lyzr wants to merge 1 commit intoopen-gitagent:mainfrom
patel-lyzr:feat/segregation-of-duties

Conversation

@patel-lyzr
Copy link
Contributor

No description provided.

@shreyas-lyzr
Copy link
Contributor

Hey @patel-lyzr — this is a really solid piece of work. The segregation of duties concept is well thought out, the schema design is clean, and the validator logic is thorough. Appreciate the effort here.

A few things before we can merge, per our CONTRIBUTING.md:

1. Needs an issue first
This introduces a new spec-level concept (DUTIES.md, segregation_of_duties schema, validation rules). Our contributing guide asks that spec changes go through an issue first so we can discuss the design before jumping to code. Can you open one retroactively? Just describe the problem it solves and the approach you took.

2. PR description is empty
Please fill in the PR template — what does this do, why, and how did you test it? Did you run npm run build? Did you test gitagent validate and gitagent audit against the updated examples/full/ agent?

3. Consider splitting this up
This PR touches 13 files across spec, schema, adapters, CLI commands, examples, and README. That's a lot to review in one pass. Ideally:

  • PR 1: Spec + schema + types (SPECIFICATION.md, agent-yaml.schema.json, loader.ts)
  • PR 2: CLI support (validate.ts, audit.ts, init.ts)
  • PR 3: Adapter support (claude-code.ts, system-prompt.ts)
  • PR 4: Examples + docs (examples/full/, README.md)

Totally understand if that feels like overkill — at minimum, separating the spec change from the implementation would help.

4. Commit prefix
The commit says docs: but this is a feature — should be feat: implement segregation of duties.

5. Build check
Can you confirm npm run build passes cleanly with these changes?

None of this is blocking in spirit — the implementation looks good. Just want to make sure we follow the process so it's clean for everyone. Let me know if you have questions.

@patel-lyzr
Copy link
Contributor Author

Hey @shreyas-lyzr — thanks for the thorough review! All great points. Here's what I've done:

1. Issue created: #10 — describes the problem, approach, and all affected files.

2. PR split into 4 focused PRs (stacked):

Each PR has a filled-in description with what it does, why, and test plan.

3. Commit prefix fixed from docs: to feat: across all 4 PRs.

4. Build passes cleanly on all branches — npm run build

Closing this PR in favor of the split stack. Merging #11#12#13#14 in order should give a clean review flow.

@patel-lyzr patel-lyzr closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants