implement segregation of duties policy with detailed roles.#9
implement segregation of duties policy with detailed roles.#9patel-lyzr wants to merge 1 commit intoopen-gitagent:mainfrom
Conversation
|
Hey @patel-lyzr — this is a really solid piece of work. The segregation of duties concept is well thought out, the schema design is clean, and the validator logic is thorough. Appreciate the effort here. A few things before we can merge, per our CONTRIBUTING.md: 1. Needs an issue first 2. PR description is empty 3. Consider splitting this up
Totally understand if that feels like overkill — at minimum, separating the spec change from the implementation would help. 4. Commit prefix 5. Build check None of this is blocking in spirit — the implementation looks good. Just want to make sure we follow the process so it's clean for everyone. Let me know if you have questions. |
|
Hey @shreyas-lyzr — thanks for the thorough review! All great points. Here's what I've done: 1. Issue created: #10 — describes the problem, approach, and all affected files. 2. PR split into 4 focused PRs (stacked):
Each PR has a filled-in description with what it does, why, and test plan. 3. Commit prefix fixed from 4. Build passes cleanly on all branches — Closing this PR in favor of the split stack. Merging #11 → #12 → #13 → #14 in order should give a clean review flow. |
No description provided.