-
Notifications
You must be signed in to change notification settings - Fork 7
Add Python SWIG bindings (#ifdef SWIGPYTHON) #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lauris71
merged 2 commits into
open-eid:master
from
namespace-ee:feature/python-swig-bindings
Feb 17, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there functions where exception is explicitly thrown?
We tried to keep API exception free to simplify binding generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate that the public API is designed to be exception-free using result_t codes — the noexcept try-catch patterns in Io.h and Crypto.cpp confirm that intent.
The %exception block is a defensive safety net rather than a primary error path. Without it, if any C++ exception escapes to Python it would call std::terminate() and abort the entire Python process. With the block, it becomes a catchable RuntimeError instead.
Cases where exceptions could still propagate despite the exception-free API design:
It has zero runtime cost in the normal (no-exception) path — just a try/catch frame. Happy to remove it if you prefer to keep the SWIG interface minimal, but it's standard practice for Python bindings as a crash-prevention measure.