fix: stop restarting processes when killOthers is triggered #579
+5,361
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --kill-others with --restart-tries, processes that were killed by killOthers would be incorrectly restarted. This happened because RestartProcess was unaware that the abort signal had been triggered. This fix passes the abort signal to RestartProcess, which uses takeUntil to stop all restart attempts once abort is signaled. Fixes open-cli-tools#496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #496
When using
--kill-otherswith--restart-tries, processes that were killed bykillOtherswould be incorrectly restarted. This happened becauseRestartProcesswas unaware that the abort signal had been triggered.Changes
RestartProcesstakeUntil(abort$)to stop all restart attempts once abort is signaledTesting
All existing tests pass, plus a new test that verifies:
This is a minimal, targeted fix that follows the maintainer's suggestion in #496 to use
takeUntiloperator.