Update readme usage instructions for quotes#509
Open
victorhcb wants to merge 2 commits intoopen-cli-tools:mainfrom
Open
Update readme usage instructions for quotes#509victorhcb wants to merge 2 commits intoopen-cli-tools:mainfrom
victorhcb wants to merge 2 commits intoopen-cli-tools:mainfrom
Conversation
gustavohenke
reviewed
Nov 4, 2024
Member
gustavohenke
left a comment
There was a problem hiding this comment.
Hey. I'm not sure if it's relevant to highlight it like that, as it's not concurrently specific, but rather how the shell parses inputs.
If we want to be thorough with the recommendations, then I'd argue that someone blindly changing their commands from single to double quotes could also face unintended side effects if they look like they have an env variable, e.g.
$ conc 'echo $foo'
[0]
[0] echo $foo exited with code 0
$ conc "echo $foo"
[0]
[0] echo exited with code 0
May I suggest that maybe we change the note to say that the user should pick the right quotes for their use case?
Can highlight how Windows will only work with double ones, and that env vars in unix might be parsed eagerly depending on the style.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This discussion came up in a Brazilian project (TabNews) when a Pull Request revealed a compatibility issue with Windows due to the use of single quotes.
The idea of this PR is to make it clear in the documentation that using double quotes is the way to go if you want to avoid compatibility problems across different operating systems.
It’s a small change, but it could save users from wasting minutes—or even hours—trying to figure out what went wrong!