Added check to avoid debounce altogether if unnecessary#52
Closed
lossanarch wants to merge 1 commit intoopen-cli-tools:masterfrom
Closed
Added check to avoid debounce altogether if unnecessary#52lossanarch wants to merge 1 commit intoopen-cli-tools:masterfrom
lossanarch wants to merge 1 commit intoopen-cli-tools:masterfrom
Conversation
This was referenced Mar 7, 2018
Contributor
|
Can you rebase this? |
Contributor
|
I think this is effectively resolved in #90, which has been merged. This PR can probably be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even when setting -d 0 the command execution is still debounced enough that filesystem move events do not fire commands correctly (on MacOS 10.13.3) - a move will register an unlink and an add, but only fires the command for the add:
With
-c echo {path} {event}:mv test test1This PR fixes the problem by checking if debounce is required at all (based on a non-zero debounce time) and if not required, launches the command with only throttling. This results in what I assume is the correct behaviour:
With
-c echo {path} {event}:mv test test1I hope this is helpful and many thanks for this project.