Skip to content

Conversation

@oowl
Copy link
Owner

@oowl oowl commented Dec 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 15:09
@oowl oowl closed this Dec 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Cargo.toml configuration by removing the "luajit" feature from the base mlua dependency, making it truly optional. This ensures that luajit is only enabled when users explicitly request it via --features luajit, aligning with the feature flag definition in the [features] section.

Key Changes:

  • Removed "luajit" from the default mlua dependency features, retaining only "module"
  • The luajit feature flag in [features] section remains intact for opt-in usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


[dependencies]
mlua = { version = "0.9.9", features = ["luajit", "module"] }
mlua = { version = "0.9.9", features = [ "module"] }
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space before "module" in the features array. The spacing should be consistent with the formatting of other dependencies in the file.

Suggested change
mlua = { version = "0.9.9", features = [ "module"] }
mlua = { version = "0.9.9", features = ["module"] }

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants