Skip to content

fix race conditions #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holyfuchs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix race conditions #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,15 @@ func (c *Config) Validate() error {
return nil
}

// Default returns the default configuration.
// Default returns a *copy* of the default configuration.
func Default() *Config {
return &Config{
Emulators: DefaultEmulators,
Networks: DefaultNetworks,
cfg := &Config{
Emulators: make(Emulators, len(DefaultEmulators)),
Networks: make(Networks, len(DefaultNetworks)),
}
copy(cfg.Emulators, DefaultEmulators)
copy(cfg.Networks, DefaultNetworks)
return cfg
}

var ErrOutdatedFormat = errors.New("you are using old configuration format")
Expand Down
2 changes: 2 additions & 0 deletions output/spinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ func (s *Spinner) run() {
spinnerCharset[i%len(spinnerCharset)],
s.suffix,
)
mu.Lock()
_ = writer.Flush()
mu.Unlock()
i++
}
}
Expand Down
Loading