Interest Rate Boundary Conditions Testing#262
Open
UlyanaAndrukhiv wants to merge 20 commits intomainfrom
Open
Conversation
…/FlowCreditMarket into UlianaAndrukhiv/180-interest-rate-testing
holyfuchs
approved these changes
Mar 16, 2026
# Conflicts: # cadence/tests/insurance_collection_test.cdc # cadence/tests/interest_accrual_integration_test.cdc
…m:onflow/FlowCreditMarket into UlianaAndrukhiv/180-interest-rate-testing
mts1715
reviewed
Mar 30, 2026
|
|
||
| createPosition(admin: MAINNET_PROTOCOL_ACCOUNT, signer: MAINNET_FLOW_HOLDER, amount: FLOWAmount, vaultStoragePath: FLOW_VAULT_STORAGE_PATH, pushToDrawDownSink: false) | ||
| var openEvents = Test.eventsOfType(Type<FlowALPEvents.Opened>()) | ||
| let lpDepositPid = (openEvents[openEvents.length - 1] as! FlowALPEvents.Opened).pid |
Contributor
There was a problem hiding this comment.
use getLastPositionId() instead from test_helper.cdc
and same in tests below
mts1715
reviewed
Mar 30, 2026
|
|
||
| // attempt to borrow FLOW (no reserves) | ||
| let openEvents = Test.eventsOfType(Type<FlowALPEvents.Opened>()) | ||
| let pid = (openEvents[openEvents.length - 1] as! FlowALPEvents.Opened).pid |
Contributor
There was a problem hiding this comment.
mts1715
reviewed
Mar 30, 2026
| createPosition(admin: MAINNET_PROTOCOL_ACCOUNT, signer: flowLp, amount: FLOWAmount, vaultStoragePath: FLOW_VAULT_STORAGE_PATH, pushToDrawDownSink: false) | ||
|
|
||
| let openEvents = Test.eventsOfType(Type<FlowALPEvents.Opened>()) | ||
| let lpPid = (openEvents[openEvents.length - 1] as! FlowALPEvents.Opened).pid |
Contributor
There was a problem hiding this comment.
mts1715
reviewed
Mar 30, 2026
|
|
||
| createPosition(admin: MAINNET_PROTOCOL_ACCOUNT, signer: borrower, amount: 10_000.0, vaultStoragePath: MAINNET_MOET_STORAGE_PATH, pushToDrawDownSink: false) | ||
|
|
||
| let borrowerPid: UInt64 = 1 |
Contributor
There was a problem hiding this comment.
mts1715
reviewed
Mar 30, 2026
| // | ||
| // debitRate = baseRate + (slope1 * utilization / optimalUtilization) | ||
| // FLOW: debitRate = 0 + 0.04 * (0.2 / 0.45) = 0.01777777777 (1.77% APY) | ||
| let expectedFLOWDebtRate = 0.01777777 |
Contributor
There was a problem hiding this comment.
declared, never used in any assertion
mts1715
reviewed
Mar 30, 2026
| // creditRate = debitRate * (1.0 - protocolFeeRate) | ||
| // protocolFeeRate = insuranceRate + stabilityFeeRate | ||
| // | ||
| // protocolFeeRate = 0.001 * 0.05 = 0.051 |
Contributor
There was a problem hiding this comment.
Suggested change
| // protocolFeeRate = 0.001 * 0.05 = 0.051 | |
| // protocolFeeRate = 0.001 + 0.05 = 0.051 |
mts1715
reviewed
Mar 30, 2026
| } | ||
|
|
||
| // ============================================================================= | ||
| /// Verifies protocol behavior when a lending pool has liquidity but no borrows. |
Contributor
There was a problem hiding this comment.
same description as at test_zero_credit_balance
Suggested change
| /// Verifies protocol behavior when a lending pool has liquidity but no borrows. | |
| /// Verifies that LP credit does not accrue when there are no borrows, | |
| /// then begins accruing once a borrower deposits and borrows. |
mts1715
reviewed
Mar 30, 2026
Comment on lines
+288
to
+290
| // debitIncome = 0.0 * 0.0 = 0.0 | ||
| // protocolFeeAmount = 0.0 | ||
| // totalCreditBalance = 0.0 -> creditRate = 0.0 |
Contributor
There was a problem hiding this comment.
But at this point totalCreditBalance = 5000 and totalDebitBalance = 100. This appears to be stale copy-paste from earlier in the test. The computed values in the comment don't match the state at that point.
mts1715
reviewed
Mar 30, 2026
Contributor
mts1715
left a comment
mts1715
left a comment
There was a problem hiding this comment.
few smal fixes should be done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #180
Context
fork_interest_rate_test.cdc, a newmainnet-forktest suite coveringKinkCurvebehavior across different scenarios.swapperInTypeIdentifier / swapperOutTypeIdentifierparameters tosetInsuranceSwapperhelper.receiverVaultStoragePathparameter towithdrawFromPositionhelper, making it return the transaction result instead of asserting internally.withdraw_from_position transaction, dropping the hardcodedFlowTokenpath.MAINNET_FLOW_HOLDER_ADDRESSconstant