Fix file_alloc() and file_open/close_ipc_handle()#865
Merged
ldorau merged 1 commit intooneapi-src:mainfrom Nov 5, 2024
Merged
Conversation
4 tasks
kswiecicki
approved these changes
Nov 5, 2024
vinser52
reviewed
Nov 5, 2024
ldorau
force-pushed
the
Fix_file_alloc_and_file_open_close_ipc_handle
branch
from
3a14747 to
7edcd28
Compare
Alignment passed to `file_alloc()` must be a power of two and a multiple or a divider of the page size. Align up the alignment in `file_alloc()` to the page size. file_open_ipc_handle() has to use the memory protection and visibility got from the IPC handle, so let's add the memory protection and visibility to the IPC handle. Ref: oneapi-src#838 Fixes: oneapi-src#848 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Fix_file_alloc_and_file_open_close_ipc_handle
branch
from
7edcd28 to
aada873
Compare
vinser52
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alignment passed to
file_alloc()must be a power of two and a multiple or a divider of the page size.Align up the alignment in
file_alloc()to the page size.file_open_ipc_handle()has to use the memory protection and visibility got from the IPC handle, so let's add the memory protection and visibility to the IPC handle.Ref: #838
Fixes: #848
Checklist