Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the
loadEnvfunction.The Bug:
putenv(envVar.c_str()), which is incorrect on many systems becausec_str()returns aconst char*whileputenvexpects achar*.envVaris a local variable. Passing its memory toputenvresults in a dangling pointer when the variable goes out of scope, leading to undefined behavior.The Solution:
putenvwithsetenv(key.c_str(), value.c_str(), 1).#include <cstdlib>forsetenv.setenvis the correct, portable, and safe way to set environment variables, as it manages its own memory for the values.This resolves the compilation error and fixes the underlying memory bug.