Apply settings to Plate

[will-moore]

Trying to fix issues with omero render copy Image:ID Plate:ID for idr0125 data (see IDR/idr0125-way-cellpainting#4 (comment)).

The main change here is to use the OMERO API self.gateway.applySettingsToSet(image_id, "plate", [plate_id]) for that command, instead of making a long list of Image IDs and applying it to those images.
This should improve performance, particularly for larger plates.

[will-moore]

Updated to this branch on idr0125-pilot... as root...

$ pip uninstall omero-cli-render
Found existing installation: omero-cli-render 0.7.0
$ pip install 'omero-cli-render @ git+https://github.com/will-moore/omero-cli-render@applySettingsToSe'
...
Successfully installed omero-cli-render-0.8.1.dev0

omero --debug=2 render copy Image:15910651 Plate:11002 > /tmp/idr0125_PR59_plate_11002.log 2>/tmp/idr0125_PR59_plate_11002.err;

[joshmoore]

What are the differences in semantics between render_images and get_images?

[will-moore]

The method just gets images, so I found it confusing being called render_images as that implies it was rendering images.
The rendering (loading thumbnails) happens at a later stage and takes much longer time than the initial getting images.

[dominikl]

I couldn't see a performance increase (tested on smaller plates like idr0139), but I think the PR would be good to merge, definitely makes the code easier to understand. Any objections? (/cc @jburel )

[jburel]

I think we should deprecate render_image and introduce a new one and render_image invokes the new method

[jburel]

to match the parameter name it is preferable to use "colorlist"
i.e. colors=colourlist

[will-moore]

That variable is created outside this PR. It feels like we are never going to get this merged!

[will-moore]

That spelling occurs 7 times in the file. Do I rename them all? Will it need retesting after that?

[jburel]

you introduce a new function. This is not a global variable.

[will-moore]

OK, renamed it