Add support for both esm and cjs output using rollup bundler, update node to 21, replace mocha test runner with native node test runner#68
Closed
anthony-y-zhu14 wants to merge 2 commits intoolosegres:masterfrom
Conversation
anthony-y-zhu14
changed the title
Author
|
this may also fix #66 |
Author
|
@olosegres could you please review the changes to see if it's okay? I happy to explain our usecases but basically we are hoping to have a esm distribution of this library 🙂 |
Owner
|
Thanks for the contribution! We've implemented dual ESM/CJS output in v1.13.0 with a similar approach but with some fixes:
Closing in favor of the merged implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output files:
. ├── LICENSE ├── README.md ├── README_0_2.md ├── lib │ ├── Jsona.cjs │ ├── Jsona.cjs.map │ ├── Jsona.d.ts │ ├── Jsona.js │ ├── Jsona.js.map │ ├── JsonaTypes.d.ts │ ├── builders │ │ ├── JsonDeserializer.cjs │ │ ├── JsonDeserializer.cjs.map │ │ ├── JsonDeserializer.d.ts │ │ ├── JsonDeserializer.js │ │ ├── JsonDeserializer.js.map │ │ ├── ModelsSerializer.cjs │ │ ├── ModelsSerializer.cjs.map │ │ ├── ModelsSerializer.d.ts │ │ ├── ModelsSerializer.js │ │ ├── ModelsSerializer.js.map │ │ ├── ReduxObjectDenormalizer.cjs │ │ ├── ReduxObjectDenormalizer.cjs.map │ │ ├── ReduxObjectDenormalizer.d.ts │ │ ├── ReduxObjectDenormalizer.js │ │ └── ReduxObjectDenormalizer.js.map │ ├── cache.cjs │ ├── cache.cjs.map │ ├── cache.d.ts │ ├── cache.js │ ├── cache.js.map │ ├── index.cjs │ ├── index.cjs.map │ ├── index.d.ts │ ├── index.js │ ├── index.js.map │ ├── simplePropertyMappers.cjs │ ├── simplePropertyMappers.cjs.map │ ├── simplePropertyMappers.d.ts │ ├── simplePropertyMappers.js │ ├── simplePropertyMappers.js.map │ ├── switchCasePropertyMappers.cjs │ ├── switchCasePropertyMappers.cjs.map │ ├── switchCasePropertyMappers.d.ts │ ├── switchCasePropertyMappers.js │ ├── switchCasePropertyMappers.js.map │ ├── utils.cjs │ ├── utils.cjs.map │ ├── utils.d.ts │ ├── utils.js │ └── utils.js.map ├── package-lock.json ├── package.json ├── rollup.config.js ├── src │ ├── Jsona.ts │ ├── JsonaTypes.ts │ ├── builders │ │ ├── JsonDeserializer.ts │ │ ├── ModelsSerializer.ts │ │ └── ReduxObjectDenormalizer.ts │ ├── cache.ts │ ├── index.ts │ ├── simplePropertyMappers.ts │ ├── switchCasePropertyMappers.ts │ └── utils.ts ├── tests │ ├── Jsona.test.ts │ ├── ModelsSerializer.test.ts │ ├── ReduxObjectDenormalizer.test.ts │ ├── mocks.ts │ └── switchCasePropertyMappers.test.ts └── tsconfig.json