Tutorials by coder-odoo · Pull Request #1174 · odoo/tutorials

coder-odoo · 2026-02-16T13:44:47Z

No description provided.

robodoo · 2026-02-16T13:44:50Z

AlessandroLupo

Nice work! :D I added a couple of comments. Please make sure that your commit messages follow the guidelines. 👍

AlessandroLupo · 2026-02-16T13:59:07Z

estate/models/__init__.py

+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import estate_property


Remember to add an empty line at the end of each file ;)

estate/models/estate_property.py

estate/__manifest__.py

AlessandroLupo

Thanks for the changes, it looks fine now! 👍

…erience

AlessandroLupo

Good job, it's nice that you got a green runbot. 👍 I added a couple of minor comments.
As a git exercise, you could try to do an interactive rebase and leave only one commit per chapter (you could also add the chapter number to the commit messages). To achieve this, you could just squash the commit fixing the runbot with the previous commit. Let me know if you need support with git!

AlessandroLupo · 2026-02-18T09:35:00Z

estate/views/estate_list_views.xml

+        <field name="arch" type="xml">
+            <list string="Properties">
+                <field name="name"/>
+                <field name="tag_ids"/>


You could use widget="many2many_tags" to have the actual tag names displayed on each line ;)

AlessandroLupo · 2026-02-18T09:36:09Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_property_type,access_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_property_tag,access_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_property_offer,access_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


No empty line at the end of file 😄

AlessandroLupo · 2026-02-18T09:39:37Z

estate/models/estate_property_type.py

+
+class EstatePropertyType(models.Model):
+    _name = "estate.property.type"
+    _description = "A table for estate properties types"


Nitpick: briefly explore the Odoo codebase searching for _descrption. You will see that we tend to use a more concise style. I would use something like "Estate Property Type".

AlessandroLupo

Good job with the git exercise! 👍

AlessandroLupo · 2026-02-19T10:14:04Z

estate/views/estate_list_views.xml

        <field name="model">estate.property</field>
        <field name="arch" type="xml">
-            <list string="Properties">
+            <list string="Properties" decoration-success="state == 'offer_received' or state == 'offer_accepted'" decoration-bf="state == 'offer_accepted'" decoration-muted="state == 'sold'">


You could also use decoration-success="state in ('offer_received', 'offer_accepted')"

AlessandroLupo · 2026-02-19T13:10:35Z

estate/models/res_users.py

Try to search the Odoo codebase for the line _inherit = 'res.users'. You will see what is the common style for inherited classes. The class should be named "ResUsers" and the file should be named "res_users". ;)

AlessandroLupo

Good job! 👍

AlessandroLupo · 2026-02-20T08:51:35Z

estate_account/models/estate_property.py

+from odoo import models
+
+
+class EstatePropertyInherited(models.Model):


Nitpick: the conventional name here would be EstateProperty (no need to add "Inherited") ;)

AlessandroLupo

Nice work 👍

AlessandroLupo · 2026-02-20T12:32:03Z

awesome_owl/static/src/card/card.xml

+                <h5 class="card-title"><t t-esc="props.title"/></h5>
+                <p class="card-text">
+                    <t t-out="props.content"/>


You could also do:

<h5 class="card-title" t-out="props.title"/> <p class="card-text" t-out="props.content"/>

AlessandroLupo · 2026-02-20T12:36:05Z

awesome_owl/static/src/counter/counter.js

+        if (this.props.onChange) {
+            this.props.onChange();
+        }


Here you could use optional chaining: this.props.onChange?.().

AlessandroLupo · 2026-02-20T12:51:15Z

awesome_owl/static/src/todo/todo_list.js

+    }
+
+    addTodo(ev) {
+        if (ev.keyCode === 13 && ev.target.value != "") {


You could also use ev.key === "Enter" (see here). keyCode is deprecated

AlessandroLupo · 2026-02-20T12:54:51Z

awesome_owl/static/src/todo/todo_list.js

+    static template = "awesome_owl.todo_list";
+
+    setup() {
+        this.todos = useState([]);


Here I would do this.state = useState({todos: []}), and later access the todos array using this.state.todos, so it is clear that todos is in the component state.

AlessandroLupo

You're doing well! Just two comments

AlessandroLupo · 2026-02-20T15:02:27Z

awesome_owl/static/src/card/card.js

    static props = {
-        title: String,
-        content: String,
+        title: { type: String },


Just to be clear, title: String was fine too (it is assumed implicitly that you are defining the type), but feel free to use the style you prefer 👍

AlessandroLupo · 2026-02-20T15:31:57Z

awesome_owl/static/src/todo/todo_list.js

+    removeTodo = (todoId) => {
+        const index = this.todos.findIndex((t) => t.id === todoId);
+        if (index > 0) {
+            this.todos.splice(index, 1);
+        }
+    }


Will this work if we try to remove the first element in the todo list (index 0)?

coder-odoo · 2026-02-23T07:50:31Z

Thanks for your comments. I'm on it

AlessandroLupo

You're doing good, I left couple of comments. 👍 Don't hesitate to ask if something is not clear!

AlessandroLupo · 2026-02-23T14:23:01Z

awesome_owl/static/src/counter/counter.js

+
+    increment() {
+        this.state.value++;
+        this.props.onChange?.(this.props.onChange());


Probably what you want to do here is this.props.onChange?.(), which means "if onChange exists, call it".
The way you coded it, this.props.onChange() gets evaluated once, and then passed as an argument to a second call to this.props.onChange() (that's why the counter increases by two times instead of one). Moreover the purpose of ?.() is undermined, because if this.props.onChange does not exist, you would still get an error. ;)

AlessandroLupo · 2026-02-23T14:32:24Z

awesome_owl/static/src/todo/todo_list.js

+    }
+
+    focusInput() {
+        this.myRef.el.focus();


Something seems incomplete here, right? myRef is not defined and focusInput is never called?
See how it is done here, for example ;)

AlessandroLupo

The dashboard is looking nice! 👍 Two minor comments

AlessandroLupo · 2026-02-23T15:58:05Z

awesome_dashboard/static/src/services/statistics_service.js

+const loadStatistics = memoize(async () => {
+    return rpc("/awesome_dashboard/statistics", {});
+});


Just a small remark. The function return rpc("/awesome_dashboard/statistics", {}); does nothing asyncronous. It actually just returns the promise from rpc without awaiting for it. So tecnically the keyword async is not needed. Anyway since it does no harm and makes the code clearer, someone may prefer to add it. So it is just a matter of style, up to you 👍

Also, return can be made implicit:

const loadStatistics = memoize(async () => rpc("/awesome_dashboard/statistics", {}));

AlessandroLupo · 2026-02-23T16:19:29Z

awesome_dashboard/static/src/dashboard.scss

You could have .o_dashboard_row, .o_header_dashboard_item, and .o_average_quantity nested in .o_dashboard

AlessandroLupo

Good job! I left some comments but they all are minor observations / questions

AlessandroLupo · 2026-02-25T08:52:41Z

awesome_dashboard/static/src/dashboard/Dashboard/dashboard.js

+        try {
+            const value = localStorage.getItem(STORAGE_KEY);
+            const parsed = value ? JSON.parse(value) : [];
+            return Array.isArray(parsed) ? parsed : [];
+        } catch {
+            return [];
+        }


What kind of error do you expect to catch here? I see that the case where the key does not exists is already correctly covered in the try block. In general there may be errors that we may want to display to the user, instead of just silently failing. For example, I see from the documentation that accessing localStorage could throw a SecurityError if the user configured the browser to discard persisting data. In this case, we may want to show a notification to inform the user. (This is just to let you know, you don't have to do it 😄 )

AlessandroLupo · 2026-02-25T08:53:25Z

awesome_dashboard/static/src/dashboard/Dashboard/dashboard.js

+    }
+
+    saveRemovedItemIds(removedItemIds) {
+        localStorage.setItem(STORAGE_KEY, JSON.stringify(removedItemIds));


If the idea is to catch every error coming from localStorage, you may want a try/catch also here

AlessandroLupo · 2026-02-25T09:00:03Z

awesome_dashboard/static/src/dashboard/Dashboard/dashboard.js

+    }
+
+    get items() {
+        const removedIds = new Set(this.state.removedItemIds);


Good idea to use a Set to have a faster search. Two minor comments:

Here we have a maximum of 6 elements, so no big difference between O(1) or O(n) searches

You could keep this.state.removedItemIds always as a set, so we don't need to create a set every time we access items

AlessandroLupo · 2026-02-25T09:00:52Z

awesome_dashboard/static/src/dashboard/Dashboard/dashboard.js

+        this.dialogService.add(DashboardSettings, {
+            title: "Dashboard settings",
+            removedItemIds: this.state.removedItemIds,
+            applyConfiguration: (removedItemIds) => this.saveRemovedItemIds(removedItemIds),


Or applyConfiguration: this.staveRemovedItemIds.bind(this)

AlessandroLupo · 2026-02-25T10:05:44Z

awesome_dashboard/static/src/dashboard/services/statistics_service.js

+
+async function loadStatistics() {
+    const result = await fetchStatistics(refreshToken);
+    statistics.average_quantity = result.average_quantity;


You could also use something like Object.assign(statistics, result)

AlessandroLupo · 2026-02-25T10:07:34Z

awesome_dashboard/static/src/dashboard/services/statistics_service.js

+    },
+});
+
+let refreshToken = 0;


Why do we need the refreshToken?

AlessandroLupo

Good job with the tests 👍 Have you tested them on your local Odoo instance? Don't hesitate to ask if you need help with that.

AlessandroLupo · 2026-02-25T14:26:47Z

estate/models/estate_property.py

+            if record.state == 'canceled':
                error_msg = "You cannot sell a canceled property."
                raise UserError(error_msg)


Note that this section of code if record.state == 'cancelled' will never be reached, because if state is cancelled the previous if condition is true and an error is raised there

AlessandroLupo self-requested a review February 16, 2026 13:56

AlessandroLupo requested changes Feb 16, 2026

View reviewed changes

[ADD] estate: fix errors in the previous commit

34e5c4f

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 91e995b to 34e5c4f Compare February 16, 2026 15:01

AlessandroLupo reviewed Feb 16, 2026

View reviewed changes

coder-odoo added 5 commits February 16, 2026 16:30

[IMP] estate: Adding access rights for the group user

f6b71c7

[IMP] estate: Adding default UI

ae8e6d9

[IMP] estate: Adding custom form/list and a search engine

04a9478

[IMP] estate: Adding Tags, offers, property type, salesman and buyer

c2bb0ee

[IMP] estate: Adding computed/onchange fields to improve the user exp…

3d095b8

…erience

AlessandroLupo reviewed Feb 18, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch from e9bada5 to f8501db Compare February 19, 2026 08:22

coder-odoo added 3 commits February 19, 2026 09:28

[IMP] estate: Adding Sold/Cancel button and Accepted/Refused offer

bca84cb

[IMP] estate: Make sure that the data stays consistent

799b2e2

[IMP] estate: Add The Sprinkles

d31c05f

coder-odoo force-pushed the 19.0-Tutorials-coder branch 4 times, most recently from a2148ad to c501952 Compare February 19, 2026 12:08

AlessandroLupo reviewed Feb 19, 2026

View reviewed changes

coder-odoo added 2 commits February 19, 2026 15:27

[IMP] estate: Adding inheritance

f6ffdb2

[IMP] estate: Adding interaction with the Invoicing app

0338f3c

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 1bfcf89 to 0338f3c Compare February 19, 2026 14:27

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

[IMP] estate: Adding Kanban views

9dda914

coder-odoo force-pushed the 19.0-Tutorials-coder branch 2 times, most recently from 72594a6 to f7ee509 Compare February 20, 2026 10:56

AlessandroLupo reviewed Feb 20, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch 3 times, most recently from 86c1fa8 to 4c76c44 Compare February 23, 2026 09:45

[IMP] estate: Adding a button to link the property to the invoice

f260cfe

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 4c76c44 to 4efd9e6 Compare February 23, 2026 10:11

AlessandroLupo reviewed Feb 23, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch from b9b6b92 to bc8b5a3 Compare February 23, 2026 14:59

AlessandroLupo reviewed Feb 23, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch 4 times, most recently from fa2964f to f55c683 Compare February 24, 2026 08:14

[ADD] awesome_owl: Js - All Part 1

2590d73

coder-odoo force-pushed the 19.0-Tutorials-coder branch 4 times, most recently from 5a6af10 to 88e2655 Compare February 25, 2026 09:04

AlessandroLupo reviewed Feb 25, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch from a25af91 to 241973e Compare February 25, 2026 14:20

AlessandroLupo reviewed Feb 25, 2026

View reviewed changes

coder-odoo force-pushed the 19.0-Tutorials-coder branch 2 times, most recently from 1592d6d to 235c4ca Compare February 26, 2026 08:32

coder-odoo added 3 commits February 26, 2026 09:58

[ADD] awesome_dashboard: JS - All part 2

08a98ed

[IMP] estate: Adding define module data

0fa2f47

[IMP] estate: Adding safeguard your code with unit tests

d2f3243

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 235c4ca to d2f3243 Compare February 26, 2026 08:58

[IMP] estate: Adding restrict access to data

56f00cd

coder-odoo force-pushed the 19.0-Tutorials-coder branch from 08f0314 to 56f00cd Compare February 27, 2026 10:40

		from odoo import models


		class EstatePropertyInherited(models.Model):

Conversation

coder-odoo commented Feb 16, 2026

Uh oh!

robodoo commented Feb 16, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coder-odoo commented Feb 23, 2026

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlessandroLupo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment