[ADD] Timesheets: configuration and basics#16459
Closed
Conversation
Collaborator
|
|
auva-odoo
changed the title
auva-odoo
requested changes
Feb 19, 2026
Contributor
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Thank you for your work @guga-odoo, it was nice to learn a bit more about this app! In addition to my review comments:
- Could you please change your commit message when you amend your commit to copy the ame of the PR (that I already changed)? And just as a reminder, commit messages should be no longer than 70 characters (I think, although the guidelines say 50 so i'm not sure)
- Don't forget to use the format app name/file name/anchor name for the refs, so in this case: timesheets/timesheets/xxx
As usual, don't hesitate if you have questions or if you'd like to discuss something in particular. Thanks!
guga-odoo
force-pushed
the
19.0-timesheets-general-guga
branch
2 times, most recently
from
0bd8ca6 to
ec4ef15
Compare
auva-odoo
requested changes
Feb 24, 2026
Contributor
auva-odoo
left a comment
auva-odoo
left a comment
There was a problem hiding this comment.
Thank you very much for the changes @guga-odoo! I have a few more comments and also:
- Could you please change the anchor names in this file to use the format app name/file name/anchor name for the refs, so in this case: timesheets/timesheets/xxx (e;g., on lines 112, 138, and 155) --> Let me know if you need me to help you with these!
- Sorry I know I'm annoying but could you please uniformize popup/pop-up throughout this doc?
Thanks!
guga-odoo
force-pushed
the
19.0-timesheets-general-guga
branch
2 times, most recently
from
1f005b4 to
c915b67
Compare
task-5948476
auva-odoo
force-pushed
the
19.0-timesheets-general-guga
branch
from
c915b67 to
1decac6
Compare
auva-odoo
approved these changes
Feb 27, 2026
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task-5948476