[IMP] Inventory: Bringing least packages current#15753
[IMP] Inventory: Bringing least packages current#15753erjer-odoo wants to merge 1 commit intosaas-18.3from
Conversation
|
|
|
Hi @larm-odoo ! I'm finishing up work on the removal strategies docs. This update brings it current, as well as consistent with the other removal strategies docs that I worked on last week. When you get a moment, can you review and let me know what you think? Thank you! |
larm-odoo
left a comment
larm-odoo
left a comment
There was a problem hiding this comment.
Hi @erjer-odoo - great explanation for this. Most of my suggestions are just that, suggestions, so take what you want and toss the rest. My only concern was the last part, in the image with the flour, I can't see how the user would know that the 100kg bag was used. So I would add something else to show how that is verified. Tag me again for a quick look when you're done!
erjer-odoo
force-pushed
the
saas-18.3-inventory-least-packages-erjer
branch
from
e42019a to
bcbbd7c
Compare
|
Hi @larm-odoo -- I've updated with your comments. Would you be willing to take another look for me? Thank you! |
larm-odoo
left a comment
larm-odoo
left a comment
There was a problem hiding this comment.
AWESOME job on the edits, @erjer-odoo! I just eft optional comments- nothing major, so I am approving. i did leave a comment ON an image instead of in the file, so just be sure to take a look there. Nicely done!
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
erjer-odoo
force-pushed
the
saas-18.3-inventory-least-packages-erjer
branch
from
f3f8a2f to
e1df946
Compare
|
Hi @Felicious -- I've addressed the concerns raised by @larm-odoo, and she's approved what's there. When you have a moment, could you take a look? If you also approve, could you help me merge? Thank you! |
|
Good work here, @erjer-odoo ! @robodoo r+ |
closes #15753 Signed-off-by: Felicia Kuan (feku) <feku@odoo.com> Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com> Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
4 participants
While working on the removal strategies overview script, I realized that the documentation for "Least packages removal" was out of date. In this PR, I did the following:
All of this work makes the last of the removal strategies docs consistent with the other removal strategies docs.
This saas-18.3 PR can be FWP up to master.