Throw error in console if :on-success and :on-failure not provided in :request effect map#2
Open
pianostringquartet wants to merge 1 commit intooconn:masterfrom
Conversation
… :request effect map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we do not provide
:on-successor:on-failure,handle-requestdefaults to:http-no-on-successand:http-no-on-failure.However, there do not seem to be handlers registered for these, and thus re-frame complains about
no :event handler registered for ...:(In the screenshot we failed to provide an
on-failurehandler.)The consumer of the library will either have to (1) register handlers for those events, or (2) always provide
on-successandon-failure.This PR is a naive attempt to force the user to do (2): we warn (in the console) when
on-successand/oron-failurehave not been provided.(Big diff just because of indentation change.)