Skip to content

Do not abort on ping failure#1238

Open
giurgiur99 wants to merge 2 commits intomainfrom
large-files-ping-error
Open

Do not abort on ping failure#1238
giurgiur99 wants to merge 2 commits intomainfrom
large-files-ping-error

Conversation

@giurgiur99
Copy link
Contributor

@giurgiur99 giurgiur99 commented Feb 28, 2026

Fixes # .

Changes proposed in this PR:

  • The connection monitor runs a heartbeat (ping) on every connection every 10s. If that ping fails (e.g. timeout while the connection is busy with a large download), it was calling conn.abort(err) because abortConnectionOnPingFailure is true by default. That aborts the whole connection and all its streams, including result stream.

@giurgiur99 giurgiur99 mentioned this pull request Feb 28, 2026
Open
@giurgiur99 giurgiur99 marked this pull request as ready for review February 28, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@denisiuriet denisiuriet Awaiting requested review from denisiuriet denisiuriet is a code owner

@ndrpp ndrpp Awaiting requested review from ndrpp ndrpp is a code owner

@andreip136 andreip136 Awaiting requested review from andreip136 andreip136 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@giurgiur99